unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: Eric Bavier <bavier@posteo.net>,
	65357@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#65357] [PATCH] gnu: scilab: Fix compilation error.
Date: Wed, 30 Aug 2023 11:47:34 +0200	[thread overview]
Message-ID: <ZO8QNlTYUPJ-Dgdv@jurong> (raw)
In-Reply-To: <ZN-3HT15NUDqFw-O@jurong>

Hello,

Am Fri, Aug 18, 2023 at 08:23:25PM +0200 schrieb Andreas Enge:
> ../../modules/string/includes/os_string.h:107:25: error: ‘strcasecmp’ was not declared in this scope; did you mean ‘wcscasecmp’?
>   107 | #define stricmp         strcasecmp
>       |                         ^~~~~~~~~~
> src/cpp/funcmanager.cpp:134:9: note: in expansion of macro ‘stricmp’
>   134 |     if (stricmp("utf-8", encoding) == 0)
>       |         ^~~~~~~
> The file looks unchanged in the latest git commit of scilab, and I have not
> seen a corresponding patch in the Debian package, so I have given up.

"man strcasecmp" has this to say:
NOTES
       The  strcasecmp()  and  strncasecmp() functions first appeared in 4.4BSD, where they were declared in
       <string.h>.  Thus, for reasons of historical compatibility, the glibc <string.h> header file also de‐
       clares  these  functions, if the _DEFAULT_SOURCE (or, in glibc 2.19 and earlier, _BSD_SOURCE) feature
       test macro is defined.

So it might be enough to just add "#define _DEFAULT_SOURCE" somewhere.

Andreas





  reply	other threads:[~2023-08-30  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 18:15 [bug#65357] [PATCH] gnu: scilab: Fix compilation error Nicolas Graves via Guix-patches via
2023-08-17 18:42 ` Andreas Enge
2023-08-18 18:23   ` Andreas Enge
2023-08-30  9:47     ` Andreas Enge [this message]
2023-08-31 12:17       ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO8QNlTYUPJ-Dgdv@jurong \
    --to=andreas@enge.fr \
    --cc=65357@debbugs.gnu.org \
    --cc=bavier@posteo.net \
    --cc=efraim@flashner.co.il \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).