From: Andreas Enge <andreas@enge.fr>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: Eric Bavier <bavier@posteo.net>,
65357@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#65357] [PATCH] gnu: scilab: Fix compilation error.
Date: Thu, 17 Aug 2023 20:42:12 +0200 [thread overview]
Message-ID: <ZN5qBMyRq5vFizuz@jurong> (raw)
In-Reply-To: <03a288df56dc60850e6a8c0fc2785949e209f33a.1692296107.git.ngraves@ngraves.fr>
Hello Nicolas,
Am Thu, Aug 17, 2023 at 08:15:07PM +0200 schrieb Nicolas Graves:
> + (substitute* "modules/output_stream/src/cpp/diary_manager.cpp"
> + (("if \\(array_size > 0\\)")
> + "if (*array_size > 0)"))
the fix looks right to me. But our scilab version is 8 years old, while there
are newer versions around. Would it make sense to rather update the package
to a newer version? (I had a look at 5.2.2, 6.0.0 and 6.1.1, but all of them
would still require your suggested fix.)
Andreas
next prev parent reply other threads:[~2023-08-17 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 18:15 [bug#65357] [PATCH] gnu: scilab: Fix compilation error Nicolas Graves via Guix-patches via
2023-08-17 18:42 ` Andreas Enge [this message]
2023-08-18 18:23 ` Andreas Enge
2023-08-30 9:47 ` Andreas Enge
2023-08-31 12:17 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN5qBMyRq5vFizuz@jurong \
--to=andreas@enge.fr \
--cc=65357@debbugs.gnu.org \
--cc=bavier@posteo.net \
--cc=efraim@flashner.co.il \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).