From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AGQMF4hHwWRXZAEASxT56A (envelope-from ) for ; Wed, 26 Jul 2023 18:19:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GAncFohHwWS2yAAAauVa8A (envelope-from ) for ; Wed, 26 Jul 2023 18:19:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8D5C545E1 for ; Wed, 26 Jul 2023 18:19:19 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690388359; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=PQPZgUhYOBkc4iv2oGy2bbud+vVVkor5BsgMFGcXlGI=; b=nsi85gnhA68yGNR3DxWZgI/0Nh/0/dKsWfuBdQ0UDG+v0jWR32Io40L+Sqlcn0SsSaVqfQ NdEWYwpLjSYPg3ECGcNk5S4z1w0u3bkUpNDf9r+viYrxgtyhzNEBUzwSeLn4ut+D60reLD XlnycWfis8SScNQZxlJt7co03KUAB86vYVEMd5a5ZE93y/xfnFNXZpvHMW+orPeQuPrmNK aNQUs8HuoS2MQ4eMIBxFm7/i+wJFo9Qr4By3fTrO8aEGaEzX+bRbyC9nAi9N6Wtcd2I2wL LtmAoFtg1AQz7cmj4N1p5zEkJtcqisMmlUUXrcSgxWwjjzK1yxim5CrnsQ2IVg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690388359; a=rsa-sha256; cv=none; b=WnKIrIskaoK7I13DS2yojuBxaJ6+m313DbE8pqJ+HKGawNoorJkpf947LrqltwAYpTMCHW +AfGfJkuYj1w3Ijsfgt/E9Wm7qSlAtDRoKmfMa12lGl/HprduI4EpKVbOSbyggwU+XSvfC Ye1zXqUzwUoQGcE1oF3LzUktYZjCAI4lT7vNL/s3dZYHsgRpFa8ERlQx304FrkHspuwDjI UoFAiJgBk21C4vn5JQ8OgQ/eYuaAW/RfBIrYqisEmFECtt/XdpFjFdOAOvNBrzbc0f2Z8Z q7lREGw5Sevl3o5EfMOQ2X3W2hMmxd/x+4YqvV+NDIvb8dSFS26f8D1JdwSsww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOh6j-00050t-Dl; Wed, 26 Jul 2023 12:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOh6N-0004u8-23 for guix-patches@gnu.org; Wed, 26 Jul 2023 12:11:10 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOh6M-00040h-Qa for guix-patches@gnu.org; Wed, 26 Jul 2023 12:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOh6M-0004t3-EZ for guix-patches@gnu.org; Wed, 26 Jul 2023 12:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64446] [PATCH] gnu: Add bliss. Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Jul 2023 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64446 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Elsing Cc: 64446@debbugs.gnu.org, efraim@flashner.co.il, bavier@posteo.net Received: via spool by 64446-submit@debbugs.gnu.org id=B64446.169038784218756 (code B ref 64446); Wed, 26 Jul 2023 16:11:02 +0000 Received: (at 64446) by debbugs.gnu.org; 26 Jul 2023 16:10:42 +0000 Received: from localhost ([127.0.0.1]:49942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOh61-0004sR-PV for submit@debbugs.gnu.org; Wed, 26 Jul 2023 12:10:42 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]:51238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOh5x-0004sC-Qd for 64446@debbugs.gnu.org; Wed, 26 Jul 2023 12:10:39 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 0D69D369; Wed, 26 Jul 2023 18:10:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i112eFBrDaBv; Wed, 26 Jul 2023 18:10:29 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 14D2B2A1; Wed, 26 Jul 2023 18:10:29 +0200 (CEST) Date: Wed, 26 Jul 2023 18:10:27 +0200 From: Andreas Enge Message-ID: References: <5840cd3331640479ee55e604b4e5080be85819ba.1688419275.git.david.elsing@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5840cd3331640479ee55e604b4e5080be85819ba.1688419275.git.david.elsing@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.66 X-Spam-Score: -5.66 X-Migadu-Queue-Id: E8D5C545E1 X-Migadu-Scanner: mx1.migadu.com X-TUID: Yn0hY+OlLk5L Hello, I have spent quite a long time on this package, trying to simplify your recipe. Am Mon, Jul 03, 2023 at 09:21:32PM +0000 schrieb David Elsing: > + (add-after 'unpack 'fix-string-macro > + (lambda _ > + (substitute* "bliss.cc" > + (("\"__DATE__\"") "\" __DATE__ \"")))) This so far is only a warning with newer gcc versions, so we do not really need it. > + ;; Move headers under the bliss/ prefix > + (add-after 'unpack 'move-headers > + (lambda _ > + (substitute* (find-files "." "\\.(h|hh|cc)$") > + (("#include \"(.*)\"" all path) > + (string-append "#include "))) > + (mkdir-p "bliss") > + (for-each > + (lambda (file) > + (rename-file file > + (string-append "bliss/" (basename file)))) > + (find-files "." "\\.(h|hh)$")))) All surprising phases need more comments for their rationale. I added this: ;; Move headers under the bliss/ prefix. This is a Guix choice, ;; since the header names are sufficiently generic to cause ;; confusions with other packages ("heap.hh"). > + (add-after 'move-headers 'disable-gmp > + (lambda _ > + (substitute* "bliss/bignum.hh" > + (("defined\\(BLISS_USE_GMP\\)") "0")))) This looks like it is not needed if using the Makefile. > + (replace 'build Here I am not convinced. You end up rewriting the Makefile in Guile. The Makefile works, but it tries to create a binary "bliss", which collides with the new file for the headers. This could be solved by moving the content of the 'move-headers phase between the installation of the bliss binary (after which it can be deleted) and the installation of the headers. Moreover, the Makefile does not create a dynamic, but only a static library, and your build phase adds a dynamic library. Is this our role as packagers? According to the time stamps of the files inside the .zip, the software dates from 2015 and is apparently unmaintained (otherwise I would have suggested to get in touch with the developers to improve the Makefile). So I wonder whether this software meets the quality standards for inclusion into Guix. Hm, I just found a new version here: https://users.aalto.fi/~tjunttil/bliss/index.html : "Compiling In Linux and macOS, one can use GNU Make to compile the bliss executable, as well as the static and shared libraries, with (...)"! And the author is here: https://users.aalto.fi/~tjunttil/ Would you like to give it another try, David? And maybe discuss with the author whether they would be willing to implement the bliss/ subdirectory for the headers? (Given that there are now separate src/ and build/ subdirectories that would be quite easy.) And add an "install" target? Andreas