From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wDbNE1MSimTrGgAASxT56A (envelope-from ) for ; Wed, 14 Jun 2023 21:17:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UGHIElMSimR/SgEAG6o9tA (envelope-from ) for ; Wed, 14 Jun 2023 21:17:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09FC22B52A for ; Wed, 14 Jun 2023 21:17:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9VzM-0001bZ-Q5; Wed, 14 Jun 2023 15:17:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9VzL-0001b2-Fd for guix-patches@gnu.org; Wed, 14 Jun 2023 15:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9VzL-0000mb-72 for guix-patches@gnu.org; Wed, 14 Jun 2023 15:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9VzK-0001sA-Nf for guix-patches@gnu.org; Wed, 14 Jun 2023 15:17:02 -0400 Subject: bug#63786: [PATCH] home: services: ssh: Allow unset boolean Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 14 Jun 2023 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63786 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 63786-done@debbugs.gnu.org Received: via spool by 63786-done@debbugs.gnu.org id=D63786.16867702177180 (code D ref 63786); Wed, 14 Jun 2023 19:17:02 +0000 Received: (at 63786-done) by debbugs.gnu.org; 14 Jun 2023 19:16:57 +0000 Received: from localhost ([127.0.0.1]:45479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9VzF-0001rk-3O for submit@debbugs.gnu.org; Wed, 14 Jun 2023 15:16:57 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:54301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9VzD-0001rO-0W for 63786-done@debbugs.gnu.org; Wed, 14 Jun 2023 15:16:55 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f7368126a6so9517545e9.0 for <63786-done@debbugs.gnu.org>; Wed, 14 Jun 2023 12:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686770209; x=1689362209; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=jLiFYHAJWw1q+e8vlPQZGgDuYgBpRobxofdM4syKk4w=; b=jDy/f40+gJKoh6wJ3ty4RLTnZqRoyYf0Jhmo3QkAuRFESzSAMU1vL85ySdpxP2zFBt ubYE6BQklrdrvxqLXPJvMjl7Vpg77P5t94HNXm7WGzk2RV1SMcXL5E7WhsDrB9CeeuVx AJ15+7z5QucbnyOR2VBs4Tg1wViNHOqavU3JdfV/TcY5pKXo47g6BCuOvj9wmgGtltKO oRNQRl9IuFLKJIUgUI/yp6GVLP/9QWpSamy2uClg2h7hWC7/V/3wwxT9Fl50wlL1McgE AEQQNgS099mk60+LNUEQrsZt5SToMbhoGGsxpo18XYoCp6lqIZQW4AhB470Ztz/vQDAg OZUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686770209; x=1689362209; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jLiFYHAJWw1q+e8vlPQZGgDuYgBpRobxofdM4syKk4w=; b=WPfmhNNF0LQWVesvZiW5QzdRXkEI9a4sA3R9sz92LuZ2hmJYmzyf1/Ex1GhdroMC/H +/T2+rvmZyYirI3Uqv2MyiYehdrB2eavDhEvZce0994HvLpNhjUrm0m77mveFttia3J9 alHVhbGJOaVJdEvYJsiWFpNt0NZ4/8oKbgFx7gebrOUdjBShW5nKmgz4d798TJ9ByP2F ZETNrtlSOdXMUDfWYmB9zg55UBGj2OqOSrtqcGHqDKBeyEvGnPb56LhbWGS3uflj3Nrd KYY2QtD1oT0o0TRrW+a2DVLOy6jDCvmNnsnUwpqupRMnx9Zmu+n+EE7rfcXjcdJ/PJ6u +W7A== X-Gm-Message-State: AC+VfDyjJtliFvIcV57tF57M0BHmIl5JddmnveT0e7gRhSkMTY65kyBT A2rZmLqgoxNI4nO4c8IUi9jAKv6i0jUchg== X-Google-Smtp-Source: ACHHUZ72XUJbAuKpdSIRMhH9X1UVSaosedLkh2PI0xNWyag6QApZh5COyJJBq19c44vGuFwF90AY7g== X-Received: by 2002:a7b:cd8a:0:b0:3f7:e605:287c with SMTP id y10-20020a7bcd8a000000b003f7e605287cmr10189151wmj.40.1686770209104; Wed, 14 Jun 2023 12:16:49 -0700 (PDT) Received: from localhost ([37.46.46.3]) by smtp.gmail.com with ESMTPSA id k7-20020adfe3c7000000b0030fce98f40dsm5099142wrm.42.2023.06.14.12.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 12:16:48 -0700 (PDT) Date: Wed, 14 Jun 2023 22:16:47 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Andrew Tropin , 63786-done@debbugs.gnu.org References: <6f1959b0041895af538fec1b72a02d7767451767.1685371966.git.efraim@flashner.co.il> <87r0qhmg45.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D21NRbksaTQGHQVl" Content-Disposition: inline In-Reply-To: <87r0qhmg45.fsf@trop.in> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686770259; a=rsa-sha256; cv=none; b=T4KTjN+1g/bMEZeQJrwInPLyHEf+YocHPXY9XfaR29ro73Hqa0Wg8cLe8mPIJJBI5VJNgS v7p9ql3EQaYjLkfwR/T/dOa3tJ5Eb/x4Uei37j6/Prg/t5Lmc1TWteuEsW2h9gsJw+F4YF TKGk6F6sWXbTFnvNFd0pQE/bDJQWkNsFxM6Om6VkVppXoHaUiBxT7Ot0dvs58DV6bfyGyz e2ih0u3Pw6Z9Mqhdw8fG4FaQ4BTRCgMuRyFNlqJ7tjatz28q3S7JXY+yeQRtNFa9JZIV1s 0v2LQAcHlsnCWWfkb9Az1+ypNEMBbx8s1Egy0lJjYv1yvycvdCAzgger0orN+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="jDy/f40+"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686770259; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=jLiFYHAJWw1q+e8vlPQZGgDuYgBpRobxofdM4syKk4w=; b=PWufafF0T2EntoCwxSV4e6OtewJ/4W8/KhBvrSqyLqV5wi2vEMQ/pGynj6OWm+MfhJUIUM kkvwlVSWGGwHmUfwUnYYyp0PEmk2x+OwgR9odqkz/0vMd1jRpkdvdK0DSIIEh+IrRTW/qE zHkRPmCD/DEFzyBKEQTXKwwYLjzrYatnwmm+QCe91dxwCM6bBLvbXmEh3jEGgRHvjxZRLx 0eaabFIqockk5ED8nZa9Cr28+NKvnVsXdCn64F/jyC4uLhDjAKitKaKIXFA2BFiNJazcLz JNvq7Sx7SHD8pbYx83a5JTt7Ujee3IOgp2cwRrZwSJTPDFz6Jd7WdOE967fmBA== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="jDy/f40+"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.13 X-Spam-Score: -4.13 X-Migadu-Queue-Id: 09FC22B52A X-TUID: IPN65QpeWDsR --D21NRbksaTQGHQVl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 12, 2023 at 08:58:18AM +0400, Andrew Tropin wrote: >=20 > A few years ago, when we were implementing the first version of ssh home > service in rde we went a slightly different way and didn't hardcode any > record fields and let user set an alist of key/value pairs: > https://git.sr.ht/~abcdw/rde/tree/19c2d2f0996624eea8b7a87b14bbc31e4a9b943= b/src/gnu/home-services/ssh.scm#L204 >=20 > It's not a perfect solution either, but quite flexible. Also, it's > relatively easy to implement default values: we can provide > %default-host-options and ask people to do something like this on user > side configuration: >=20 > (merge %default-host-options '((compression . #f))) >=20 > Of course "asking people" won't work, so it's possible to set a default > value of options field to %default-host-options > https://git.sr.ht/~abcdw/rde/tree/19c2d2f0996624eea8b7a87b14bbc31e4a9b943= b/src/gnu/home-services/ssh.scm#L100 > and let people override it with '((compression . #f)) or enrich with > (merge %default-host-options '((compression . #f))). >=20 > It's not a proposal or something, just sharing how it's implemented in > rde. I'm still undecided about the alist as a comparison. It would make it easier to add arbitrary fields, but then I feel like maybe we should be adding something to validate the configurations. > P.S. Note that (gnu home-services *) modules are subject to deprecation > and when (rde home services ssh) appear, it will have a slightly > different interface. I went ahead and pushed the patch. I believe that, after having added to a .ssh/config file over a period of time, line by line or entry by entry, people will be surprised to see a bunch of fields filled in automatically, and with different results from what they had before. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --D21NRbksaTQGHQVl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmSKEh8ACgkQQarn3Mo9 g1Ff4w//UZ9gZTeQxswem6oCK7bch5wu+14xAqxEZF4FJAEW4Je1GNKzArejtoxF 794Muah3ml58tEoixuV9IiF490VIYAdHqaCtLfCHUgv24DnjIVYk0oGbQ4A9+kBj ukMIVJH0R+5dEq7e/shx/po54vsa2rx/7a51MZ8O91+gFZ8DqNlM8uGiU39iLPtj HfJkxkx8A1z+yTJFyDYEX7AoTqa47ugTNzfQromq63CFR8iqLqU5WDiD3QmXKLyO HgG/CEbTMbrVF/bnS7fP+QF/mDaTwYjQfXabFbEHhMTGOidS2NdWuYo6fHQWIEI+ FJItfPiMlajjOwo4miuK4wOpHcoCQEgpv8hw1rbvtQfzxf/wTu6qbnNHnfMXmqEA /NTnDUYivD+l7iSe4BoDwzOl5WJfN3HWt5ULcFl0iYFfCnAoZS9L7S4rjf8NsDRg On5ncn6BF+EJ/X9xyB8THmHqxNBc5TEhsyotn/VnL3tsk3QM5qUaYbprpfnRdjy3 Fa5I4bB7NTDsxgsJIcFTC0QqbkFWRZEF7R1WRJmyt+drFJpZUZCNWGR1DABNcVaS CpNpLaFxM1j9TwGCkmBvK1dybUluvaF+WfE4O5v5xMWJoinS+BkXNca70uUzVR9j 5d10lhpAvn7DTZumSJXdXVZfp2ht061Sd7IlRbrqZpzM3oNmY/Q= =Rsg/ -----END PGP SIGNATURE----- --D21NRbksaTQGHQVl--