unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#63459] Changes to the branching/commit policy
       [not found] <87y1kuyqew.fsf@cbaines.net>
@ 2023-06-09 10:10 ` Andreas Enge
       [not found]   ` <87mt16xra3.fsf@cbaines.net>
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Enge @ 2023-06-09 10:10 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel, 63459

Hello Chris,

thanks for taking up this issue! I agreed with Ludovic's comments, so
things look good now for me. A very minor point: In the section on
"trivial" changes, I would drop this sentence (which was already there
before):
"This is subject to being adjusted, allowing individuals to commit directly
on non-controversial changes on parts they’re familiar with."
The sentence is meaningless, as everything is all the time subject to being
adjusted; and we do not have immediate plans to adjust it.

Looking forward to the merge since it clarifies things and removes the
staging and core-updates branches not only from our minds, but also the
texts.

Andreas





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [bug#63459] Changes to the branching/commit policy
       [not found]   ` <87mt16xra3.fsf@cbaines.net>
@ 2023-06-12  1:28     ` Maxim Cournoyer
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2023-06-12  1:28 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel, Andreas Enge, 63459

Hi Christopher,

Christopher Baines <mail@cbaines.net> writes:

> Andreas Enge <andreas@enge.fr> writes:
>
>> thanks for taking up this issue! I agreed with Ludovic's comments, so
>> things look good now for me. A very minor point: In the section on
>> "trivial" changes, I would drop this sentence (which was already there
>> before):
>> "This is subject to being adjusted, allowing individuals to commit directly
>> on non-controversial changes on parts they’re familiar with."
>> The sentence is meaningless, as everything is all the time subject to being
>> adjusted; and we do not have immediate plans to adjust it.
>
> My reading of this line is that "adjusted" is probably not the right
> word to use, but I think the intent here is to talk about how currently
> it's accepted that people can and will push non-controversial changes on
> parts they’re familiar with directly to master.
>
> I'm not sure if others read this similarly.

That's how I read it as well.  I like the ability for people to, at
times depending on the situation, choose to push directly to fix or
update something instead of going through the otherwise recommended 1
week QA/review flow.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-12  1:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87y1kuyqew.fsf@cbaines.net>
2023-06-09 10:10 ` [bug#63459] Changes to the branching/commit policy Andreas Enge
     [not found]   ` <87mt16xra3.fsf@cbaines.net>
2023-06-12  1:28     ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).