* [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
@ 2023-06-15 18:05 lists
2023-06-16 20:40 ` Carl Dong
2023-06-19 13:50 ` Michael Ford
0 siblings, 2 replies; 5+ messages in thread
From: lists @ 2023-06-15 18:05 UTC (permalink / raw)
To: 64100; +Cc: efraim, Cory Fields
From: Cory Fields <cory-nospam-@coryfields.com>
Matches gcc-make-toolchain. Allow for llvm build to be patched.
* gnu/packages/llvm.scm: make clang-make-toolchain public
Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
---
gnu/packages/llvm.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index f59c8e9592..6d83313af6 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -502,7 +502,7 @@ code analysis tools.")
"znver3")
'())))))
-(define (make-clang-toolchain clang libomp)
+(define-public (make-clang-toolchain clang libomp)
(package
(name (string-append (package-name clang) "-toolchain"))
(version (package-version clang))
base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
2023-06-15 18:05 [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public lists
@ 2023-06-16 20:40 ` Carl Dong
2023-06-18 6:38 ` Efraim Flashner
2023-06-19 13:50 ` Michael Ford
1 sibling, 1 reply; 5+ messages in thread
From: Carl Dong @ 2023-06-16 20:40 UTC (permalink / raw)
To: lists; +Cc: 64100, efraim, Cory Fields
Simple enough and matches gcc-make-toolchain.
Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).
–Carl
> On Jun 15, 2023, at 2:05 PM, lists@coryfields.com wrote:
>
> From: Cory Fields <cory-nospam-@coryfields.com>
>
> Matches gcc-make-toolchain. Allow for llvm build to be patched.
>
> * gnu/packages/llvm.scm: make clang-make-toolchain public
>
> Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
> ---
> gnu/packages/llvm.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index f59c8e9592..6d83313af6 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -502,7 +502,7 @@ code analysis tools.")
> "znver3")
> '())))))
>
> -(define (make-clang-toolchain clang libomp)
> +(define-public (make-clang-toolchain clang libomp)
> (package
> (name (string-append (package-name clang) "-toolchain"))
> (version (package-version clang))
>
> base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
> --
> 2.25.1
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
2023-06-16 20:40 ` Carl Dong
@ 2023-06-18 6:38 ` Efraim Flashner
2023-07-02 17:16 ` Carl Dong
0 siblings, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2023-06-18 6:38 UTC (permalink / raw)
To: Carl Dong; +Cc: 64100, lists, Cory Fields
[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]
On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
> Simple enough and matches gcc-make-toolchain.
>
> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
>
> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).
Sounds good to me
> > On Jun 15, 2023, at 2:05 PM, lists@coryfields.com wrote:
> >
> > From: Cory Fields <cory-nospam-@coryfields.com>
> >
> > Matches gcc-make-toolchain. Allow for llvm build to be patched.
> >
> > * gnu/packages/llvm.scm: make clang-make-toolchain public
> >
> > Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
> > ---
> > gnu/packages/llvm.scm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> > index f59c8e9592..6d83313af6 100644
> > --- a/gnu/packages/llvm.scm
> > +++ b/gnu/packages/llvm.scm
> > @@ -502,7 +502,7 @@ code analysis tools.")
> > "znver3")
> > '())))))
> >
> > -(define (make-clang-toolchain clang libomp)
> > +(define-public (make-clang-toolchain clang libomp)
> > (package
> > (name (string-append (package-name clang) "-toolchain"))
> > (version (package-version clang))
> >
> > base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
> > --
> > 2.25.1
> >
> >
> >
> >
>
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
2023-06-18 6:38 ` Efraim Flashner
@ 2023-07-02 17:16 ` Carl Dong
0 siblings, 0 replies; 5+ messages in thread
From: Carl Dong @ 2023-07-02 17:16 UTC (permalink / raw)
To: Efraim Flashner; +Cc: Michael Ford, 64100, lists, Cory Fields
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
Pushed to master as 39a3251feb2559e0b448f25671c26b9dd3318108
I’m not sure I can close this ticket as I didn’t open it.
–Carl
> On Jun 18, 2023, at 2:38 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
> On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
>> Simple enough and matches gcc-make-toolchain.
>>
>> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
>>
>> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).
>
> Sounds good to me
>
>>> On Jun 15, 2023, at 2:05 PM, lists@coryfields.com wrote:
>>>
>>> From: Cory Fields <cory-nospam-@coryfields.com>
>>>
>>> Matches gcc-make-toolchain. Allow for llvm build to be patched.
>>>
>>> * gnu/packages/llvm.scm: make clang-make-toolchain public
>>>
>>> Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
>>> ---
>>> gnu/packages/llvm.scm | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
>>> index f59c8e9592..6d83313af6 100644
>>> --- a/gnu/packages/llvm.scm
>>> +++ b/gnu/packages/llvm.scm
>>> @@ -502,7 +502,7 @@ code analysis tools.")
>>> "znver3")
>>> '())))))
>>>
>>> -(define (make-clang-toolchain clang libomp)
>>> +(define-public (make-clang-toolchain clang libomp)
>>> (package
>>> (name (string-append (package-name clang) "-toolchain"))
>>> (version (package-version clang))
>>>
>>> base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
>>> --
>>> 2.25.1
>>>
>>>
>>>
>>>
>>
>
> --
> Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
2023-06-15 18:05 [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public lists
2023-06-16 20:40 ` Carl Dong
@ 2023-06-19 13:50 ` Michael Ford
1 sibling, 0 replies; 5+ messages in thread
From: Michael Ford @ 2023-06-19 13:50 UTC (permalink / raw)
To: 64100
> Matches gcc-make-toolchain. Allow for llvm build to be patched.
> * gnu/packages/llvm.scm: make clang-make-toolchain public
This is great. Thanks for the change.
Definitely useful for downstream Guix users!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-02 17:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 18:05 [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public lists
2023-06-16 20:40 ` Carl Dong
2023-06-18 6:38 ` Efraim Flashner
2023-07-02 17:16 ` Carl Dong
2023-06-19 13:50 ` Michael Ford
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).