From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SOgvIv2DfGQVPgAASxT56A (envelope-from ) for ; Sun, 04 Jun 2023 14:30:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8NHGIf2DfGTJOAEAauVa8A (envelope-from ) for ; Sun, 04 Jun 2023 14:30:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 461D59FA5 for ; Sun, 4 Jun 2023 14:30:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5msG-0003gB-Vg; Sun, 04 Jun 2023 08:30:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5ms0-0003au-TK for guix-patches@gnu.org; Sun, 04 Jun 2023 08:30:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5ms0-0000oA-JJ for guix-patches@gnu.org; Sun, 04 Jun 2023 08:30:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5ms0-0007yN-DF for guix-patches@gnu.org; Sun, 04 Jun 2023 08:30:04 -0400 Subject: bug#62432: [PATCH] gnu: libicns: fix riscv64 cross-build. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 04 Jun 2023 12:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62432 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 62432-done@debbugs.gnu.org, Z572 <873216071@qq.com> Received: via spool by 62432-done@debbugs.gnu.org id=D62432.168588180030563 (code D ref 62432); Sun, 04 Jun 2023 12:30:04 +0000 Received: (at 62432-done) by debbugs.gnu.org; 4 Jun 2023 12:30:00 +0000 Received: from localhost ([127.0.0.1]:45272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mrv-0007ws-Lf for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:30:00 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:49221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mrr-0007w8-TG for 62432-done@debbugs.gnu.org; Sun, 04 Jun 2023 08:29:56 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51640b9ed95so3357416a12.2 for <62432-done@debbugs.gnu.org>; Sun, 04 Jun 2023 05:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685881790; x=1688473790; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=yUt0Kw/D1ysf5W/HxT9fY2mcaNfrWbBriiGjCgOavlw=; b=W3bPB9xG2HJQxY18u4xhCpjuzaElRrM3FKRzmC8cGFa+AIUSSYFB3kfqe+kJFmj5c8 02nAREuFFVS3sqpns/rbEDqNP0nJRcyBfoYFTVUszUNruGYY7ZtFuVjSKdS1XbNN9U/m biqKvyMVlmZ6an6TKzNCf1pUJ1uejtLaSUGoac/APdOsMxQVqDIpsCVUFW4THNFd9/sD 2bj5dpj91/f1q5C/J/C+WPll7sU/uIW1SqV1T3ZvmCAnUr+EcvHYCVZvhG8SA8OUQ98M AFeBZF/FWNb2R3KW1Ut12brixs7/NBQ461AQMzYAhsoWH2NvrYpQ5WRbAODBCI1J4jBy 4FSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685881790; x=1688473790; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUt0Kw/D1ysf5W/HxT9fY2mcaNfrWbBriiGjCgOavlw=; b=eXuZzzZlgobUallbedA17C3xAy2Pex+hcQsiXzrLeBIjhnM2LU9hZePpRN3XBQe6nm BHKHH59tVfZVJm6O5WOQ/FSW7piKb3B+guHuZ3nRfi/EpnIRxrIGXAwCpm8qgBwNidfX AfqGFpjihcs06aH/jA2pH5OjZqI1aNyBx5UhimdRIa7jM8l1u246/YjNXvfDPKWDL+ro mPz1Ss5Q8/eCUzsy4EkBqO4wb+RyIuOza1BISxJXXdhwAIH8fFqkVNP+puR0fL9g2B/e jBk2hXbhwl593z9oj6a7IotP3KM+11VDRJO+y2hc5bGPPMzKrhAAd8SvxRg8C7nIHWPg C5bg== X-Gm-Message-State: AC+VfDwYhwoIoSARSNfWWwTCOF/jEbXRwV+iT+dlhhx0FkPR8P5dE62u waup+5SzsxBLUg4WX38Wmj0= X-Google-Smtp-Source: ACHHUZ5HGwFYEkUqTU1daGHpHgAU2jy1yRAOSlGR4eGwhuf8Ps+CUMDTcr1spq/7gcjOY07UwJRHnw== X-Received: by 2002:a50:ec86:0:b0:510:e902:9690 with SMTP id e6-20020a50ec86000000b00510e9029690mr5996640edr.33.1685881790050; Sun, 04 Jun 2023 05:29:50 -0700 (PDT) Received: from localhost ([2a02:ed3:913:500:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id n23-20020aa7c797000000b005027d31615dsm2701442eds.62.2023.06.04.05.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 05:29:49 -0700 (PDT) Date: Sun, 4 Jun 2023 15:29:45 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , Z572 <873216071@qq.com>, 62432-done@debbugs.gnu.org References: <878rf9b51p.fsf@envs.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cXpHoKx6RaB9hbmA" Content-Disposition: inline In-Reply-To: <878rf9b51p.fsf@envs.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685881853; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yUt0Kw/D1ysf5W/HxT9fY2mcaNfrWbBriiGjCgOavlw=; b=Sk9uZiAhx9/jkrIzKZ2TvxoS3LTKWUG0iovskPZXHy8IjkwaoQXbv78SkrMvwhdbir79cL gh+UeMt2fOA0Igw7StrY9J735bPA3oVCaJcTRDZ9IYG99n2Umn5+sixGyxqFiRPnRZk5+4 TSa0hgGfPKs72EAGBgMdpl0VbdbiDpP6WPfZ2Wtt6Hk/gfH5GP70A2YyI98LPmgyUYLxIK vQ+GGMEWGhZLptPaIjnFVvYVqtEP28fTt8dQak75dDOpzW2W/9yZMd3AhkaphG2GDGxYvz ldq1NlnEk0zLH1xnDNc+8XlEdP/ymtSxjgvxwfwOVfzhf9Z0PM67rhVhB+4Dbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=W3bPB9xG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685881853; a=rsa-sha256; cv=none; b=i/I5q6R1B51CAyv5gLI5K0KE96frSOKhFY3BZWA5xia2s1MptspGGpHk4piiOk1Fv8uVCr NuGMzZlp3EoQ78xogqD54om/amwmgwXnwSCYz5YQ84IROfwAGbPnE1FHT1A+OlieUrb4Uq 3llBBsy1n6saGNgGBpT6y/eX/HUFzetTNui/7K4foQk2OY3rt0QocVyIn3n+9rWiBajjWj IzAVFHGzHgHd1IwAtmFvUmJB5n96FaF8Rpq1dtoWJU4IGqKUiSUSdVsUaURX29Whqgnyu7 Ikr2VsLpanILJPJQvi1Psby5NHZ1m9RMJJSK4I5YnrOMNqWGNiVOlRfMJ/TBDw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=W3bPB9xG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 461D59FA5 X-Spam-Score: -2.28 X-TUID: UEJNpVG5j76U --cXpHoKx6RaB9hbmA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 07:04:18PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 via G= uix-patches via wrote: > Z572 <873216071@qq.com> writes: >=20 > > * gnu/packages/image.scm (libicns): fix riscv64 cross-build. >=20 > Hello, this message is already in the commit message title, So I think > there is no need to repeat it here. Also look in the guix commit log, > I think it should be 'gnu: libicns: Fix cross-compilation for riscv64'. >=20 >=20 > > + (arguments (if (target-riscv64?) > > + (list #:phases > > + #~(modify-phases %standard-phases > > + (add-after 'unpack 'update-config-scripts > > + (lambda* (#:key native-inputs inputs #:= allow-other-keys) > > + (for-each (lambda (file) > > + (install-file > > + (search-input-file > > + (or native-inputs input= s) > > + (string-append "/bin/" = file)) ".")) > > + '("config.guess" "config.su= b"))))) ) > > + '())) > > + (native-inputs > > + (if (target-riscv64?) > > + (list config) > > + '())) >=20 > This updates 'config.guess' and 'config.sub' in a package to fix > cross-compilation for riscv64 seems like a common practice (eg: also in > your patches #62433, #62544). How about make a procedure for it to > save some typing? It could be: >=20 > ``` > (define (autotools-config-updated-package p) > "Return package P with @command{config.guess} and > @command{config.sub} updated by the @code{config} package" > (package (inherit p) > ...)) > ``` >=20 > Which could go into (guix transformations). I would certainly like something like this. I suppose it could be made more general by using find-file to find all occurrences of config.guess and config.sub and replacing those. In the meantime I've pushed this patch after replacing (target-riscv64?) with (and (target-riscv64?) (%current-target-system)). --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --cXpHoKx6RaB9hbmA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmR8g7kACgkQQarn3Mo9 g1EHFA/5AafiSh/UgsoHu8CRGn17nBMnh2WPK32YrfOKWo/Rh7pAxoggJda9Udyp 8lBQMu1IZXleA2M6iCmhF3oHhDO0zuNFRVJb7OZ5iuAxFxgKdvfwwhzBHlKMWhZK nhE1raKq2fZCaOeKff68aXrNlkuQ83JD5WGGoJdb9c7BqxBqX0JXToipw8fj93Qo IJho4tPIZDbAPifzOpMdFEabYzvkB+ZXDESjeQirdbf+Nrj+W+vK0SViJlPdVApG +M4CO+Arn3qhCAVy9Mzn1SPVDzEjVblkU+L8opKeH74QJmSFxK+NOSRvqzcvNsRc 7aKYu2tDYQnLJQOMk1e/g6/xfS5+LRhRge+4FERRBULfvVJiwEK2u+LorxxO5lXv NjbEaCmt29kLDsYvQeg7AXb9LWSMXlVzzditZVC3LMwmZ31AJl8XxMK8xluFixZB X4vzfjMMVruEf8E2B72X/+MFBbm0M0DoD05V3526QgOgvUE69VuRwK35Vc8LvPXw FNqcR4IJRcqPjKw33fghzoxc0zPJPv8uTA3pz+3P2I9fe6NxdaiqvY+MthB+0trM FAM6ojtomJDPCn/acu51GWq6vO/cOAJmmQ3+nU9d2zBwfm/g4QM84Ko4jkWF2VUt x46RXpcQhd25EHqcAPCy0yjfWkZAaD5dGm10jBPZxovwWe9PrLM= =QC2j -----END PGP SIGNATURE----- --cXpHoKx6RaB9hbmA--