unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Z572 <873216071@qq.com>
Cc: 61865@debbugs.gnu.org
Subject: [bug#61865] [PATCH 7/8] gnu: libotf: fix cross-compile.
Date: Sun, 4 Jun 2023 15:19:59 +0300	[thread overview]
Message-ID: <ZHyBb1785lU7gy0G@3900XT> (raw)
In-Reply-To: <tencent_7AFC01EB8C947B94A8D4526FDAA4B665DD0A@qq.com>

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

This one I didn't apply. I don't believe adding freetype as a
native-input is correct but I could see adding it as an input. In the
end libotf links to freetype, and we don't want it to link to the one in
native-inputs.

I don't think the phase is the correct way to do this. I didn't see any
error related to it when I was building it before applying the patch,
and I made it pretty far after overriding the location of
freetype-config.

On Tue, Feb 28, 2023 at 04:33:39PM +0800, Z572 via Guix-patches via wrote:
> * gnu/packages/fontutils.scm(libotf): fix cross-compile.
> [native-inputs]:
> add freetype, when cross-compile, add libtool, autoconf automake.
> [arguments]: when cross-compile, add phase to fix rpl_malloc undefined reference
> ---
>  gnu/packages/fontutils.scm | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 72621cc006..d451f5e504 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -1392,7 +1392,22 @@ (define-public libotf
>                 (base32 "0sq6g3xaxw388akws6qrllp3kp2sxgk2dv4j79k6mm52rnihrnv8"))))
>      (build-system gnu-build-system)
>      (native-inputs
> -     (list pkg-config))
> +     (append (if (%current-target-system)
> +                 (list libtool
> +                       autoconf automake)
> +                 '())
> +             (list pkg-config freetype)))
> +    (arguments (if (%current-target-system)
> +                   (list
> +                    #:phases
> +                    #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'fix-rpl_malloc
> +                          (lambda _
> +                            (substitute* "configure.ac"
> +                              (("AC_FUNC_MALLOC")
> +                               ""))
> +                            (invoke "sh" "autogen.sh")))))
> +                   '()))
>      (propagated-inputs
>       (list freetype))
>      (home-page "https://www.nongnu.org/m17n/")
> -- 
> 2.39.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-06-04 12:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1677572540.git.873216071@qq.com>
2023-02-28  8:33 ` [bug#61865] [PATCH 1/8] gnu: xcb-util-wm: fix riscv64 cross-compile Z572 via Guix-patches via
2023-02-28  8:33 ` [bug#61865] [PATCH 2/8] gnu: libxv: " Z572 via Guix-patches via
2023-06-04 12:19   ` Efraim Flashner
2023-02-28  8:33 ` [bug#61865] [PATCH 3/8] gnu: libxtst: " Z572 via Guix-patches via
2023-02-28  8:33 ` [bug#61865] [PATCH 4/8] gnu: mtdev: " Z572 via Guix-patches via
2023-02-28  8:33 ` [bug#61865] [PATCH 5/8] gnu: gobject-introspection: " Z572 via Guix-patches via
2023-02-28  8:33 ` [bug#61865] [PATCH 6/8] gnu: gsettings-desktop-schemas: fix cross-compile Z572 via Guix-patches via
2023-02-28  8:33 ` [bug#61865] [PATCH 7/8] gnu: libotf: " Z572 via Guix-patches via
2023-06-04 12:19   ` Efraim Flashner [this message]
2023-02-28  8:33 ` [bug#61865] [PATCH 8/8] gnu: librsvg-2.40: " Z572 via Guix-patches via
2023-06-04 12:20   ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHyBb1785lU7gy0G@3900XT \
    --to=efraim@flashner.co.il \
    --cc=61865@debbugs.gnu.org \
    --cc=873216071@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).