From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AKHiAzaCYmSvbQAASxT56A (envelope-from ) for ; Mon, 15 May 2023 21:04:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oBXtAjaCYmSpKAAAG6o9tA (envelope-from ) for ; Mon, 15 May 2023 21:04:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBB422A308 for ; Mon, 15 May 2023 21:04:21 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pydUQ-0000up-DL; Mon, 15 May 2023 15:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pydUJ-0000sg-Na for guix-patches@gnu.org; Mon, 15 May 2023 15:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pydUI-0001dA-J7 for guix-patches@gnu.org; Mon, 15 May 2023 15:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pydUI-0003Kn-0e for guix-patches@gnu.org; Mon, 15 May 2023 15:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63400] [PATCH 0/1] gnu: vulkan-loader: Skip x86-specific tests on non-x86 platforms. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 May 2023 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63400 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: 63400@debbugs.gnu.org Received: via spool by 63400-submit@debbugs.gnu.org id=B63400.168417739012759 (code B ref 63400); Mon, 15 May 2023 19:04:01 +0000 Received: (at 63400) by debbugs.gnu.org; 15 May 2023 19:03:10 +0000 Received: from localhost ([127.0.0.1]:44421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pydTR-0003Jh-NM for submit@debbugs.gnu.org; Mon, 15 May 2023 15:03:10 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:47119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pydTN-0003JC-Fe for 63400@debbugs.gnu.org; Mon, 15 May 2023 15:03:08 -0400 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-3f42c865534so72966235e9.2 for <63400@debbugs.gnu.org>; Mon, 15 May 2023 12:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684177379; x=1686769379; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=y6fjIguskKHskkxYcYYQLojV/yRNbqjlL97MSMI8SUA=; b=mEV+l/9EFvJvRgbYAi93wvhCXFIkur7Z0VHDc5tgEF7oJ+OLiSdY/fhOfT/IkLsM+A ZBN+b+x7Ed05dmUv1UYwMBdCp8Sx5OzNRCDSWfmE76wrGXBoLs+H7FrMSvCOpMD43r54 p5MUcTN5yeGWQIFwju7E41Qm+zlc6MFlQO6b+Wv0e4OSEnGjXRvAI8l6wKRkIlJBeJyJ gyE73NF9RT5MbKSTVo9eUMOmTBTcL4GSS53gfkuW+m7JvPDmTQPaSRyPvqqaF5hMFJoE sKuTKqw0lJS221UCIAGtEEX8T1Kl+GMdz/qUc/klAranLSPL32tXERqm5Qu50WnwXzho EvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684177379; x=1686769379; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y6fjIguskKHskkxYcYYQLojV/yRNbqjlL97MSMI8SUA=; b=h7PCNqn1TB/o7SEcdAShSKVL1Ip15CSCft2f+MmgURCtxGatpisbD0+c0oGAMj/+yn WVz62f0s3tkCGe3T9DVwS8Z9piAaWu7TlCAKhCg0/OtEgNtjnRucnoIuSg10wAJ4XIvH uQivegA5dOcJVDSaKyK/t2MSMiqPO4xX7jboAgclSarz6N7JuOHejPvhUse0I3ftHpjB sF69fGwN4QOc7qn0e9Y1hsSkmMYYDCYNkDfionR2QqxiCWfChq8CeKHAzfQYoLEBsdoy cYHRm1pjq4D2dWKxwrueI86d8yggKYS5T7tcrlP0Ntz6FRxEQr7Ewqc15kjAIqJDyb21 SZzg== X-Gm-Message-State: AC+VfDw0YmLhRyBquEXSQp7qFQm1r6yAoExAdlKZbvT03rrZeeqLqsLq Bqu99wAurHrtQsHr9EPn29A= X-Google-Smtp-Source: ACHHUZ7iGt0lEgL3B7XQhtz+nVslSFFGAtqi2cY4DgczDASR0G3Ty8txGRBGdVTw+TqflV7uCI2Mbw== X-Received: by 2002:a05:600c:2052:b0:3f5:39:240b with SMTP id p18-20020a05600c205200b003f50039240bmr6464337wmg.24.1684177379326; Mon, 15 May 2023 12:02:59 -0700 (PDT) Received: from localhost ([2a02:ed3:910:2a00:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id f20-20020a7bcd14000000b003f080b2f9f4sm267362wmj.27.2023.05.15.12.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:02:58 -0700 (PDT) Date: Mon, 15 May 2023 22:02:56 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Simon South , 63400@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VKcIUjxEUth06IHn" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684177461; a=rsa-sha256; cv=none; b=njzG1qmnPx39HotAis/0nZiF0fqXlW9+THGBSprZi7V2tc5TlG5mNC4jeHRfbkPU+aUI6I M+xiR6GvkC/hvw3Y431izV975i1X+f49u9eEsG/FkzC6m9nNFBJk5OksGQZsMp9pX5qoGh DMr+3hfb1bHsuEV8cRNfaO0OIOvX7KiPQ4DxWOftjiqGFQmZypEExLCIiKaj3lhgrIgRI2 hjQazTaNDaoYLzCLxbqFR7HFfi+TwwkR15f/gccrpSyY9/ua2bbTPZsptVTgiPMUcimXAX 6HR0hScylFkeiM6OwR2UEzt6E9IZFu/g5pptwDIv3x9DsycCcUma5AOnTk1aNg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="mEV+l/9E"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684177461; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=y6fjIguskKHskkxYcYYQLojV/yRNbqjlL97MSMI8SUA=; b=tIq6i31Ap7Rtv+Tzo1u6UT2JDR7aicG3DBl5V/IK19+EbZZDyFez6gSExnzmi9A/V8guHf eAMQN4k1h31nRYt25zZ30rt4nhP5mrqRuqfy7wzH2qx7K0aAp1ZDqIfSeQYDN9DirvNKuR OEwP4rRzIyYfQEb45E7YX/gDBPtAzapezirSRdgzX1tEt6bsVU/KEDbrEoIASz/lrp0kZ3 Bcf1F/yqe7Tgh8/cwqV4XriC2GyxH9yXHwHF+ePzJKNbCuCyXJnr07S6Eq+Y685ySWM6Mo 0wTiOaesoNXfY9IrnCdg0W4tA6Ef2MKR3Q5jYeCJSpuGA422I6W9DHzD5CHamg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="mEV+l/9E"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.71 X-Spam-Score: 0.71 X-Migadu-Queue-Id: BBB422A308 X-TUID: 38lCNDjiCfm5 --VKcIUjxEUth06IHn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 09, 2023 at 04:43:27PM -0400, Simon South wrote: > This patch fixes the build of vulkan-loader on aarch64-linux by > causing five tests that require an x86 or x86-64 host to be skipped. I have to admit that I didn't check the bug tracker before I pushed my change (which mirrored Chris's earlier patch) to just skip the tests entirely on a bunch of architectures. > I've tested this change on x86-64 (to confirm the patch has no real > effect) and AArch64 and everything seems fine. >=20 > The tests that are skipped use pre-built, dummy libraries supplied in > the source package to check the loader's ability to detect a request > for a 32-bit library on a 64-bit system, and vice-versa. This is done > by checking for a specific error message generated by a call to > dlopen(). The dummy libraries provided are built only for x86 and > x86-64, though, so on other platforms dlopen() produces a different > error ("No such file" instead of "wrong ELF class") and the tests > fail. Another option would be to patch the tests to look for these strings instead when we're building on those architectures. > The source package supplies a makefile that could be used to > regenerate these dummy libraries, but as written the makefile assumes > that >=20 > - gcc recognizes "-m32" and "-m64" options to select a target > subarchitecture, which is true on x86 and PowerPC but not on > AArch64 or RISC-V, for instance; and that >=20 > - The system's linker is able to output libraries for multiple > architectures, requiring (among other things) that multiple > versions of glibc be available, and even using "cross-gcc" and > "cross-libc" I haven't found a straightforward way to achieve this > within a single package build. This also seems to be above-and-beyond for 5 tests out of ~400. > So I expect modifying things to make these tests work on other > platforms would be more trouble than it's worth. Having looked at these myself I agree that it's non-trivial to skip the failing tests on the other architectures. Debian, for instance, runs the tests, but if they fail ignores the outcome, and prints to the build log that 23 tests are expected to fail. > --- >=20 > Simon South (1): > gnu: vulkan-loader: Skip x86-specific tests on non-x86 platforms. >=20 > gnu/local.mk | 1 + > ...ulkan-loader-skip-incompatible-tests.patch | 62 +++++++++++++++++++ > gnu/packages/vulkan.scm | 2 + > 3 files changed, 65 insertions(+) > create mode 100644 gnu/packages/patches/vulkan-loader-skip-incompatible-= tests.patch >=20 >=20 > base-commit: c1ffe2f21bd1b9ba6bd527bbabe130144a69af71 > --=20 > 2.39.2 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --VKcIUjxEUth06IHn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmRigd0ACgkQQarn3Mo9 g1Gg2Q/46Adm3kEpzat8BHmC+yycNNKo6QRYxhQR/W5aosLqwJqHYPgCg+JOWPuX LEDJ+fAY7/oq95G4YhM7fiNJuw2pFLJnxXKzXA03fWflFqf0Ewe3C+lCCJWFzVl8 7ABz1A2QQ3itcpYKahmit3tTYRz0qkQqASuTF4izWOkrGiPfD86n5znO4KF2oBA6 uZ6R5T+B7eESbCDuBBzd5r+NnrlPyfRzPLRfBLEPz88QRVq2zmZCAICtwZTkiZEf DykW/fPlXmV8uTXidqGnqSiHDaMErY61DDUO3GMK8cS4owF9iidxP/hlOMfyBcmb N4GGl14cWzN/i80ygnoKuqhouVUni9iqce3yh/Dq7bUKEAUPB6Z/VT3ViRWRT13e RHgIRQieZVHwzZoz1h45leIOFcoAcDN5ZScbREmEY5kSTbN/tiu2CKj7InfJCZdX YACbg8gFoM/IL82QfI85W+owNwpqhtw6jlpwztPmhcnIQV/mduSipRQMm+fMf0qr /90RbkERMqFMVda6p5fcpjFBK4DYlOCtlZkvhXPbaFElOzpLJNtpmRJD69NgaGZI ooY/nZbssscVIBYSd6clVYzKD0GYRWgoIkigDOiIjScTKlxh/TTB6Tlm98IjH1eJ bs+Qg1OToCm8Skhq/lMmCnArvERoYaU3urdRbqEZsLaqd/ftgw== =cH7o -----END PGP SIGNATURE----- --VKcIUjxEUth06IHn--