From: Andreas Enge <andreas@enge.fr>
To: 60732-done@debbugs.gnu.org
Cc: Gabriel Wicki <gabriel@erlikon.ch>
Subject: bug#60732: Close patch
Date: Sat, 11 Mar 2023 23:24:13 +0100 [thread overview]
Message-ID: <ZAz/jcCcQ6q3Ydbc@jurong> (raw)
In-Reply-To: <20230111163659.wudbizhylifjt3nj@blackbox>
Hello Gabriel,
apologies for not coming back to you. I was a bit torn about the
dependencies, since we tend to package software as "completely" as
possible. Here however the optional dependencies are quite heavy,
and python-pycrypto is outdated and unmaintained and should not be
used anymore. So in the end I opted to leave them out, if someone feels
the need, we can add them to the package, or indeed as you said they
can install them into their profile themselves.
As for the tests, my impression is that they are actually not activated.
So I added a comment.
The patch is pushed now, thanks again for your patience!
Andreas
prev parent reply other threads:[~2023-03-11 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 16:36 [bug#60732] New package: python-scapy Gabriel Wicki
2023-02-20 21:21 ` [bug#60732] Review Andreas Enge
2023-02-21 17:44 ` [bug#60732] Patch update Wicki Gabriel (wicg)
2023-02-28 13:50 ` Wicki Gabriel (wicg)
2023-03-11 22:24 ` Andreas Enge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAz/jcCcQ6q3Ydbc@jurong \
--to=andreas@enge.fr \
--cc=60732-done@debbugs.gnu.org \
--cc=gabriel@erlikon.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).