unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#61431] [PATCH] gnu: pwntools: Update to 4.9.0.
       [not found] <87o7q0gxn3.fsf@foxmail.com>
@ 2023-02-11 13:05 ` c4droid
       [not found] ` <handler.61431.B.167612170722600.ack@debbugs.gnu.org>
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: c4droid @ 2023-02-11 13:05 UTC (permalink / raw)
  To: 61431

From 7774159762ddc93d93184a91e601d7abe82380a4 Mon Sep 17 00:00:00 2001
From: c4droid <c4droid@foxmail.com>
Date: Sat, 11 Feb 2023 20:46:56 +0800
Subject: [PATCH] gnu: pwntools: Update to 4.9.0.

---
 gnu/packages/cybersecurity.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/cybersecurity.scm b/gnu/packages/cybersecurity.scm
index 7bca251d06..7e322c2756 100644
--- a/gnu/packages/cybersecurity.scm
+++ b/gnu/packages/cybersecurity.scm
@@ -123,14 +123,14 @@ (define-public ropgadget
 (define-public pwntools
   (package
     (name "pwntools")
-    (version "4.4.0")
+    (version "4.9.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "pwntools" version))
        (sha256
         (base32
-         "1qw7j0wwm1878aia08gyw5xljjr26qsbp45w65n4qff672sha5n5"))))
+         "04p7qzx4axkh0wgm0185724midzb3lprp3crja1lhw4i5wc7v9pf"))))
     (build-system python-build-system)
     (arguments
      '(#:tests? #f))                 ;XXX: needs a specific version of unicorn
-- 
2.39.1




^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#61431] Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.)
       [not found]   ` <878rh4fgre.fsf@foxmail.com>
@ 2023-02-11 13:55     ` c4droid
  2023-02-13 17:37     ` Christopher Baines
  1 sibling, 0 replies; 9+ messages in thread
From: c4droid @ 2023-02-11 13:55 UTC (permalink / raw)
  To: 61431

I tried build package locally, same with version 4.4.0, python part
build normally, only building unicorn generate error.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.)
       [not found]   ` <878rh4fgre.fsf@foxmail.com>
  2023-02-11 13:55     ` [bug#61431] Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.) c4droid
@ 2023-02-13 17:37     ` Christopher Baines
  1 sibling, 0 replies; 9+ messages in thread
From: Christopher Baines @ 2023-02-13 17:37 UTC (permalink / raw)
  To: c4droid; +Cc: 61431

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]


c4droid <c4droid@foxmail.com> writes:

> I tried build package locally, same with version 4.4.0, python part
> build normally, only building unicorn generate error.

It looks to me like unicorn fails to build, so I think that needs fixing
before we can consider updating pwntools.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] unicorn
       [not found] <87o7q0gxn3.fsf@foxmail.com>
  2023-02-11 13:05 ` [bug#61431] [PATCH] gnu: pwntools: Update to 4.9.0 c4droid
       [not found] ` <handler.61431.B.167612170722600.ack@debbugs.gnu.org>
@ 2023-03-11 23:15 ` Andreas Enge
  2023-03-13 12:05   ` c4droid
  2023-05-09  4:20 ` [bug#61431] unicorn failed test fixed c4droid
  2023-07-24 16:00 ` [bug#61431] More info needed Andreas Enge
  4 siblings, 1 reply; 9+ messages in thread
From: Andreas Enge @ 2023-03-11 23:15 UTC (permalink / raw)
  To: 61431

Notice that there are newer releases of unicorn. I tried 1.0.2 (without
the -rc4) and 1.0.3, but both have the same test failure.

The current version is 2.0.1, but it does not build with the recipe
as it is.

Andreas





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] unicorn
  2023-03-11 23:15 ` [bug#61431] unicorn Andreas Enge
@ 2023-03-13 12:05   ` c4droid
  2023-03-14 19:32     ` Andreas Enge
  0 siblings, 1 reply; 9+ messages in thread
From: c4droid @ 2023-03-13 12:05 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 61431

I think if can remove some failed tests, let unicorn can build success.

On Sun, Mar 12, 2023 at 12:15:07AM +0100, Andreas Enge wrote:
> Notice that there are newer releases of unicorn. I tried 1.0.2 (without
> the -rc4) and 1.0.3, but both have the same test failure.
> 
> The current version is 2.0.1, but it does not build with the recipe
> as it is.
> 
> Andreas
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] unicorn
  2023-03-13 12:05   ` c4droid
@ 2023-03-14 19:32     ` Andreas Enge
  2023-03-15  0:49       ` c4droid
  0 siblings, 1 reply; 9+ messages in thread
From: Andreas Enge @ 2023-03-14 19:32 UTC (permalink / raw)
  To: c4droid; +Cc: 61431

Am Mon, Mar 13, 2023 at 08:05:22PM +0800 schrieb c4droid:
> I think if can remove some failed tests, let unicorn can build success.

Well, that is always a possibility of last resort, but hiding problems
does not make them go away... We try to limit this to cases where it is
justified (tests that need network access and will not work in the Guix
build environment, for instance).

Andreas





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] unicorn
  2023-03-14 19:32     ` Andreas Enge
@ 2023-03-15  0:49       ` c4droid
  0 siblings, 0 replies; 9+ messages in thread
From: c4droid @ 2023-03-15  0:49 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 61431

Agree, not other way to resolve this.
On Tue, Mar 14, 2023 at 08:32:58PM +0100, Andreas Enge wrote:
> Am Mon, Mar 13, 2023 at 08:05:22PM +0800 schrieb c4droid:
> > I think if can remove some failed tests, let unicorn can build success.
> 
> Well, that is always a possibility of last resort, but hiding problems
> does not make them go away... We try to limit this to cases where it is
> justified (tests that need network access and will not work in the Guix
> build environment, for instance).
> 
> Andreas
> 




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] unicorn failed test fixed
       [not found] <87o7q0gxn3.fsf@foxmail.com>
                   ` (2 preceding siblings ...)
  2023-03-11 23:15 ` [bug#61431] unicorn Andreas Enge
@ 2023-05-09  4:20 ` c4droid
  2023-07-24 16:00 ` [bug#61431] More info needed Andreas Enge
  4 siblings, 0 replies; 9+ messages in thread
From: c4droid @ 2023-05-09  4:20 UTC (permalink / raw)
  To: 61431

Hi!

I discovered latest unicorn version is fix failed tests, here is snippet for unicorn:

``` scheme
(define-public python-unicorn
  (package
    (name "python-unicorn")
    (version "2.0.1.post1")
    (source (origin
              (method url-fetch)
              (uri (pypi-uri "unicorn" version))
              (sha256
               (base32
                "0mlfs8qfi0clyncfkbxp6in0cpl747510i6bqymwid43xcirbikz"))))
    (build-system pyproject-build-system)
    (native-inputs (list cmake pkg-config))
    (home-page "http://www.unicorn-engine.org")
    (synopsis "Unicorn CPU emulator engine")
    (description "Unicorn CPU emulator engine")
    (license #f)))
```

This snippet is generated from guix import pypi, I build it on my local machine, all test is
passed.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#61431] More info needed
       [not found] <87o7q0gxn3.fsf@foxmail.com>
                   ` (3 preceding siblings ...)
  2023-05-09  4:20 ` [bug#61431] unicorn failed test fixed c4droid
@ 2023-07-24 16:00 ` Andreas Enge
  4 siblings, 0 replies; 9+ messages in thread
From: Andreas Enge @ 2023-07-24 16:00 UTC (permalink / raw)
  To: 61431; +Cc: Jakub Kądziołka

Hello,

cc to the last person who has worked on the unicorn package, in case they
can help.

The current unicorn package has a lot more code, which may or may not be
needed after updating to a new major version; but it would be nice if
someone familiar with the package and actually using it could do the update
and check that it still works.

Andreas





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-07-24 16:02 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87o7q0gxn3.fsf@foxmail.com>
2023-02-11 13:05 ` [bug#61431] [PATCH] gnu: pwntools: Update to 4.9.0 c4droid
     [not found] ` <handler.61431.B.167612170722600.ack@debbugs.gnu.org>
     [not found]   ` <878rh4fgre.fsf@foxmail.com>
2023-02-11 13:55     ` [bug#61431] Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.) c4droid
2023-02-13 17:37     ` Christopher Baines
2023-03-11 23:15 ` [bug#61431] unicorn Andreas Enge
2023-03-13 12:05   ` c4droid
2023-03-14 19:32     ` Andreas Enge
2023-03-15  0:49       ` c4droid
2023-05-09  4:20 ` [bug#61431] unicorn failed test fixed c4droid
2023-07-24 16:00 ` [bug#61431] More info needed Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).