From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eHjoDZ3zY2cyXwEA62LTzQ:P1 (envelope-from ) for ; Thu, 19 Dec 2024 10:21:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eHjoDZ3zY2cyXwEA62LTzQ (envelope-from ) for ; Thu, 19 Dec 2024 11:21:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qBhhofsQ; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=W+wN9V0k; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734603677; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8n0pLq+br/NVCAzMVmEucmfI7gvP5wwa8EpJhY43gIA=; b=VizTjQPro/y5s8K3JrYsao7wUuiilMgT6S+jQwJCikAfzK3g5NMlpfeklQXJZN1WETedFj 8Ja8WuPJeNEolJxTL0kjQHwlGfd/h8aV1/M/bUXseP15nX29zSXKv3t8bgj+EckwKBk/CR 4eASzrLSqP66l5tt43oLzPqPiHWW2E4PgDPq9jxepYH2pLqRzzarAXJxC54ASZds7kd2Ta 6ZMEc0WbFfl9mo+u87xJwDsFcosOMNEPFCRo7KyWmgiPy4p9I3Rt/Jb/4vrLqU/o5EkFIC Wp62rnx2IksQcHt/tgOxii5PH56r8tj+HNfDr9fD9A3tpanqptZNm2FTZL8R5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734603677; a=rsa-sha256; cv=none; b=eZ6nthbceXJeNzv09i+IoH6ZzHrnaLtTWNJ/8xXg6Ygk/Ol0jGrWjoMEw2gmdGyJ0DoKse pnwjofngiIX6gGVelReqHV2TxSxEK9vPemURns3GsBzsDiMBXI1iqRIrCq4lT4MleleYLe BXU8uIFA/bpbSqpaX4k35FzIE/C5WP8CmNOVm7Bd6r2C3Lx7GzwrWVfKfsdwNazYnyitXL uWAkipnrO/lIys1HY/jnWioWPxFNxU56mLNNmBwqxGm5MPNKJv3LAPNuxxnyj1JV/sJ6zk 3L1l+4vMTTNNcfH3YWKvxW22vEo3EMoeglgs5qIfn4ybplfJJDRqq3Mze1sE6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qBhhofsQ; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=W+wN9V0k; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D44971857F for ; Thu, 19 Dec 2024 11:21:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOBcg-0001Sh-Ka; Thu, 19 Dec 2024 03:11:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOBcd-0001SI-5m for guix-patches@gnu.org; Thu, 19 Dec 2024 03:11:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOBcc-0008MH-Pm for guix-patches@gnu.org; Thu, 19 Dec 2024 03:11:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=8n0pLq+br/NVCAzMVmEucmfI7gvP5wwa8EpJhY43gIA=; b=qBhhofsQprOHnY+0SdThxNZ0fqerg+K0MyStN3m6fk/g06l6mQl1pbTo01cx5ygMckoXav2g4G2+0Gm3bpPkWfh1wxQMOYjEm0rre3t7HcEyRwLD7DD9Rixoq/5TfYeSJhOAXpoeog+2R+/y0ijTGmxx1MJDWjpl+7Mj4XLAlhgTkclYWMyBCQZg7EpKxjFhjDH6KaHvJcVYJ0bF+wYPNbaDGUPZkEbEpfmXR/0N0Wgh9DZGyFCQ3up41IpnqaSaYIyWieNfoWtkL4E+6l++YiWDzRQy3UFBVVXjkx/xroOrnvjZ1uG5iOb1hCq1DMnCNXX/YZRAZGvKcr85LeAZPQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOBcc-00012K-DE for guix-patches@gnu.org; Thu, 19 Dec 2024 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74958] [PATCH rust-team 1/5] build/cargo.scm: Remove '--release' from default cargo-test-flags. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Dec 2024 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74958 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 74958@debbugs.gnu.org Received: via spool by 74958-submit@debbugs.gnu.org id=B74958.17345958173829 (code B ref 74958); Thu, 19 Dec 2024 08:11:02 +0000 Received: (at 74958) by debbugs.gnu.org; 19 Dec 2024 08:10:17 +0000 Received: from localhost ([127.0.0.1]:37329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBbs-0000zT-Q6 for submit@debbugs.gnu.org; Thu, 19 Dec 2024 03:10:17 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:59832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBbq-0000v0-Qs for 74958@debbugs.gnu.org; Thu, 19 Dec 2024 03:10:15 -0500 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-436281c8a38so3213355e9.3 for <74958@debbugs.gnu.org>; Thu, 19 Dec 2024 00:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734595749; x=1735200549; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=8n0pLq+br/NVCAzMVmEucmfI7gvP5wwa8EpJhY43gIA=; b=W+wN9V0kus2/rxHNwGbbBwhZJceSnFcgEIHep77saWrws8luicCcefIE3rDDaEvrC6 71N4imnspmbKTbpl/E8TRu45HU9gOXi6YbbFjwPzhf7HC5qbRkP4IsXHixGm51Ta/n/c CyC5joV9vKHJld1zn/sX2fq29w7RkF/rxkORrAM8qqBR6mx4wG42LioJEtuozL2KixdP /ORFQveBAnIxik4CCVcGEJKp7Vrv7c28GaznCvD6Xu7fjqmIcWi+Z8AU1PgE9bp5lmNj nPvqPgDKBIOQrG/qL7ru7a5W+KbW42E0BezjuWxQzqIV2tlclHDmQNFllVMUpG/BGzq3 Onow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734595749; x=1735200549; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8n0pLq+br/NVCAzMVmEucmfI7gvP5wwa8EpJhY43gIA=; b=BXOQ1HvOO+Tq/36cirDoFZade/uaa3jbuNq1Fah1QLfG67mcFVbIGIiUFMyTSLmgUE jjGop4ZILMKStLSHYlVSqoVesiqoKwPMhXVa2RvlQ8lob95wTllnLoLYvSo5pnhhsMAY ArmOZgSNuOOoG9u/qNH5RErzGAvbvYQt35KPpyBNjCpVuF/ecCiaxceHT6ilWYjsTbCG CbnmNU4nDk6KbGb9s0JlcdQkY2Xn7Qr9kUT89gdu8fnTmjgwS+R20pVYLYxzacICEXTl ljrFuJICmvAf0YnBzmKQHUXs0zjAJETbcAKYkJivETuvr/4GeAY1Bznj9xMT5q1gXrLL VW+Q== X-Gm-Message-State: AOJu0Yz5sGnu9oIa3qDUBYa0Zv6GGiezRc+hVtbMO2i8XhWv/qmlE+q5 k1aRigoYzw73lkWmLDesrjnV5xqkRZMFCntLcLOgvlFdlUb8pSvS X-Gm-Gg: ASbGnct7EFLM7reCi1LZIuTR14a2x73jG0Hmmw1Uf73kfA7+/v/eR9iEbuzwt5GFq8p bGMsbDo8NZAJ2wXf2ceW2EXWPckQC5kAEv7tvMLN/sAeaIDD943LQFWkXw4wr6IwnQCXJi0sHF+ RttsjtSAf/kS4cH0CQpuXxHosqbsEqCtIyAOG5u21/AgDeWQiMwlzYesH6zYLJq7yFy7RCfzkDI OV3tW+uAtvPI4ZEHCJ+QNveaYyVzVOPHLT3yETqOk7/467IVqqTOL2V X-Google-Smtp-Source: AGHT+IEZ5CFaubTWY2SvAkeO1ePWfZgeKd4/hXKrDMYQUpwwlYQPZh7qRF0O/r+PPj0jkECc/rso6Q== X-Received: by 2002:a05:600c:3ba8:b0:434:e8cf:6390 with SMTP id 5b1f17b1804b1-43655343c1cmr52079785e9.6.1734595748584; Thu, 19 Dec 2024 00:09:08 -0800 (PST) Received: from localhost ([31.210.180.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b4432dsm43846825e9.41.2024.12.19.00.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 00:09:07 -0800 (PST) Date: Thu, 19 Dec 2024 10:09:06 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Maxim Cournoyer , 74958@debbugs.gnu.org References: <625c1e42f8e5cc01fd402d050710027431e2aab0.1734572533.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hex1Itav/DEw0+xr" Content-Disposition: inline In-Reply-To: <625c1e42f8e5cc01fd402d050710027431e2aab0.1734572533.git.maxim.cournoyer@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -10.57 X-Spam-Score: -10.57 X-Migadu-Queue-Id: D44971857F X-TUID: AQt0O6oFSXNc --hex1Itav/DEw0+xr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable IIRC we chose to use '--release' for cargo-test-flags to minimize the amount of rebuilding we did with each package. If the tests are expected to be run not in release mode then I guess we should change it. I'll apply the patch to rust-team and then go through and see about removing the cargo-test-flags from various packages. On Thu, Dec 19, 2024 at 10:46:18AM +0900, Maxim Cournoyer wrote: > The default behavior for 'cargo test' is to build in debug mode, and many= test > suites expect support for things provided in this mode such as debug > assertions (see for example: > ). >=20 > * guix/build-system/cargo.scm (cargo-build): Remove '--release' from > #:cargo-test-flags. > * guix/build/cargo-build-system.scm (check): Likewise. >=20 > Change-Id: I8a659c25bd33bc1bdfd88e440bd00bad09a5fc01 > --- > guix/build-system/cargo.scm | 4 ++-- > guix/build/cargo-build-system.scm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm > index 9850969156..452f7f78d0 100644 > --- a/guix/build-system/cargo.scm > +++ b/guix/build-system/cargo.scm > @@ -93,7 +93,7 @@ (define* (cargo-build name inputs > (test-target #f) > (vendor-dir "guix-vendor") > (cargo-build-flags ''("--release")) > - (cargo-test-flags ''("--release")) > + (cargo-test-flags ''()) > (cargo-package-flags ''("--no-metadata" "--no-veri= fy")) > (features ''()) > (skip-build? #f) > @@ -153,7 +153,7 @@ (define* (cargo-cross-build name > (test-target #f) > (vendor-dir "guix-vendor") > (cargo-build-flags ''("--release")) > - (cargo-test-flags ''("--release")) > + (cargo-test-flags ''()) > (cargo-package-flags ''("--no-metadata" "--n= o-verify")) > (cargo-target (cargo-triplet (or target syst= em))) > (features ''()) > diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-s= ystem.scm > index 453d759470..480134402f 100644 > --- a/guix/build/cargo-build-system.scm > +++ b/guix/build/cargo-build-system.scm > @@ -252,7 +252,7 @@ (define* (check #:key > parallel-build? > parallel-tests? > tests? > - (cargo-test-flags '("--release")) > + (cargo-test-flags '()) > #:allow-other-keys) > "Run tests for a given Cargo package." > (when tests? > --=20 > 2.46.0 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --hex1Itav/DEw0+xr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdj1J8ACgkQQarn3Mo9 g1Hyog/+MrNUFX/5tiUreE3pxQqay797HsYE9tgb46SQxP1PtUj7O8snXM9faMVr UeD/RsJ2aEwNWhiCS1JxC8rDuJWuiWY4YaWMwfB+jByGfjyfc1d+Xw+tNgXzW3Cl o4Y/f5514254SLXIyAiPbmJvAZl/71/a6pJ6UuhU+klF944xXkh6J9711CyoAYXI 13+aKw6rQVg7ILU7fojD4wSxmzEiZZysu19OK8X8dt8hxoGKWFITmAG0A3W5VIdG +qgCZ/aFp/QmzFa/GwolWgG1gBogF111E1b6ddBPo2ZD6P52XRdu5KTJfIG08FtG eoZj8Tx12tRoGAPP+40M8p0IfBOioREIED40GN3yNaRbZGM9kgRR26DpoPkNEqRy DVBuzSHo+t2vIMHxIX7oU2YfqzRJCzOM4mKO+Fzr2HJ9dMSEgG9jijgWe2s5fFIm nRFDyoMNWIkiZUntQMgtd/vaVTowq37Mfxp6YIVzOBVJ/qpwORqUnjjPNT0doAwu 9wxo4koXWzUDj0IxrNaprQ/V4AfsRJ+FlyRQe3wCN2rxjLqccW69RffHXdfMNB6B jEIo8UYSZ1eReV93fG68r8WNQip+yvQqs1eSYmblM55tpIYWPCxRj/Qvu6rMG8Q3 Y9fGEF4Y2ZQRH6SeKRXtTNRhgIbrBvTR1ZcE57N8GUcjy3z2Er0= =QBgW -----END PGP SIGNATURE----- --hex1Itav/DEw0+xr--