unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 74958@debbugs.gnu.org
Subject: [bug#74958] [PATCH rust-team 1/5] build/cargo.scm: Remove '--release' from default cargo-test-flags.
Date: Thu, 19 Dec 2024 10:09:06 +0200	[thread overview]
Message-ID: <Z2PUole1d4bDuBcL@3900XT> (raw)
In-Reply-To: <625c1e42f8e5cc01fd402d050710027431e2aab0.1734572533.git.maxim.cournoyer@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3067 bytes --]

IIRC we chose to use '--release' for cargo-test-flags to minimize the
amount of rebuilding we did with each package.  If the tests are
expected to be run not in release mode then I guess we should change it.

I'll apply the patch to rust-team and then go through and see about
removing the cargo-test-flags from various packages.

On Thu, Dec 19, 2024 at 10:46:18AM +0900, Maxim Cournoyer wrote:
> The default behavior for 'cargo test' is to build in debug mode, and many test
> suites expect support for things provided in this mode such as debug
> assertions (see for example:
> <https://github.com/google/zerocopy/issues/2143>).
> 
> * guix/build-system/cargo.scm (cargo-build): Remove '--release' from
>  #:cargo-test-flags.
> * guix/build/cargo-build-system.scm (check): Likewise.
> 
> Change-Id: I8a659c25bd33bc1bdfd88e440bd00bad09a5fc01
> ---
>  guix/build-system/cargo.scm       | 4 ++--
>  guix/build/cargo-build-system.scm | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm
> index 9850969156..452f7f78d0 100644
> --- a/guix/build-system/cargo.scm
> +++ b/guix/build-system/cargo.scm
> @@ -93,7 +93,7 @@ (define* (cargo-build name inputs
>                        (test-target #f)
>                        (vendor-dir "guix-vendor")
>                        (cargo-build-flags ''("--release"))
> -                      (cargo-test-flags ''("--release"))
> +                      (cargo-test-flags ''())
>                        (cargo-package-flags ''("--no-metadata" "--no-verify"))
>                        (features ''())
>                        (skip-build? #f)
> @@ -153,7 +153,7 @@ (define* (cargo-cross-build name
>                              (test-target #f)
>                              (vendor-dir "guix-vendor")
>                              (cargo-build-flags ''("--release"))
> -                            (cargo-test-flags ''("--release"))
> +                            (cargo-test-flags ''())
>                              (cargo-package-flags ''("--no-metadata" "--no-verify"))
>                              (cargo-target (cargo-triplet (or target system)))
>                              (features ''())
> diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
> index 453d759470..480134402f 100644
> --- a/guix/build/cargo-build-system.scm
> +++ b/guix/build/cargo-build-system.scm
> @@ -252,7 +252,7 @@ (define* (check #:key
>                  parallel-build?
>                  parallel-tests?
>                  tests?
> -                (cargo-test-flags '("--release"))
> +                (cargo-test-flags '())
>                  #:allow-other-keys)
>    "Run tests for a given Cargo package."
>    (when tests?
> -- 
> 2.46.0
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-12-19 10:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  1:43 [bug#74958] [PATCH rust-team 0/5] build/cargo.scm: Remove '--release' from default cargo-test-flags Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 1/5] " Maxim Cournoyer
2024-12-19  8:09   ` Efraim Flashner [this message]
2024-12-19 12:50     ` Maxim Cournoyer
2024-12-19 12:52   ` bug#74958: " Efraim Flashner
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 2/5] gnu: rust-zerocopy-0.8: Reinstate all tests Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 3/5] gnu: rust-libc-0.2: Update to 0.2.168 Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 4/5] gnu: rust-zerocopy-0.8: Update to 0.8.13 Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 5/5] gnu: rust-zerocopy-derive-0.8: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2PUole1d4bDuBcL@3900XT \
    --to=efraim@flashner.co.il \
    --cc=74958@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).