unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Herman Rimm <herman@rimm.ee>
Cc: 75097@debbugs.gnu.org
Subject: [bug#75097] [PATCH rust-team 1/8] gnu: override-jemalloc: Add variable.
Date: Thu, 26 Dec 2024 15:44:28 +0200	[thread overview]
Message-ID: <Z21dvOrma1li0WPe@3900XT> (raw)
In-Reply-To: <25cd151219b68e3f67148dbba6e3674249faee91.1735157957.git.herman@rimm.ee>

[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]

This one I'm unconvinced about.  I could see adding CARGO_FEATURE... to
the cargo-build-system, but this seems like a temporary problem that I
hope gets fixed upstream.  If we move this out to a separate location
I'm worried we'll forget about it when it's no longer needed.

Plus we're using libjemalloc_pic.a here and libjemalloc.so in
rust-apps.scm, and I'd prefer to not hard-code one or the other.

On Wed, Dec 25, 2024 at 09:20:20PM +0100, Herman Rimm wrote:
> * gnu/packages/crates-io.scm (override-jemalloc): Add variable.
> 
> Change-Id: I3e1666306c9f005072f9ed230f03386b2f78b0b2
> ---
>  gnu/packages/crates-io.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index b3d9bcd783..fb7710c5a9 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -39209,6 +39209,19 @@ (define-public rust-javascriptcore-rs-sys-0.2
>       "Sys functions for the Rust bindings of the javacriptcore library.")
>      (license license:expat)))
>  
> +(define override-jemalloc
> +  #~(modify-phases %standard-phases
> +      (add-after 'configure 'override-jemalloc
> +        (lambda* (#:key inputs #:allow-other-keys)
> +          ;; This flag is needed when not using the bundled jemalloc.
> +          ;; https://github.com/tikv/jemallocator/issues/19
> +          (setenv
> +            "CARGO_FEATURE_UNPREFIXED_MALLOC_ON_SUPPORTED_PLATFORMS"
> +            "1")
> +          (setenv "JEMALLOC_OVERRIDE"
> +                  (string-append (assoc-ref inputs "jemalloc")
> +                                 "/lib/libjemalloc_pic.a"))))))
> +
>  (define-public rust-jemalloc-ctl-0.5
>    (package
>      (name "rust-jemalloc-ctl")
> 
> base-commit: 32ab343e03e998ada27c063ef7d8a00aa88436dd
> -- 
> 2.45.2
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2024-12-26 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25 20:20 [bug#75097] [PATCH rust-team 1/8] gnu: override-jemalloc: Add variable Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 2/8] gnu: rust-jemalloc-ctl-0.5: Use override-jemalloc phases Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 3/8] gnu: rust-jemalloc-sys-0.5: " Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 4/8] gnu: rust-jemalloc-sys-0.3: " Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 5/8] gnu: rust-jemallocator-0.5: " Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 6/8] gnu: rust-jemallocator-0.1: " Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 7/8] gnu: rust-nom-6: " Herman Rimm via Guix-patches via
2024-12-25 20:21 ` [bug#75097] [PATCH rust-team 8/8] gnu: rust-nom-5: " Herman Rimm via Guix-patches via
2024-12-26 13:44 ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z21dvOrma1li0WPe@3900XT \
    --to=efraim@flashner.co.il \
    --cc=75097@debbugs.gnu.org \
    --cc=herman@rimm.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).