unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 57317@debbugs.gnu.org, GNU Guix maintainers <guix-maintainers@gnu.org>
Subject: [bug#57317] [PATCH 0/2] Implicitly set GUIX_EXTENSIONS_PATH in profiles.
Date: Mon, 22 Aug 2022 12:20:35 +0300	[thread overview]
Message-ID: <YwNKYzFycw/HIDMN@3900XT> (raw)
In-Reply-To: <87v8ql1itz.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

On Sun, Aug 21, 2022 at 09:41:41PM +0200, Ricardo Wurmus wrote:
> I agree with Maxime: this looks good, and I also think that other
> variables could be set unconditionally.
> 
> Yes, it’s a little inelegant to set environment variables like this, but
> for GUIX_EXTENSIONS_PATH I think it’s warranted, because Guix is special
> anyway.
> 
> So +1 from me.
> 
> I’m CC’ing the maintainers to perhaps get a comment on the general
> approach for the record.
> 

Not with my maintainer hat on:

I tried to create an extension a while ago and it wasn't entirely clear
to me how to force loading extensions correctly when testing from a guix
environment.

By removing the notes about setting GUIX_EXTENSION_PATH to
~/.guix-profile/... we allow Guix to use actual search paths like we do
with other environment variables so we can use it with guix-home or
other alternate profiles, such as the OS config.


I took a minute to look at my extension; I had to set
GUIX_EXTENSION_PATH to an absolute location, not a relative one.

Normally we'd tell people they have to install a package to make use of
it's search paths, like reminding people to add python to their shell
invocation, not just python-pip. In this case we DON'T want people
installing the guix package, so we need to make the environment variable
available another way.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-08-22  9:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21 13:12 [bug#57317] [PATCH 0/2] Implicitly set GUIX_EXTENSIONS_PATH in profiles ( via Guix-patches via
2022-08-21 13:16 ` [bug#57317] [PATCH 1/2] build: profiles: Always set GUIX_EXTENSIONS_PATH ( via Guix-patches via
2022-08-21 13:16   ` [bug#57317] [PATCH 2/2] gnu: package-management: Remove mentions of GUIX_EXTENSIONS_PATH ( via Guix-patches via
2022-08-21 15:43 ` [bug#57317] [PATCH v2 1/2] build: profiles: Implicitly set GUIX_EXTENSIONS_PATH ( via Guix-patches via
2022-08-21 15:43   ` [bug#57317] [PATCH v2 2/2] gnu: package-management: Remove mentions of GUIX_EXTENSIONS_PATH ( via Guix-patches via
2022-08-21 19:38   ` [bug#57317] [PATCH v2 1/2] build: profiles: Implicitly set GUIX_EXTENSIONS_PATH Maxime Devos
2022-08-21 19:41 ` [bug#57317] [PATCH 0/2] Implicitly set GUIX_EXTENSIONS_PATH in profiles Ricardo Wurmus
2022-08-22  9:20   ` Efraim Flashner [this message]
2022-09-07  8:46 ` bug#57317: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwNKYzFycw/HIDMN@3900XT \
    --to=efraim@flashner.co.il \
    --cc=57317@debbugs.gnu.org \
    --cc=guix-maintainers@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).