[bug#56729] [RFC PATCH 00/10] Add sagemath.

[vicvbcun <guix@ikherbers.com>]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

On 2022-08-09T12:47:27+0200, Andreas Enge wrote:
> thanks for the update! I just pushed an update of maxima (and wxmaxima), but
> without your addition of ecl. Is there a good reason for this? In any case,
> this should be done in a separate commit, since it is not required for the
> update. For the record, I also tried to compile with gcl, but this still
> failed.
SageMath requires the FASL library? (I only know scheme) `maxima.fas'.
But it is only built when using ecl (See upstream here [0]). I don't
know if we need both sbcl and ecl. Arch uses both and puts the
lib/.../binary-* directories in separate packages[1], so maybe we could
use different outputs? Anyway, I have attached an rebased commit that
adds ecl.

> > > Concerning sagemath itself, below is my very old version of an attempt at
> > > packaging the library. Some things look reassuringly similar, my handling
> > > of the number of cores is less nice, but I do delete the bundled packages.
> > The `upstream' directory only seems to exist in the published tarball.
> > So this should be no problem if we build from git.
> 
> Ah, interesting. Which one should we do? I personally tend to prefer tarballs
> (as the official distribution mechanism of the project). Recently there has
> been a preference in the Guix project for git repositories when autotools
> are involved, as they make it possible to recreate the configure scripts
> from their source. But since this is not the case here, the argument does
> not hold.
The sage tarball is 1.35 GiB while the repository is only about 440 MiB.
That seems quite convincing on its own.

[0]:
https://sourceforge.net/p/maxima/patches/80/
[1]:
https://github.com/archlinux/svntogit-packages/blob/packages/maxima/trunk/PKGBUILD

[-- Attachment #2: 0001-gnu-maxima-Build-with-ecl-and-install-maxima.fas.patch --]
[-- Type: text/plain, Size: 2207 bytes --]

From cb877ee5091d801e08654ac55adaab1b5edfec91 Mon Sep 17 00:00:00 2001
Message-Id: <cb877ee5091d801e08654ac55adaab1b5edfec91.1660051561.git.guix@ikherbers.com>
From: vicvbcun <guix@ikherbers.com>
Date: Sat, 6 Aug 2022 18:00:19 +0200
Subject: [PATCH] gnu: maxima: Build with ecl and install maxima.fas.

The eventual sagemath package requires maxima.fas, which is only build with
ecl.

* gnu/packages/maths.scm (maxima)[inputs]: Add ecl.
[configure-flags]: Build with ecl.
[install]: Install maxima.fas.
---
 gnu/packages/maths.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index e32a71100e..b250649a45 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -4357,6 +4357,7 @@ (define-public maxima
     (build-system gnu-build-system)
     (inputs
      `(("bash" ,bash-minimal)
+       ("ecl" ,ecl)
        ("gnuplot" ,gnuplot)                       ;for plots
        ("sbcl" ,sbcl)
        ("sed" ,sed)
@@ -4365,7 +4366,8 @@ (define-public maxima
      (list texinfo perl python))
     (arguments
      `(#:configure-flags
-       ,#~(list "--enable-sbcl"
+       ,#~(list "--enable-sbcl" "--enable-ecl"
+                (string-append "--with-ecl=" #$ecl "/bin/ecl")
                 (string-append "--with-sbcl=" #$sbcl "/bin/sbcl")
                 (string-append "--with-posix-shell=" #$bash-minimal "/bin/sh")
                 (string-append "--with-wish=" #$tk "/bin/wish"
@@ -4409,6 +4411,10 @@ (define-public maxima
                       "--lisp=sbcl "
                       "--batch-string=\"run_testsuite();\" "
                       "| grep -q \"No unexpected errors found\""))))
+         (add-after 'install 'install-fas
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "src/binary-ecl/maxima.fas"
+                               (string-append (assoc-ref outputs "out") "/lib/maxima/" ,version "/binary-ecl"))))
          ;; Make sure the doc and emacs files are found in the
          ;; standard location.  Also configure maxima to find gnuplot
          ;; without having it on the PATH.

base-commit: 0d9eef0a06ffcb6a0f66d272ea036597b521ffb6
-- 
2.37.0