From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kKUwEms/6mI9HQAAbAwnHQ (envelope-from ) for ; Wed, 03 Aug 2022 11:27:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0FbvEWs/6mLpSwEAauVa8A (envelope-from ) for ; Wed, 03 Aug 2022 11:27:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CD991E161 for ; Wed, 3 Aug 2022 11:27:06 +0200 (CEST) Received: from localhost ([::1]:33136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJAef-00012o-GJ for larch@yhetil.org; Wed, 03 Aug 2022 05:27:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJAam-0006vj-7K for guix-patches@gnu.org; Wed, 03 Aug 2022 05:23:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJAaj-0001Vw-W5 for guix-patches@gnu.org; Wed, 03 Aug 2022 05:23:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJAaj-0000Pa-PB for guix-patches@gnu.org; Wed, 03 Aug 2022 05:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56729] [RFC PATCH 00/10] Add sagemath. Resent-From: guix@ikherbers.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 09:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 56729@debbugs.gnu.org, Andreas Enge Received: via spool by 56729-submit@debbugs.gnu.org id=B56729.16595185571539 (code B ref 56729); Wed, 03 Aug 2022 09:23:01 +0000 Received: (at 56729) by debbugs.gnu.org; 3 Aug 2022 09:22:37 +0000 Received: from localhost ([127.0.0.1]:46128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJAaK-0000Ol-St for submit@debbugs.gnu.org; Wed, 03 Aug 2022 05:22:37 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:37537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJAaI-0000Oc-9d for 56729@debbugs.gnu.org; Wed, 03 Aug 2022 05:22:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1659518534; s=strato-dkim-0002; d=ikherbers.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Hlsp9lAytBQZ2Q7s6fu5Opl/RoH4/z5vsR0B+LLfLnk=; b=L2YeKCYMHbSh4JYkcUuB6yGr9UXT105OT+hutwqooLWXmCwj+7bvvY8os+LL0oSQzE RLigserz+O+2pXPCfYyWzSa/1VdM95lT48laloc00yxDTFj0hAClPCORvCcnbvp2fXYs 3f8zbgglzqUofBr7js6lL45+LEJovEh9/5VtqRW4nz7k1DktptYHAJCaIJDw8Sv+VMnx YD0mZeVsoujLUF6AyPjaGT3+hJhXHnypKqIUCF9tcxCc30j+4WsYAHFq4XrKw++4dkkE FvAVDUXKlkZasNq+LJOAq8Qshp0UGqqJs8a73DAzSmR6wOnBJEMHphQlhfVPo3Nil5Fy 9efw== X-RZG-AUTH: ":IUwNfkitaf3qOWm2b/jA5tveVwUUcwH3PkiYp6DPxTDDEo4xO9SmHnazdiAbr2jcTsO0Ng==" X-RZG-CLASS-ID: mo00 Received: from lambda.localdomain by smtp.strato.de (RZmta 47.47.0 DYNA|AUTH) with ESMTPSA id 0cac6cy739MDWDc (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 3 Aug 2022 11:22:13 +0200 (CEST) Date: Wed, 3 Aug 2022 11:21:43 +0200 From: guix@ikherbers.com Message-ID: Mail-Followup-To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 56729@debbugs.gnu.org, Andreas Enge References: <87y1w81flc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y1w81flc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659518827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Hlsp9lAytBQZ2Q7s6fu5Opl/RoH4/z5vsR0B+LLfLnk=; b=P0fZ7Rpjlxy6KDUywcWIrOpFPxPz4NNu67eEnxQXYqM+QaKLrE/IvQkOCAmMN8cuXUhxx2 IO5y2bCZpc/qEvHPc3hONGGm++PkP89L3X32ewSZTKRPdIsE/Yb9yiJEKU2JmEFnzSShzx LIyNsHlolouzRchT2I1RYTgb+14KmCq8BAzf+i76gV7wTTseXnkJvSTH5knSoM7FCERCMw daxHsBewJYVfBOb61tqNb4zEeWa30DLRllEhCI+8xjRFLYwsTMkVmAeyRMmGYSEJC6DQ7+ NW02d7aWZIxdlOp2aHm25xQI+k+JKsxBLGcZZQ0b7+N2GjrOaq0cmJvq8jl67g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659518827; a=rsa-sha256; cv=none; b=N+emOw2B78Q7ktsesK0RWZwbqgo5txl7hdSaVudpEYEdFnB9qCON3KieSz3+4rAU+v9KAD mnCdX9kHl9xDwnlpayFiwPTNbn3duU0MMIDsioe7gogEZ5JJEPx+bes2mGoVvPzsQCLN5Q 9jwOIUu2mWeNYd7jVrUDEa9h+e9DJdZ5j8arYYg5IQid345nF03ZdluaC4sSJKfvgvrAL3 yvFwGUqDimV4GI19o+qiTCzZBGh1j5bbf4WfaNbdaBlEV9K75O+j0H0n/+w4fraL48CBFT yeOc/B8MNINBYkwiFddtU5GaWIkECYvicDJ+VY81fdaij79wWDVD+Fdvf/dLLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ikherbers.com header.s=strato-dkim-0002 header.b=L2YeKCYM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.09 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ikherbers.com header.s=strato-dkim-0002 header.b=L2YeKCYM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0CD991E161 X-Spam-Score: 1.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: egL2L9fHxXie Hello, On 2022-08-01T11:24:31+0200, Ludovic Courtès wrote: > > This series adds SageMath. Everything compiles just fine and even the > > Jupyter notebook interface works, but there is still much work to do. So > > far, I have only added the minimal set of inputs required for the build > > to succeed. Tests and documentations are still missing. > > This looks great already! To make sure things don’t stall, we could > apply the patch series piecemeal, starting with the dependencies that > you think are ready, and leaving more time to polish the ‘sagemath’ > package. > > WDYT? Sounds like a good idea. The updates all seem fine to me (except gap) and other than perhaps a better description for python-memory-allocator I don't think there is much left to do for the other ones. As for gap, I took another stab at it and it now builds reproducibly for me. I also removed all the trailing #t's and changed the phases to use a gexp. By the way, the gap definition contains a snippet that deletes many gap packages over concerns due to missing explicit licenses. However in a cursory look at the tarball, I can see many LICENSE/COPYING files so that may have changed. > Regarding SageMath, my understanding is that it bundles lots of things. > In Guix, we’d like to make sure we do not use the bundled packages, > unless we practically can’t avoid it. To do that, the best option is to > remove “third-party” (or similar) directories right in the ‘snippet’ of > the ‘sagemath’ package. Could you give that a try? If I understand the Sage build system correctly, missing dependencies are automatically retrieved and build only when using the provided Makefile. As is, the package definition builds and installs only the python library part using setup.py. Thus a missing dependency probably leads to a runtime error, though I haven't checked this. > Then, as you note, we’d rather run tests to make sure the package works > as intended. I will try to see if I can get tests to work, though probably as separate "package" like nixpkgs does[0], to avoid rebuilding sagemath so often :). As for sagemath itself, I will have a look at what exactly we need in bin/. [0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/math/sage/sage-tests.nix