From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OG16A6RcvGLoYgAAbAwnHQ (envelope-from ) for ; Wed, 29 Jun 2022 16:07:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eFF1AqRcvGLqzQAAG6o9tA (envelope-from ) for ; Wed, 29 Jun 2022 16:07:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F04B0225F for ; Wed, 29 Jun 2022 16:07:30 +0200 (CEST) Received: from localhost ([::1]:54526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6YLp-0005bS-V4 for larch@yhetil.org; Wed, 29 Jun 2022 10:07:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6XDi-0007dJ-85 for guix-patches@gnu.org; Wed, 29 Jun 2022 08:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6XDh-0002ke-UF for guix-patches@gnu.org; Wed, 29 Jun 2022 08:55:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6XDh-0005zE-OS for guix-patches@gnu.org; Wed, 29 Jun 2022 08:55:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56200] [PATCH v2] gnu: linux-libre: Enable the AMD HSA driver. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Jun 2022 12:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56200 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: John Kehayias Cc: "56200@debbugs.gnu.org" <56200@debbugs.gnu.org> Received: via spool by 56200-submit@debbugs.gnu.org id=B56200.165650729722995 (code B ref 56200); Wed, 29 Jun 2022 12:55:01 +0000 Received: (at 56200) by debbugs.gnu.org; 29 Jun 2022 12:54:57 +0000 Received: from localhost ([127.0.0.1]:58002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6XDd-0005yn-Fc for submit@debbugs.gnu.org; Wed, 29 Jun 2022 08:54:57 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6XDb-0005yZ-87 for 56200@debbugs.gnu.org; Wed, 29 Jun 2022 08:54:56 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CF8975C0488; Wed, 29 Jun 2022 08:54:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 29 Jun 2022 08:54:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; t=1656507289; x=1656593689; bh=LLB+ZOTIUp2SDQaZdAKIgBvY3eTVhs2gzuy3tT9amPY=; b=i/ULFWN7cgXK qN4ZdjLJ1g+sndnevUev+bXi8Ap0+OyfayYlkdcrGKKfZhK2dWQNdszmEpq32lpm i4b85kc4Ppocnog44NkcD8PBLDo3MrbLTNkFb+J1YUllfRxjBBJgwdrNQeWAZqgq KhA+yOAdgPAyjJj9S9xQ8UbqtnwLyDM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656507289; x=1656593689; bh=LLB+ZOTIUp2SDQaZdAKIgBvY3eTV hs2gzuy3tT9amPY=; b=t8ONr6eq+RHpHwTPq5zLNCJ5rU4hQF/Hmtos1g3gYMtD e1k1nHPlhR0tRNvTIa8hrkTBpWbXoM+eO0LlwGWlFSBIDXlG0zFcq3Qq3skSFIRU gcyiW2yFYeeiIwoShGoAZ6jTnFdzhWHHZK+X7iqOYNcx9TTr05HipETHpjtmr9JN OhWM8HqotsdAdGh/yibtq+7TRpY2ST77imtYn3DfpMw9RQHoxWAkQ8YmRqfJIa3g EwhFlk5Lvouh8M602uH6LndqACiWYICzuZp5WDAsb91Q0RCXC22nhoMbMZ3QbDIk xFs6gwUBJwgtCudBTCiaQ3wnw/aNy5qWJbUf49ENUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegledgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhephfelfeefveegledvleffueelvddvgedvtdduhfeivefhuedvvdelhfevuedv udelnecuffhomhgrihhnpehkvghrnhgvlhgtohhnfhhighdrihhopdgtrghtvggvvgdrnh gvthdpghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Jun 2022 08:54:49 -0400 (EDT) Date: Tue, 28 Jun 2022 21:05:24 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656511651; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LLB+ZOTIUp2SDQaZdAKIgBvY3eTVhs2gzuy3tT9amPY=; b=S+9b7JMkPU/4/J956Nw6PAky6pTtR4kGepkbN6LvZm78I2y/34ZuzDfUkzlUINnlrrg5XR 00RG+BAReD1ih9cfSnShuDq0atP4kK+p/1TnRPsNeQC049xJHgpxkUdx7qkuBwcWWFkyZy MBgQgtAWqumn0yJl5wR5C5jbHuoEH2AAQFPGlE9I+AIbxxlS4K/Mse91P4TLetzy4v0/Cl 08JULolPjPHs0u9a6c91N11vJkOg66VE1jS+ca9Z22B0O8T3CZxgcYXcDX/UeMhtqdC0t7 MBdcM0ubLgXZS8FmtiO9mBcOwunn4OiF0v+fbt/o5+a6fuEkYPvZSXRd/+t3+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656511651; a=rsa-sha256; cv=none; b=fVirA1Wsfx16zboyNCPj8vyzOEFrKdWtV005CthkMQPeNWguWJYICgJ54tgcWq2uWv12T0 3YnDCe1FBhkrWKBLpTGuB2+9dZFBqzTNtQJyI2OlbCPIhDOEwW7bhrVi1isPuuLUmQYGZF Lxzh0s0yOyvkDjynZPdKMkHegH552nM1RVPYyOtsUbS5gIgrvtKMR1w96WL+lm00XnIYAk u78Mrf3yp/32KSB3oookg+zlmAp5aR7Zy5RogETmJ13JDTrfZ6gvWhIracTDScPd7y6kkH Hy+v7s7TLOqAxdElO6755SgdOzinlyig9KXNL/hNswOKdLp1XIekebACFR4NQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="i/ULFWN7"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=t8ONr6eq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="i/ULFWN7"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=t8ONr6eq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F04B0225F X-Spam-Score: -0.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: GkzSDKz1cgZB On Wed, Jun 29, 2022 at 12:38:56AM +0000, John Kehayias wrote: > I've attached a v2 of the patch that sets it for all the configurations where the option was listed. Note that a few had it "enabled" with setting it to "m", but I don't think that does anything, per my testing. And looking at the documentation, seems like it should be "y": https://www.kernelconfig.io/config_hsa_amd I think the changes for our configs before version 5.4 are unnecessary. I checked out the source code of linux-libre 4.9.316 and copied our 4.9 config and removed the CONFIG_HSA_AMD line. Then, I did `make oldconfig` within ` guix environment linux-libre --ad-hoc gcc-toolchain`, and it offered me a choice between N and m for this option. So, I think they changed this feature so that it can no longer be a module in version 4.20. Check the "found in Linux kernels" info here: https://cateee.net/lkddb/web-lkddb/HSA_AMD.html I removed the changes to the configs for 4.9, 4.14, and 4.19, and pushed to a WIP branch for final testing: https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-linux-libre-5.18 I'll build kernels for x86_64 on the build farm, so substitutes will be available for testing after a few hours.