From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YFiUHPCtRWL3FQAAgWs5BA (envelope-from ) for ; Thu, 31 Mar 2022 15:34:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yOkBGvCtRWIcGQAA9RJhRA (envelope-from ) for ; Thu, 31 Mar 2022 15:34:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EC4913EDD5 for ; Thu, 31 Mar 2022 15:34:39 +0200 (CEST) Received: from localhost ([::1]:55760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZuwg-0001M4-Q2 for larch@yhetil.org; Thu, 31 Mar 2022 09:34:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZuvA-0006lp-41 for guix-patches@gnu.org; Thu, 31 Mar 2022 09:33:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZuv9-0001TA-AV for guix-patches@gnu.org; Thu, 31 Mar 2022 09:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZuv9-0006BM-8O for guix-patches@gnu.org; Thu, 31 Mar 2022 09:33:03 -0400 Subject: bug#54635: [PATCH v2 5/5] gnu: Add wfmash. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 31 Mar 2022 13:33:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54635 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54635-done@debbugs.gnu.org, Arun Isaac Received: via spool by 54635-done@debbugs.gnu.org id=D54635.164873353823661 (code D ref 54635); Thu, 31 Mar 2022 13:33:03 +0000 Received: (at 54635-done) by debbugs.gnu.org; 31 Mar 2022 13:32:18 +0000 Received: from localhost ([127.0.0.1]:38290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZuuQ-00069Y-4K for submit@debbugs.gnu.org; Thu, 31 Mar 2022 09:32:18 -0400 Received: from flashner.co.il ([178.62.234.194]:48476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZuuO-00069M-Dv for 54635-done@debbugs.gnu.org; Thu, 31 Mar 2022 09:32:16 -0400 Received: from localhost (unknown [5.102.239.82]) by flashner.co.il (Postfix) with ESMTPSA id 6290C40023; Thu, 31 Mar 2022 13:32:10 +0000 (UTC) Date: Thu, 31 Mar 2022 16:31:28 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , Arun Isaac , 54635-done@debbugs.gnu.org References: <20220331072849.22417-5-arunisaac@systemreboot.net> <41db70e1e90803d02444ea5c0ffae0e0d6309700.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PQfNK4hbb0I1GiG7" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648733680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=c/pqFujAhJ7m1U6X1HvI15rEsU3vTpl0PsUjtrXrqHs=; b=RTAwsXXRLpWUBLyJw2WljEPOMt6dUFAMGb64kWVnn+K88W3lW6RhrQRZ+5YyakSd4HlQtA JEVKvnoV6gAiHRgp5biXyoiqz3Yo5yge5Kcj0ofbPxevEsi7vQyLntCmDNR9xh08sHYM6i IdBqV1QQLHhdGb8q5ivAxXU6MJYTHyX6x/ZSOAZlNZShwhPfToXwGlqZtLaNszxO0RQmc7 1QbBqkbw9FcePl1041S8RgvsyajwRy+nN2Ns28I4XWANHncFWaeDkSj/QvjzWH9V7EAK+Q utkepaslueJKoTZdu6k+MQS4f9TI4E8GyVmogJhosysq04onGE7Z5uR2KZnqWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648733680; a=rsa-sha256; cv=none; b=AkDdzzt0wsz+yS9+a8UJsfyV04D6x/uyWlizjOxqIe1jlLdx+jj8iK2qvhV7ICp6VKzzDs 3C8H2F7TZTWJpcjCa3TICJqVpT87xqxz2EviwOibwGjxEVDYXZZcinVlepqefKv/tXTyI6 Sy1XGFUstEFgpA6JaeOoPt7JG/lRdppqgB3yESk6zL7xL393aSwGayMlco3vbmVR/Dxl+t iAR5Bzhi+feMM3ujoi8Mlsas7J4xe6jHKLqHP9i//mHq6ZctJxipZnbH5KreTPeJOdhrmp eeeAYdLLDjhf2iU+LsHxw7YvOnc+4w1lP6KNAbvBb7IB8Yof8vESYTudZTlO/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.47 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EC4913EDD5 X-Spam-Score: -5.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: xiut3DXg2UmA --PQfNK4hbb0I1GiG7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2022 at 03:07:49PM +0200, Maxime Devos wrote: > Efraim Flashner schreef op do 31-03-2022 om 15:18 [+0300]: > > > Arun Isaac schreef op do 31-03-2022 om 12:58 [+0530]: > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (("-marc= h=3Dnative") "")) > > >=20 > > > This is also wrong for x86 systems because it makes the build non- > > > reproducible.=C2=A0 Also, has upstream been informed about some of the > > > compiler flags being architecture-specific? > >=20 > > I'm pretty sure upstream is aware of it, and the -mcx16 flag. That > > whole phase doesn't need to be non-x86_64 only, upstream prefers it > > that way to get fater results >=20 > wfmash could be written to detect CPU features at runtime and there is > also --tune. Also, upstream preferring march=3Dnative does not make the > build reproducible. >=20 > > but IMO it would be fine to move it into a snippet. >=20 > It does not have to be in a snippet, it just needs to be reproducible > (so no march=3Dnative, whether on x86 or not). I suppose not, but the -mcx16 should be in the snippet, since it adds compiler flags which only work on some architectures. And while we're at it we can do the -march=3Dnative one too. > Upstream seems to be aware of the non-x86 > (https://github.com/ekg/wfmash/issues/125) but they do not seem to be > aware of the problems with march=3Dnative. >=20 I've pushed these patches with a few tweaks and an additional patch to run a test suite based on the github workflow in the repository. The entire check phase takes ~2 minutes on my pinebook pro, so aarch64 doesn't seem to need to skip some tests like riscv64 does. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --PQfNK4hbb0I1GiG7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmJFrTAACgkQQarn3Mo9 g1FBcA/+JvClmkerJJIax/JXybHhlAdV+382r9jJLJMovjB4RGTc/2ayjF0Bm297 ojDI5OIZB7FlqsyTaXtFvdL3AIMfOmWgaK+YywiHWoIGiNF6zbKwqqIv0pjrcoN9 lawO46TUe0jQD7mYvAFO814/8H7w7KDUv9YhZL7KC+dmNrK5nDtohDRIddxZkM9L xy6eTuzM00uMBP42sttkEpS30BEjQhutsuyhQGZDdWTBtEvoXymFnu5O1X60qx/l Vo/w/sQgW3/g3H+zrux4wVix5+p6kYzWiU5vgdcn0Q9VuU4/ByS2zw/FHtpmyvxM yw7508y664YDD3PVP5XadHYdJ954twRpnByXvaKME46PwCb8HxRfgTVUW/65gov3 m8bt7jrR5eQBLA2eAQ/AmHGCfjfOjaZogXkR8qUmXYVU1Gq6R9vmh1IK+MuR/fZ6 vzsBbNNlDRuZF1/vznezpTZsjmZI0IkmYHErE9T+en/L83Auu1F/eR/NgOy4wsDI OmwzDChQDBdZBj55r1H4lYgbXhCiariVp3UIQKUrlDdO2cS1XXkDHNcVyvv91VsX bAUFgUO9LKcXJgy7ncjqOaLnXmW94Mq2sjgEGB6fevBvZUVXHnYjhZ4F75FbphLJ TDi0Dj9uPM365hCH031WHhjsug2IL+vsAYBEcnxCyCf0Oi7FPCM= =zO0z -----END PGP SIGNATURE----- --PQfNK4hbb0I1GiG7--