From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WImwLIrw52HmNwAAgWs5BA (envelope-from ) for ; Wed, 19 Jan 2022 12:05:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8Pd+JYrw52GMsQAAG6o9tA (envelope-from ) for ; Wed, 19 Jan 2022 12:05:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDABE3A927 for ; Wed, 19 Jan 2022 12:05:45 +0100 (CET) Received: from localhost ([::1]:45058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nA8me-0006PH-S4 for larch@yhetil.org; Wed, 19 Jan 2022 06:05:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nA8lz-0006MN-DL for guix-patches@gnu.org; Wed, 19 Jan 2022 06:05:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nA8ly-0004hd-Ar for guix-patches@gnu.org; Wed, 19 Jan 2022 06:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nA8ly-00013w-5D for guix-patches@gnu.org; Wed, 19 Jan 2022 06:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Jan 2022 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53318 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= , 53318@debbugs.gnu.org Received: via spool by 53318-submit@debbugs.gnu.org id=B53318.16425902934062 (code B ref 53318); Wed, 19 Jan 2022 11:05:02 +0000 Received: (at 53318) by debbugs.gnu.org; 19 Jan 2022 11:04:53 +0000 Received: from localhost ([127.0.0.1]:52453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA8lo-00013R-TQ for submit@debbugs.gnu.org; Wed, 19 Jan 2022 06:04:53 -0500 Received: from flashner.co.il ([178.62.234.194]:59146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA8ln-00013C-AP for 53318@debbugs.gnu.org; Wed, 19 Jan 2022 06:04:51 -0500 Received: from localhost (unknown [31.210.177.79]) by flashner.co.il (Postfix) with ESMTPSA id 47164401E7; Wed, 19 Jan 2022 11:04:45 +0000 (UTC) Date: Wed, 19 Jan 2022 13:04:11 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= , 53318@debbugs.gnu.org References: <60e7034e0b9170a2d36e4adafa5a9a3e9835cc17.camel@telenet.be> <36129597cc215850f16001832244b76558e3f67c.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PBZdAJxT1owXQuE0" Content-Disposition: inline In-Reply-To: <36129597cc215850f16001832244b76558e3f67c.camel@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642590346; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=SqvfcD8eNe4L9PpEeDUqxCPjHF5a3p69IK1DPT4YFDo=; b=Z0ZMVH/7iM/PzD86kppIDd79Jj1gj3JmBrwq5uFe91M9Shh02euKXhymMVkzap6YjkjZtK 64iOTAy8wsTVbiN+ZOCAmqKeT0rABH5r97N6qCNyC+Hdz8Agyxy+tGbhhJaqOwoeoGS92W kwLw06drF56fMZ/Jll6If8x9XH91uZjs8vqr665Y5lMvUXRiakthWsO4eztH3vGht1wpn/ cuzpDh49/quZU1YPJw48oyEtrrzOcn9HRFlNblcaBZyCthQFUpZ6SKVYYExhVeVaOUpSRQ xduyXwYhx5wsGHfQTV18tWCpLCUUUHCgJTBpFvMvX02QTaiVaE1oIJOB0wXuEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642590346; a=rsa-sha256; cv=none; b=jHbhbCip7nahKmFLhdg9HulJ1cgs+G8UVnynt1G/3Oaq3guKN3tqvehd1STIH1AnPtMbAD 7cABiB4GyGHP55NS1PGwH1fj8nYdUW1exZpsCuZRiSyc4X5Qz6EQw8owjdJgaD8yXA1S7f NL55UFc2tk6LPqvfWTxRRpEo+IBs4Dp8E8vPQmJjAOcZTAvXWj2At/DP95TsE7UQwOI86g CSWDQnhDw602haTCdtZ11Tf+l6sZ+04GJJe6Swp8hLlYbT0nI26lBnbItrh7aVudC0VlXB yWA+hyKbEoxZuL3KxFvEots3YdraG62gGxSFm3eV2R2nOCtVbWHTYN154Ryt7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CDABE3A927 X-Spam-Score: -6.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: KQwXk2BavqNY --PBZdAJxT1owXQuE0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 18, 2022 at 06:51:29PM +0100, Maxime Devos wrote: > Hi, >=20 > Please keep debbugs in CC: or To: so other people know how the patch is > progressing. >=20 > =E8=B7=AF=E8=BE=89 schreef op di 18-01-2022 om 15:26 [+0000]: > > OK, new patch: [...] >=20 > I did the following checks: >=20 > 1. [x] it builds > 2. [x] "guix lint" shows no problems > 3. [x] there doesn't appear to be any malware in the source code >=20 > While doing (3), I noticed that the test code has a certificate > =E2=80=98certs.pem=E2=80=99 and =E2=80=98key.pem=E2=80=99, which will exp= ire eventually, which isn't > good for long-term reproducibility > (cf.=C2=A0https://issues.guix.gnu.org/44559). >=20 > So in the adjusted package definition, I deleted the affected test > =E2=80=98middleware/middleware_test.go=E2=80=99, 'testdata/cert.pem' and > 'testdata/key.pem', see attachement. >=20 > I also capitalised 'http' to 'HTTP' in the description. > The description is a bit short but I don't have much of an idea > how to improve it. >=20 > Aside from that, it LGTM. FWIW when I imported this package I got the following description: Package chi is a small, idiomatic and composable router for building HTTP s= ervices. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --PBZdAJxT1owXQuE0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmHn8CYACgkQQarn3Mo9 g1ELyxAAp/qIkqzex/0K8to3XoZIQdAqMTcpxZ6G0Rrd9XmnzD1q9UZ2sp+sR+Aw lCAtT/OovrHJBMi1Fc/pzwm3dqF7TI6E+P+Elq+5IIjfqn9F9d2CkmUiZ2s85xh+ Z5E9W8B/08dOkfdHCB7mbnKcH2UgKcUOGKLhCAmJ3B3k6wDzcO+xCzRes5623JzB A+zaBZ9HtW+vWJYvBQRkq02ujN7tEwXjtE2AHmMA8iBW+gGzstZHcbdDMMEBFdwo 2TIBoDuVzXY4ix630uKx46seDapv2O+q4EoHOYwJSUddsif5awE4+lKN0uchtmce 3kZV7RNw5oAwfRGLqAQ8qSwBI0ATxOwfySf6rkO3RjlK5s8OhNTAoaejhb1Qfbq7 PD/bgEOoLWbYfnEIRbylg7J1Bu2ZDt48qiuDgCf5sm3YfUJqVUOYqe4TxYMXRDf0 QhQn7xJdru59M3sjopOIh58fw0HPdRjE0wBEd43sHPRFw/6g73Lt2xf82ovNtBp5 MG2ejEtEPhsmCpVAzu0IUfk7HaAyAzV+Chc9vXamC2Ny4ovVYw9ZgBtzxcklZNxx HXiMQEaCN5JrY4RfOtFja+bJoM/U4h5PSmZP92zCjF6FmCd5n4bnzQA/htoTc4oD 6WSzgmeUwugT+iiHCz6nG28MwEL0l4i7MD4X7nzo8wZ7CdIUwlY= =ruLL -----END PGP SIGNATURE----- --PBZdAJxT1owXQuE0--