From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58796) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSoOd-0005If-VS for guix-patches@gnu.org; Sun, 26 Apr 2020 17:01:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSoOc-0000Hc-Tg for guix-patches@gnu.org; Sun, 26 Apr 2020 17:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSoOc-0000HR-HU for guix-patches@gnu.org; Sun, 26 Apr 2020 17:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSoOc-0008Rm-G9 for guix-patches@gnu.org; Sun, 26 Apr 2020 17:01:02 -0400 Subject: [bug#40492] [PATCH] gnu: Add meshlab Resent-Message-ID: Date: Sun, 26 Apr 2020 21:00:09 +0000 From: Ekaitz Zarraga Message-ID: In-Reply-To: <87blneynu0.fsf@gnu.org> References: <_UXapokzwPRYl41j0bjkPGSDUNXahWNWsEn72py7ch7Rd6DBsxW9B8rw8wTbmzj1O2HfWXz7XLbEdWCYQsFCa5DgMlGn0CKVPr779J2PFuo=@elenq.tech> <87a733v3hh.fsf@gnu.org> <87wo67ti07.fsf@gnu.org> <87blneynu0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "40492\\@debbugs.gnu.org" <40492@debbugs.gnu.org> On Sunday, April 26, 2020 10:49 PM, Ludovic Court=C3=A8s wro= te: > Saluton! > > Ekaitz Zarraga ekaitz@elenq.tech skribis: > > > From 814e44cb90b1427a9af5d6a66392c5a39910e8fd Mon Sep 17 00:00:00 2001 > > From: Ekaitz Zarraga ekaitz@elenq.tech > > Date: Tue, 7 Apr 2020 18:56:06 +0200 > > Subject: [PATCH] gnu: Add meshlab. > > > > * gnu/packages/engineering.scm (meshlab): New variable. > > > > Great! I added a copyright line for you, fixed up indentation (see the > bit in the manual for how to do that automatically), and added a > comment=E2=80=94patch attached. > > It built for me, but then I realized I had missed something: the > external/ sub-directory contains lots of bundled copies of external > tools, and indeed, the =E2=80=98configure=E2=80=99 phase shows: > > --8<---------------cut here---------------start------------->8--- > -- Could NOT find Lib3ds (missing: LIB3DS_INCLUDE_DIR LIB3DS_LIBRARY) > -- Could NOT find GMP (missing: GMP_INCLUDE_DIR GMP_LIBRARY) > -- Could NOT find muparser (missing: MUPARSER_INCLUDE_DIR MUPARSER_LIBRAR= Y) > -- Could NOT find OpenCTM (missing: OPENCTM_INCLUDE_DIR OPENCTM_LIBRARY) > -- Could NOT find Qhull (missing: QHULL_qhull_LIBRARY QHULL_qhull_INCLUDE= _DIR qhull) > -- Found OpenMP_C: -fopenmp (found version "4.5") > -- Found OpenMP_CXX: -fopenmp (found version "4.5") > -- Found OpenMP: TRUE (found version "4.5") > -- - jhead - using bundled source > -- - glew - using bundled source > -- - Eigen - using bundled source > -- - newuoa - using bundled source > -- - levmar - using bundled source > -- - lib3ds - using bundled source > -- - muparser - using bundled source > -- - OpenCTM - using bundled source > -- - structure-synth - using bundled source > -- - qhull - using bundled source > --8<---------------cut here---------------end--------------->8--- > > Some of these are already packaged, so it should be a matter of adding > them to =E2=80=98inputs=E2=80=99. For the remaining ones, it would be ext= ra packaging > work to do. > > The goal is to address all of these, but if we can address the majority > of these, perhaps we can commit a first version of the package with a > FIXME stating what remains to be done, if you prefer. > > Thanks, and apologies for overlooking it before! > > Ludo=E2=80=99. Hi, No worries, I'll try to take a look to those. We can push it with the Fixme and I'll go adding those during these days wh= en I'm free. Thanks! PS: Should I push those to the same file under engineering? or should I cre= ate a new file for meshlab and add all its dependencies there too?