From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SKcZJHz51WF/UAAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 21:03:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gGDbIHz51WEwFgEAauVa8A (envelope-from ) for ; Wed, 05 Jan 2022 21:03:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 551543DFC6 for ; Wed, 5 Jan 2022 21:03:08 +0100 (CET) Received: from localhost ([::1]:35214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5CV1-0006zi-60 for larch@yhetil.org; Wed, 05 Jan 2022 15:03:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5CUw-0006zZ-3y for guix-patches@gnu.org; Wed, 05 Jan 2022 15:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45985) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5CUv-0006Oe-RO for guix-patches@gnu.org; Wed, 05 Jan 2022 15:03:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5CUv-0003cL-LT for guix-patches@gnu.org; Wed, 05 Jan 2022 15:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v6 05/41] guix: node-build-system: Add 'delete-dependencies' helper function. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Timothy Sample , Pierre Langlois , Jelle Licht , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.164141295813617 (code B ref 51838); Wed, 05 Jan 2022 20:03:01 +0000 Received: (at 51838) by debbugs.gnu.org; 5 Jan 2022 20:02:38 +0000 Received: from localhost ([127.0.0.1]:38888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5CUX-0003XZ-Vr for submit@debbugs.gnu.org; Wed, 05 Jan 2022 15:02:38 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5CUW-0003Wp-K1 for 51838@debbugs.gnu.org; Wed, 05 Jan 2022 15:02:37 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E81CE5C00F3; Wed, 5 Jan 2022 15:02:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Jan 2022 15:02:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=1KofZ0YPye9L0C7Y+OQVgs6w xhTDpX90888FMYP5YnA=; b=Fu14yk582XNal+UNnr9xoCysf1jrLrSMtCX/KVaP M4kzdFxzzsOSXe7OMwa7lSwUznhrVh3Vzg4H4iUkoMiYC5k8TmUr4OeR6bRir0hj NLikdg6f53N8/HWpZS2op9wwT/9gfn1CVRrlFNrZ2S55B1RERrgK0hv9AtJCJwXA AWo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1KofZ0 YPye9L0C7Y+OQVgs6wxhTDpX90888FMYP5YnA=; b=JFBPZQ8YkDXMy8rHSUj0M4 eh7VNV/l0PCX8i8l7YSxSb3XGUKa70rFsEeOWmlFm78so8lnoZnV+sAkiz5aQ9u7 1FiwXgwG3MOrTjOONyUbyhdSIY2Kd/c6Xeuo6wC/cuEbOK90JYsmFdBBAqK+1gyR eE/axkwWHcOQ5nFFOaIujUuT/WNmqidPsJpBaPOjiDApN140V07myJTrseHLbpDF wAHWzC1ascCouytZPCw9r3j2D38Tt/CxhRBl216poVh6lzalcQ3fWUC+3S/wLGKe khyBDQgQYEeDg8KZze86IDqKb0kvLywWih6vorCXWpX/WNzIVIlTlx0/F6ZXaUow == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefjedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jan 2022 15:02:29 -0500 (EST) Date: Wed, 5 Jan 2022 15:02:28 -0500 From: Leo Famulari Message-ID: References: <082a81964a43ae5f735ad2ca433d0dfe00859c35.camel@gmail.com> <20211230073919.30327-1-philip@philipmcgrath.com> <20211230073919.30327-6-philip@philipmcgrath.com> <7d5dd434d7750123fa32cb623df0463d60d3f82f.camel@gmail.com> <23eaa7e6-c087-d885-924a-192917758bbf@philipmcgrath.com> <5b83ba5e35af7ac956a6d5de41cb98a892863b55.camel@gmail.com> <4e443a9e-e024-d641-14cd-e36ef7cae46d@philipmcgrath.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e443a9e-e024-d641-14cd-e36ef7cae46d@philipmcgrath.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641412988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1KofZ0YPye9L0C7Y+OQVgs6wxhTDpX90888FMYP5YnA=; b=EvH5z8IGAVcHvFNmyDK/YMMhat5Yym4/5yi/+WYSDQxBCl3rlpJzIG8zMbvIlEp2lG4Qkm pKQMKZElHn2P8hU3cqaTh4SX6L+ghMLQb1/pFmWornSZ/5b2DGA+u1rTh5FGnnJvZbI3Ok VTkQ+1sDV3+77cTG7m+fJqJEzCAI3ql+96WdhKrE9iztxmP7tkBaQSYKZLmlHyg/tq3cWq UsVIcxaIuYDHxFUnKUv5VWl5gafNW6TImUuJDP1l3l0P6R2y4bptZmFmOAy2+cyrsL3cPa VbF44vyaLM8OhbAy1mNnS9OtD6uYpWI98rSkHA4plc9jdTQRpeF7fMJi1aNmyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641412988; a=rsa-sha256; cv=none; b=BD68+AFnJ5ImKRZpAN5fp7TfvCmsUPMpR5FivCAu7uorc6DiYhX1DNmpZb4eWVF5ymCds8 8zguzPgkLKmHX8kkiAqYnQLk2DLuVG4kzXgcj1pjFUj9r7Yy5+OpSZFptJczO0+gqqtsuh bVOalYLrhsCINEZhRlDVNgcz2w9djMFEDkk8Mvsx7hQLrawWAu+flSdTriiEGW53b0r+Qi fA66kmAB2QyKBBNFU3PtTCMDq+fZR2W2HyWRF8S0/oo5GSzb/jsY5DOGHPauEsRfDLuVG0 yExyoEYP4GrVea2NKKXURkTJdiYrjcTkJXAz/BdY3xdk9Y12hUHAnJNtu0dsKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=Fu14yk58; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=JFBPZQ8Y; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=Fu14yk58; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=JFBPZQ8Y; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 551543DFC6 X-Spam-Score: -0.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: AGmeOP3KOsv8 On Wed, Jan 05, 2022 at 02:08:30PM -0500, Philip McGrath wrote: > I would consider it very regrettable if this patch series were to > continue to be blocked by stylistic considerations in the implementation of > unexported helper functions. Agreed. Is there a concrete problem with these patches? Or will they work as specified for Guix packagers? Let's remember that the primary goal of code review is to bring a contribution into the codebase. We have added suboptimal code to Guix many times, because it worked well enough. Later we can refine things. You mention go-build-system as being useful for you. That's very gratifying, because it was a lot of hard work for me to help finalize those patches, and they were quite far from ideal even when they were committed. But the build system allowed Guix users to add Go packages, which later attracted more contributions, and the go-build-system keeps improving as a result.