unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 25848@debbugs.gnu.org, manolis837@gmail.com
Subject: [bug#25848] [PATCH] gnu: %bootstrap-coreutils&co: Patch egrep/fgrep to point to the correct grep.
Date: Wed, 5 Jan 2022 10:23:17 +0200	[thread overview]
Message-ID: <YdVVdYxpBra1OHye@3900XT> (raw)
In-Reply-To: <86o84r9hqy.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Wed, Jan 05, 2022 at 12:57:25AM +0100, zimoun wrote:
> Hi Manolis,
> 
> I am doing bug triage and I hit this one [1].
> 
> 1: <http://issues.guix.gnu.org/issue/25848>
> 
> 
> On Thu, 23 Feb 2017 at 13:41, manolis837@gmail.com wrote:
> 
> > Commit 653add37af10b0d5dbc20c8bc7ce30eec8cf4ae7 patches egrep/fgrep to point to the location of grep.
> > But the problem is that when it was run on Hurd, the path for grep in egrep/fgrep had this form:
> > /gnu/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-grep-2.25/bin/grep
> >
> > The above was not being substituted and caused the build to fail. So I changed the pattern to
> > "/[^ ]+/bin/grep" and now the path is always replaced.
> >
> > Also (getcwd) returns the current path which the build takes place. This happens to be /tmp/guix-build-..-bootstrap-binaries-0.
> > This is wrong because it should point to the final place in /gnu/store. That why I am using "out".
> 
> Is it still relevant after the work by janneke among many others?  And
> exposed in these blog post [2,3].
> 
> 
> 2: <https://guix.gnu.org/en/blog/2020/a-hello-world-virtual-machine-running-the-hurd/>
> 3: <https://guix.gnu.org/en/blog/2020/childhurds-and-substitutes/>
> 

Judging that the Hurd, aarch64 and powerpc are all have Guix working on
them I assume it's working well enough that we can close this bug.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-01-05  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170223114119.18004-1-manolis837@gmail.com>
2020-11-16 17:59 ` [bug#25848] [PATCH] gnu: %bootstrap-coreutils Jonathan Brielmaier
2022-01-04 23:57 ` [bug#25848] [PATCH] gnu: %bootstrap-coreutils&co: Patch egrep/fgrep to point to the correct grep zimoun
2022-01-05  8:23   ` Efraim Flashner [this message]
2022-01-05  9:00     ` bug#25848: " zimoun
2022-01-05 17:23       ` [bug#25848] " Manolis Ragkousis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdVVdYxpBra1OHye@3900XT \
    --to=efraim@flashner.co.il \
    --cc=25848@debbugs.gnu.org \
    --cc=manolis837@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).