From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EJmlC2HY3WEuIwEAgWs5BA (envelope-from ) for ; Tue, 11 Jan 2022 20:20:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0FrRCGHY3WFFrQAA9RJhRA (envelope-from ) for ; Tue, 11 Jan 2022 20:20:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DB9828C13 for ; Tue, 11 Jan 2022 20:20:00 +0100 (CET) Received: from localhost ([::1]:49326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7MgY-0003md-Vx for larch@yhetil.org; Tue, 11 Jan 2022 14:19:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7MIR-0003SY-2v for guix-patches@gnu.org; Tue, 11 Jan 2022 13:55:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7MIQ-0007aW-OC for guix-patches@gnu.org; Tue, 11 Jan 2022 13:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7MIQ-0004oC-IQ for guix-patches@gnu.org; Tue, 11 Jan 2022 13:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53007] [PATCH] gnu: networking: Add arp-scan Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Jan 2022 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53007 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: manolis837@gmail.com Cc: 53007@debbugs.gnu.org Received: via spool by 53007-submit@debbugs.gnu.org id=B53007.164192727618413 (code B ref 53007); Tue, 11 Jan 2022 18:55:02 +0000 Received: (at 53007) by debbugs.gnu.org; 11 Jan 2022 18:54:36 +0000 Received: from localhost ([127.0.0.1]:55546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7MHx-0004mo-5m for submit@debbugs.gnu.org; Tue, 11 Jan 2022 13:54:36 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:48125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7MHr-0004mF-V3 for 53007@debbugs.gnu.org; Tue, 11 Jan 2022 13:54:32 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A43BF3201DE2; Tue, 11 Jan 2022 13:54:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 11 Jan 2022 13:54:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=SMH3SC4aBCMdi3vLOTA0db5X zpkyzfrxHqSph+m/EEA=; b=PvFEJuM7CB08O7LHlbaDRMlOGSYr4XFvc9Hhzy3x Hns5DXvlxoAde4HxecA4UsNJFQI+5gI5ufowWl2ieHJXk76hBzhOUOZmrXoeZE82 HprLzCskzjdW2/+5LgQtkcbUb904uAUiQojRwRRTrlf4RB0hi8a8CaRciU3ZgbqU Ee8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SMH3SC 4aBCMdi3vLOTA0db5XzpkyzfrxHqSph+m/EEA=; b=myaywsT2Le9zun4JLE9ijn A0s5A7TFCaBWuCDzqQVhcqhRdc2pz4dIeVDP5rQNj6hO8dtrHTUWZAMDvT8mgZX3 7eDx8kxgyB4vyo9VXit2gvLLYqVWCx0JiL/jx0EKiwFCXagf2XcZEob75eUrge7V SEwD7AlEUCvhLMqMpig2c179ZxdSRmWPOxx0irfx3y1K2F1aLKYWsgQ1cmw6m971 3clsrdJfDxsLtvRV6iHX4KU5UlePKTXdbLgL3F1W5tZ4EmcIaJliuJMatoek7u29 wHByA+PQrc1QnSKBdQbYFgPHMC2Q55o7BQD40DhSUN4Sf5xWIZGMJT+/bzQkt/Ew == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeehgfelvefhtddtfeehiedtgfehff ffffelvdelhffgkedtteehgfeugfehgeethfenucffohhmrghinhepghhithhhuhgsrdgt ohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 13:54:20 -0500 (EST) Date: Tue, 11 Jan 2022 13:54:18 -0500 From: Leo Famulari Message-ID: References: <20220104153415.5822-1-manolis837@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220104153415.5822-1-manolis837@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641928800; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SMH3SC4aBCMdi3vLOTA0db5XzpkyzfrxHqSph+m/EEA=; b=JZ9e3kneELiMMhDKJ6ELLKWxGkGTKLMhvPNEJnNWVXvdg8iZ0jh1qxNo40fqi47Fsi3c0R PVpxdWCP0DIxEETrX9ORNDCqNj2XMSpuCosavShZvtW++3PTFwFiR8rCDHwg7GDoEN/pOi URpY0/wwgCN3A2qSoSkbJPM9IGiBrzM1uxxUYBPoEaIvEviiRLVYjpXuJY5ej7PI5XkiYj RtRsJXVILevIuowo9I7VdAJFTYP3ouwOc5eT4EheQ64QIQiUt7iiRjYlSSRggzkGh/pSZb xWg1pSHa5M+HDQgnEPk9P/912sXT7DdVjmXvMJIIx18Fh0yKrmHUMV7owtv4ZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641928800; a=rsa-sha256; cv=none; b=SXNTOAZtAKJaWZFmcCptSYYNgrwkmhphfHrztY9KrydUYxLeHRojJsAaYjyk+C53aPUQ8W UMunBsYyEmphOvXOL2ZJpeXq0q7Ks7+vRdB2HE5jyWWujXnK0tyfrZ15ulkzj8vkE+b9rh i1jUbO3DGIShF7ULpegH+FiZBOYy4rKGhkn5GRDsFUlhj6Qsvcw+/lOnguynqM/+Ow/d0G dhAMXaOeR7PSPbWYcPRchhAIwWQ9ofIsAreAdkzqdrvbFSKjDv1Atv+i1uLaxJJvoYIh40 rTdTi4ttvdylE5HR6v2TNwTeiuULwsYaF5iJR+M0VPMAXo/WgDzVXGGHDFbpMQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=PvFEJuM7; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=myaywsT2; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=PvFEJuM7; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=myaywsT2; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0DB9828C13 X-Spam-Score: -4.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3f3dZq9f+dZI Thanks for the patch! On Tue, Jan 04, 2022 at 05:34:15PM +0200, manolis837@gmail.com wrote: > + (version "1.9.7") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/royhills/arp-scan/" > + "archive/refs/tags/" version ".tar.gz")) This type of tarball is automatically generated by Git / Github based on the Git tag. However, whenever Github updates their software, the generated tarballs may change, invalidating our hash. [0] For that reason, we either use tarballs created by the upstream developers, or the git-fetch method. For this program, the developers stopped making tarballs after version 1.9, so we have to use git-fetch to package 1.9.7. > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-vfi")))))) The bootstrap phase of gnu-build-system runs autoreconf when 'configure' is missing. I'm guessing this package was written before gnu-build-system learned to do that, because the package does build successfully without this replacement. > + (inputs > + (list libpcap)) > + (native-inputs > + (list autoconf automake libtool pkg-config)) > + (propagated-inputs > + (list perl-libwww)) > + (home-page "https://github.com/royhills/arp-scan") > + (synopsis "Dscover and fingerprint IP hosts on the local network using ARP") ^ Typo here --------| > + (description "A tool that uses ARP to discover and fingerprint IP hosts on the local network") Descriptions should be written in "complete" sentences. How about the following? "Arp-scan is a tool that uses ARP to discover and fingerprint IP hosts on the local network." > + (license license:gpl3))) The source headers of 'arp-scan.c' say that the program can be distributed "either version 3 of the License, or (at your option) any later version." So I think it's gpl3+. Can you send a revised patch? [0] https://github.com/libgit2/libgit2/issues/4343