From: Leo Famulari <leo@famulari.name>
To: 47979@debbugs.gnu.org
Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems.
Date: Sun, 26 Dec 2021 15:33:40 -0500 [thread overview]
Message-ID: <YcjRpAVOIMwnax3F@jasmine.lan> (raw)
In-Reply-To: <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On Sun, Dec 26, 2021 at 03:31:30PM -0500, Leo Famulari wrote:
> We had several bug reports with a root cause of "the clock was
> incorrect" from users who used the installer to install a non-graphical
> Guix System.
>
> * gnu/installer/services.scm (%system-services): Add the ntp-service-type.
> * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
> variable.
> (run-services-page): Use run-system-administration-cbt-page when not
> installing a desktop.
> * gnu/installer/tests.scm (choose-services): Add and use a
> choose-misc-service? procedure.
> * gnu/tests/install.scm (installation-target-os-for-gui-tests)<services>: Add
> ntp-service-type.
Here's v6 of this patch series.
With it, the installer successfully installs systems with and without
%desktop-services, and correctly chooses whether or not to offer NTP and
GPM.
It also passes `make check-system TESTS="gui-installed-os"`.
I think it's ready to go.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-26 20:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 18:53 [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems Leo Famulari
2021-04-23 18:56 ` Leo Famulari
2021-04-23 22:45 ` Leo Famulari
2021-04-23 23:20 ` Leo Famulari
2021-04-24 0:56 ` [bug#47979] [PATCH v3] " Leo Famulari
2021-05-02 4:36 ` Leo Famulari
2021-05-02 9:25 ` Mathieu Othacehe
2021-05-02 15:22 ` Leo Famulari
2021-05-21 12:58 ` [bug#47979] [PATCH] " Mathieu Othacehe
2021-05-21 13:37 ` Leo Famulari
2021-05-21 14:21 ` Leo Famulari
2021-05-21 14:26 ` Leo Famulari
2021-05-21 14:39 ` Mathieu Othacehe
2021-05-21 21:01 ` Leo Famulari
2021-05-21 21:44 ` Leo Famulari
2021-06-01 9:49 ` Mathieu Othacehe
2021-12-24 18:04 ` [bug#47979] [PATCH v5] gnu: binutils: Fix CVE-2021-45078 Leo Famulari
2021-12-24 18:04 ` [bug#47979] [PATCH v5 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems Leo Famulari
2021-12-24 18:04 ` [bug#47979] [PATCH v5 2/2] installer: Offer 'gpm-service-type' " Leo Famulari
2021-12-24 18:14 ` [bug#47979] [PATCH v5 1/2] installer: Recommend 'ntp-service-type' " Leo Famulari
2021-12-26 20:31 ` [bug#47979] [PATCH v6 1/3] installer: Offer the CUPS printing service on a dedicated page Leo Famulari
2021-12-26 20:31 ` [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems Leo Famulari
2021-12-26 20:33 ` Leo Famulari [this message]
2021-12-26 21:06 ` Mathieu Othacehe
2021-12-27 0:57 ` Leo Famulari
2021-12-26 20:31 ` [bug#47979] [PATCH v6 3/3] installer: Offer 'gpm-service-type' " Leo Famulari
2021-12-27 22:24 ` [bug#47979] [PATCH v7 1/3] installer: Offer the CUPS printing service on a dedicated page Leo Famulari
2021-12-27 22:24 ` [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems Leo Famulari
2021-12-27 23:53 ` Leo Famulari
2021-12-28 4:54 ` Leo Famulari
2021-12-28 8:27 ` Mathieu Othacehe
2021-12-28 20:34 ` bug#47979: " Leo Famulari
2021-12-27 22:24 ` [bug#47979] [PATCH v7 3/3] installer: Offer 'gpm-service-type' " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcjRpAVOIMwnax3F@jasmine.lan \
--to=leo@famulari.name \
--cc=47979@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).