From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mLkoHFAOxmHAVAAAgWs5BA (envelope-from ) for ; Fri, 24 Dec 2021 19:15:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OL3FF1AOxmEEbgAAB5/wlQ (envelope-from ) for ; Fri, 24 Dec 2021 18:15:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F3A7288B4 for ; Fri, 24 Dec 2021 19:15:44 +0100 (CET) Received: from localhost ([::1]:53630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0p6S-0001XB-Un for larch@yhetil.org; Fri, 24 Dec 2021 13:15:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0p5q-0001VP-S5 for guix-patches@gnu.org; Fri, 24 Dec 2021 13:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0p5q-0003IP-IK for guix-patches@gnu.org; Fri, 24 Dec 2021 13:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0p5q-0005Fv-EX for guix-patches@gnu.org; Fri, 24 Dec 2021 13:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v5 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Cc: Tobias Geerinckx-Rice , Maxim Cournoyer Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164036966820119 (code B ref 47979); Fri, 24 Dec 2021 18:15:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Dec 2021 18:14:28 +0000 Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0p5I-0005EQ-Am for submit@debbugs.gnu.org; Fri, 24 Dec 2021 13:14:28 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:34695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0p5C-0005Dt-JM for 47979@debbugs.gnu.org; Fri, 24 Dec 2021 13:14:23 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id A1E8C32009BB; Fri, 24 Dec 2021 13:14:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 24 Dec 2021 13:14:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=fRYY8zrUOcy9fYvXr4S52cFm YFG4IxUFZkGWCQpFt3E=; b=JtuR/wiLlzOWPyRFw4BwwwUWssyGBOCrxi3TSmGk qmsDh2t/1IIwhiYfw0IGEl8DCuO6OzjCbJ+mdZz0QAgZCgw4xF1ArAf2fjQs12sX dKvdn0dG/wXYk/chZZGzE3SmZaibsYd0EO+i3XjisyJaKD1iHq8Q1rw/wKR2qSNO lv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fRYY8z rUOcy9fYvXr4S52cFmYFG4IxUFZkGWCQpFt3E=; b=HpjFLahK3s6iS2bgUNUwkz DCFGRySojdexyUEBMAer9EaoqTwWh7AEn1YZU9Y5MyH1flP5Lea5PIMCAtv0282S s7Svc6qmtBV0NWtFSz9n3hd9dvlhNiBgkJi46nA/5ZUhM4qWz4VpQ+HhOmHKWASH wZ4h6ucA9L1GG9OjkK1kvguWgAgm/09huz9m6XvUD0nD/9jVPNKcD9wBhvYjN4sB 3VFvZm0wVnLi0CS6OmQGlxA4U6blRh50wh0+e/gllhyTAMGX2zXQlZrCARUImzQC IWhiXpI7cG9vkMLCvQ9ogqZxKU1Gh6hRj/O6EXtjLTEHAS4SlbjTKEaWBvjcUlhg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepffdvleethedtjeevueffgedvheehveevleduheevtddukeduheeggefgiedv vddvnecuffhomhgrihhnpehgnhhurdhorhhgpdhstghmrdhsohenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdr nhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Dec 2021 13:14:15 -0500 (EST) Date: Fri, 24 Dec 2021 13:14:13 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640369744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fRYY8zrUOcy9fYvXr4S52cFmYFG4IxUFZkGWCQpFt3E=; b=AN8Up/HnOVV4ANoCA5rIOFdiVJHG9dve0ERQC8/DkAYQbwA8TIcr+31qSOoZghb6Bfzt7X gVKTx2FpX6tDYEmAYnz1w1aFGO/tuyTyGx9cqZ8uOf+t3qnoN0ytOSnYq8d6UFJ6urN1+0 y4vOtI3v7Y2W4YXx1N+5VDO+XaPhM7YZCOpBIoUeSMVDaIZu7/AvzaOcB5P4nNI2A58D0c 7f1PWYd3JahfCCxVNWdB61sMCTl1gPzsMXIGPTcWkkgMdYwDlLII6y7BWWELo5IRZwSziK ffcaaz0ehLAuBupCdE6uLxz+wBzt/0PTWqwsddQz/8G8rZW4ijltUTcAv75OxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640369744; a=rsa-sha256; cv=none; b=QdDz3FLpMTFpK8+DKLx9GaE/DrNsl8z6RsqHdT3Szvlo5wLH/Zk7Fpf8B1uDUo4bXMmn8m xbIJyiv7e2aBVZn3s4QtqFX1ARJe8vY+LYB6ykxF9W0tbkcXURlPj3Ibp7phYCVnd2s18o 0LXrEdrQAaMbF+5sqFnc3PnZ8G2erAX76dSsRIM7gDdM6pTm09Uu5Siq7VNNfKswcKSnNN eBZBW6Xos2j2Be7Q2nJFao7Z4O/3+bf6AX8rYuoNS40r/s746nKezcwEkVT8rM6sg03D4n 6GIvQzNVregsW0RziLzqN56sUc9XV9WCeGSwg+jM1opGPaA+dMxECLp1jcpGCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="JtuR/wiL"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=HpjFLahK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="JtuR/wiL"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=HpjFLahK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0F3A7288B4 X-Spam-Score: -2.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: yQOeRPsLWNCe On Fri, Dec 24, 2021 at 01:04:40PM -0500, Leo Famulari wrote: > We had several bug reports with a root cause of "the clock was > incorrect" from users who used the installer to install a non-graphical > Guix System. > > * gnu/installer/services.scm (%system-services): Add the ntp-service-type. > * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New > variable. > (run-services-page): Use run-system-administration-cbt-page when not > installing a desktop. > * gnu/installer/tests.scm (choose-services): Add and use a > choose-misc-service? procedure. > * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add > ntp-service-type. This v5 patch series is rebased on current master. It passes `make check-system TESTS="gui-installed-os"`. When a desktop environment is not selected, it adds a page to the installer suggesting NTP, and offering GPM (console mouse). I would have said that it's ready to go, but commit 6f13881f1e92 "installer: Offer the CUPS printing service." also added a page to the installer offering NTP, unconditionally. That is because the run-other-services page that it adds offers all recommended services. https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6f13881f1e92832023caadb3cb51ce393e685e58 However, that breaks the installation, because NTP is provided by %desktop-services, and services may not be duplicated in config.scm. So, we need to adjust the functionality added by 6f13881f1e92. I think we should only offer NTP when the user does not choose any desktops. If you'd like to test these patches, you can follow the steps described previously: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47979#14 I still think we need to ensure that NTP is either enabled or suggested for all installations. I remember the wave of bug reports due to "clock is wrong" after 1.3.0.