From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gOUJJ+asvGG6AgAAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 16:29:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6NOyIuasvGGxHQAAB5/wlQ (envelope-from ) for ; Fri, 17 Dec 2021 15:29:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BE13D885 for ; Fri, 17 Dec 2021 16:29:42 +0100 (CET) Received: from localhost ([::1]:33900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myFAz-0005yV-Cl for larch@yhetil.org; Fri, 17 Dec 2021 10:29:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myF6U-0008KY-Oe for guix-patches@gnu.org; Fri, 17 Dec 2021 10:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myF6U-0003Jb-DZ for guix-patches@gnu.org; Fri, 17 Dec 2021 10:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myF6U-0001C2-AW for guix-patches@gnu.org; Fri, 17 Dec 2021 10:25:02 -0500 Subject: bug#50369: [PATCH] gnu: Add video-contact-sheet Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 17 Dec 2021 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50369 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pradana Adrinusa AUMARS via Guix-patches via Cc: 50369-done@debbugs.gnu.org Mail-Followup-To: 50369@debbugs.gnu.org, leo@famulari.name, paumars@courrier.dev Received: via spool by 50369-done@debbugs.gnu.org id=D50369.16397546604507 (code D ref 50369); Fri, 17 Dec 2021 15:25:02 +0000 Received: (at 50369-done) by debbugs.gnu.org; 17 Dec 2021 15:24:20 +0000 Received: from localhost ([127.0.0.1]:40431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myF5n-0001AX-Db for submit@debbugs.gnu.org; Fri, 17 Dec 2021 10:24:20 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myF5i-0001A4-Bb for 50369-done@debbugs.gnu.org; Fri, 17 Dec 2021 10:24:14 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 42C0B5C01B2; Fri, 17 Dec 2021 10:24:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 17 Dec 2021 10:24:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=7VkxFFyiCDwMDpLuCFmUHtnt VCASXaJWvujC4LvJQ/0=; b=oU+CpD2nfSgdT83OyGBpNr1QYdba1b5uutHchvkR xNo+huYZI42gEQ0LbO0yqT9mquHA/sdZ9IZROt6dPjCkTVgf4qwPu4baXuYb4obo g/xqx4FMcZTvcP2tLZ6UNDlTpczQlASPCB0HTqa/bviuBTHYGyyqha/l4QGIeHu6 NIA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7VkxFF yiCDwMDpLuCFmUHtntVCASXaJWvujC4LvJQ/0=; b=KLXLVUGjEt+XnS3VIqrm40 KYXuG2LXEzFZyWPGimYIBM0VAONBDAoNDT2hiE+mfhXJ8vTln4WoadI5w9VRKh7o EMg65AWrreygHUBW+zqQ0MDj8UCLeyHLZU/6eGPX/ZA1+Hh8VLF2LLy7O5+2jwio 7brDVDTqRG106YRfddLc2bt70b5e4QMnVZ6c9qiC+SkSYKuZWGduO2HxtV5/rFPN a90Ge1E4smtDpEb63wPlxcMcv6VcWOQaMMoVUFI1hUCoQ2abAapjpQwT2xR9QfmS epoq8By0mV/i42jLcpQZiBFdavBLu6FpHPR2gn560LO1FeJ1FKCQV4PnWlCUM37A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrleeigdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepjeehueehheeitedtgfeukefffffhfeehgeelgfehffejhfelhfdvlefhtdelhefg necuffhomhgrihhnpehouhhtlhihvghrrdhnvghtpdhgnhhurdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgr rhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Dec 2021 10:24:08 -0500 (EST) Date: Fri, 17 Dec 2021 10:24:07 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639754982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7VkxFFyiCDwMDpLuCFmUHtntVCASXaJWvujC4LvJQ/0=; b=FNLu0bgPfLkU1ykCUJWur+4nW70MrXz21eXqeqNDqF/KIXfnglMpKEKw86U38toonMRGOI 64AXgSlxlrgemyYV4wCS0oSB7ldCEB1Uv1IfKvszT1oYaQKMnR5/kFb2dr4eom+ykilCwv Qc8esvDHRqmokt5eGfdfXS2jm6Ulmzou1WfVy5euRZ11GxCa7TlFU8NgEp4t4zlQ2MXDOW oyH3XB+Hik8EYxHwElLKTxVlb/PGckG/Lchk38wsGhlprfeldEqTtNR/kvJiJ/DdtYJuRe vu+4jueD4o2LghXlYX3U7YGe/P4J+VuXKZK3JRxesMlnSSbj7GbZxyl60zcgHA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639754982; a=rsa-sha256; cv=none; b=Fq9J5Qvm38wSMAQ14sJtIdaThsWCF7h2e4gK5RNBMmRzGjLp8FXY8lSuLARHxZeUB09LZy mTXFZw5FM69IEPYVpNvnBjvW0r6wI+f1FczRzhLQoI76kxk92LlwufHxyJmRkotfKH56hD JOJr7560bwYH5iEds+f5CxYv38Wqzc175RBDpF+qwlp5ArZD/CA940rJKvzWiEoVitC2Pm Z7183VU9rQKA64Tp9nOHpumfwzmt9aBh5yvXpUa5xLwpNCU6NERTCDlZJTEEKgjNnBd3AQ SFey72G8GjjJEQABvmn4aXvWQ3WPstQDFUa2hDPE2KOoUsihJJky9huI7IU0HA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=oU+CpD2n; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=KLXLVUGj; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=oU+CpD2n; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=KLXLVUGj; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3BE13D885 X-Spam-Score: -3.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: WLu6dFxGtgdL On Sat, Sep 04, 2021 at 11:52:57AM +0200, Pradana Adrinusa AUMARS via Guix-patches via wrote: > From 9851db2b3036ee3d5e8ef85ed8bae2f6398702e0 Mon Sep 17 00:00:00 2001 > From: Pradana AUMARS > Date: Fri, 18 Jun 2021 16:13:07 +0200 > Subject: [PATCH] gnu: Add video-contact-sheet Thank you for packaging this very useful program! And sorry for the long delay in reviewing your contribution. I've pushed your patch as commit 61ae42e773526373f0dc3ca99c7251d20434d3d1 with the following changes: > + (uri (string-append "http://p.outlyer.net/files/vcs/-" version > + ".tar.gz")) This URL was incorrect. This can happen when you first download the source code with `guix download`. Since you will already have the tarball in /gnu/store, Guix will not try to download it again based on the package definition, and you won't notice that the URL is wrong. For that reason, when making new packages I suggest downloading the tarball in another way and then using `guix hash` to get the hash, or using `guix build --source video-contact-sheet --check`. > + (arguments > + `(#:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'build) > + (delete 'check)) > + #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out"))))) > + (inputs > + `(("bash" ,bash) > + ("ffmpeg" ,ffmpeg) > + ("imagemagick" ,imagemagick))) I added a "wrap-program" phase to ensure that the built package will retain its dependencies on ffmpeg and imagemagick. Without this, it did not keep any "references" to those packages, and so they would not be made available when installing video-contact-sheet. You can check these references like this: $ guix gc --references $(guix build video-contact-sheet) /gnu/store/czv41lxhgrmmvbabrqhshxjaj1z3qgvq-ffmpeg-4.4.1 /gnu/store/frs0cv3f6r8frqan91wlm05hm6iwlyn1-bash-minimal-5.1.8 /gnu/store/ph6ikrlflwp240cw9r0sp9zwri9x44sz-imagemagick-6.9.12-4 /gnu/store/rjqgadyzrxdhpr00kwybwyyi7pw7sc1l-video-contact-sheet-1.13.4 I also changed the bash dependency to bash-minimal, which is more suitable for non-interactive use. I partially updated the package to the new style described here: https://guix.gnu.org/en/blog/2021/the-big-change/ > + (synopsis "Bash script to create contact sheets (preview images) from videos") > + (description "This is a bash script meant to create video contact sheets (previews) of videos. > Any video supported by mplayer and ffmpeg can be used. A note of warning: Unlike most similar tools it, > by default, makes screenshots the same size as the video, see the manual for details on how to change > this.") In a follow-up commit, I tweaked the synopsis and description a little bit. I meant to do this in the same commit but forgot to include these changes. > + (license license:lgpl3))) Finally, I changed the license to lgpl2.1+, since that is what is specified in the `vcs` shell script. Thanks again for this patch!