* [bug#51990] [PATCH] gnu: Add emacs-bazel.
@ 2021-11-20 0:14 Brian Kubisiak
2021-11-21 20:30 ` Nicolas Goaziou
2021-11-23 0:27 ` Brian Kubisiak
0 siblings, 2 replies; 4+ messages in thread
From: Brian Kubisiak @ 2021-11-20 0:14 UTC (permalink / raw)
To: 51990
* gnu/packages/emacs-xyz (emacs-bazel): New variable.
Signed-off-by: Brian Kubisiak <brian@kubisiak.com>
---
gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7f895b9321..15d57ad964 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12844,6 +12844,25 @@ (define-public emacs-gn-mode
are common in Chromium-derived projects.")
(license license:bsd-3)))
+(define-public emacs-bazel
+ (package
+ (name "emacs-bazel")
+ (version "20211031.1941")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://melpa.org/packages/bazel-"
+ version ".el"))
+ (sha256
+ (base32 "185wqxcdk5c5d25vla3wgijwqs542dbqwnj47bnh5hvlna2il6ca"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/bazelbuild/emacs-bazel-mode")
+ (synopsis "Bazel support for Emacs")
+ (description
+ "This package provides support for the Bazel build system. See
+@uref{https://bazel.build/} for background on Bazel.")
+ (license license:asl2.0)))
+
(define-public emacs-gntp
(package
(name "emacs-gntp")
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#51990] [PATCH] gnu: Add emacs-bazel.
2021-11-20 0:14 [bug#51990] [PATCH] gnu: Add emacs-bazel Brian Kubisiak
@ 2021-11-21 20:30 ` Nicolas Goaziou
2021-11-23 0:27 ` Brian Kubisiak
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-11-21 20:30 UTC (permalink / raw)
To: Brian Kubisiak; +Cc: 51990
Hello,
Brian Kubisiak <brian@kubisiak.com> writes:
> * gnu/packages/emacs-xyz (emacs-bazel): New variable.
Thank you. Some comments follow.
>
> Signed-off-by: Brian Kubisiak <brian@kubisiak.com>
We don't sign our own commits. So the line above is not necessary.
> +(define-public emacs-bazel
> + (package
> + (name "emacs-bazel")
> + (version "20211031.1941")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/bazel-"
> + version ".el"))
We don't trust MELPA as a reliable source. Could you use git-fetch
instead, and get source files from upstream instead?
Also, the version is "O", according to "Version" keyword in "bazel.el"
file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#51990] [PATCH] gnu: Add emacs-bazel.
2021-11-20 0:14 [bug#51990] [PATCH] gnu: Add emacs-bazel Brian Kubisiak
2021-11-21 20:30 ` Nicolas Goaziou
@ 2021-11-23 0:27 ` Brian Kubisiak
2021-11-23 9:30 ` bug#51990: " Nicolas Goaziou
1 sibling, 1 reply; 4+ messages in thread
From: Brian Kubisiak @ 2021-11-23 0:27 UTC (permalink / raw)
To: 51990
* gnu/packages/emacs-xyz (emacs-bazel): New variable.
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..801f603b5e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12844,6 +12844,30 @@ (define-public emacs-gn-mode
are common in Chromium-derived projects.")
(license license:bsd-3)))
+(define-public emacs-bazel
+ ;; From 2021-11-21.
+ ;; No releases available.
+ (let ((commit "cdb2643dba39fe2bd64ba3b190b94d1ef1d83b18")
+ (revision "0"))
+ (package
+ (name "emacs-bazel")
+ (version (git-version "0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/bazelbuild/emacs-bazel-mode")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0ln06dprnivx9zxm6n23ppyx7x4kbn0f85pxwvkq32aq7wnqz82m"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/bazelbuild/emacs-bazel-mode")
+ (synopsis "Bazel support for Emacs")
+ (description
+ "This package provides support for the Bazel build system. See
+@uref{https://bazel.build/} for background on Bazel.")
+ (license license:asl2.0))))
+
(define-public emacs-gntp
(package
(name "emacs-gntp")
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-23 9:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-20 0:14 [bug#51990] [PATCH] gnu: Add emacs-bazel Brian Kubisiak
2021-11-21 20:30 ` Nicolas Goaziou
2021-11-23 0:27 ` Brian Kubisiak
2021-11-23 9:30 ` bug#51990: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).