From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EPJ1FPjbg2HGRAAAgWs5BA (envelope-from ) for ; Thu, 04 Nov 2021 14:11:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aFMvEPjbg2HBbgAA1q6Kng (envelope-from ) for ; Thu, 04 Nov 2021 13:11:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6C463F10F for ; Thu, 4 Nov 2021 14:11:19 +0100 (CET) Received: from localhost ([::1]:54364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1micWU-0006UF-GF for larch@yhetil.org; Thu, 04 Nov 2021 09:11:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1micRR-0001C0-HA for guix-patches@gnu.org; Thu, 04 Nov 2021 09:06:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1micRO-0000B2-GS for guix-patches@gnu.org; Thu, 04 Nov 2021 09:06:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1micRO-0008C9-3F for guix-patches@gnu.org; Thu, 04 Nov 2021 09:06:02 -0400 Subject: bug#51364: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 04 Nov 2021 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51364-done@debbugs.gnu.org Received: via spool by 51364-done@debbugs.gnu.org id=D51364.163603116031488 (code D ref 51364); Thu, 04 Nov 2021 13:06:01 +0000 Received: (at 51364-done) by debbugs.gnu.org; 4 Nov 2021 13:06:00 +0000 Received: from localhost ([127.0.0.1]:42237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRL-0008Bo-Mh for submit@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:59 -0400 Received: from flashner.co.il ([178.62.234.194]:34812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRJ-0008BZ-RX for 51364-done@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:58 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id C1B46407BF for <51364-done@debbugs.gnu.org>; Thu, 4 Nov 2021 13:05:51 +0000 (UTC) Date: Thu, 4 Nov 2021 15:05:19 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , 51364-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tC9JSoq157iwn7ta" Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636031479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=73tmPQtFDrOVCpBlVJFvcjODtMJ+21tSxpvUpzX2ylo=; b=jwxzdCYF/UHZATobnwHdVOQ7EErnM7KRpwvIbqoVWNxpeEfsqvYYa+h1NbKTNNMXBCi8b3 ySJHdJX9tkRG5XBN17AB6XixoyDUvU4qAerRWQ2MtBvX9Gcb76TU9tJdYjfgqjlIZdOWYy uGBAbKACN8m5JhF6dB8WYDx6Ro3R7ENEEVH23AmhMvB70/plE9sba1jHcsZ9FykoRcqhyJ siqLIQB9svQeTQkaPIS3luHp56lfL1BOjHCBbq3ZkA5+AeioKOvsXHTOZNxeg015MaaHH3 V+xT/mm7xUA/NvEL1wdlbmgGV4TnzmWUj1l49nVgtPM3Z7RuN5Nj6W3dwarbZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636031479; a=rsa-sha256; cv=none; b=t/sU130DV6TQDfRJXg0uSD3tyTWaXMwce7pBeKl85kAu7JWfSQE0rbAm6s7HTY4zIJ5q1g qgkpO7JvcOF0fSGKERm2GeeT6ETaPKYrdQET9AQ2o/4NnBx4hpR0o9S+jCSKxF1OV788Zh KoGLflUVP1V+hzgV9HnOQG5Eh5KMci6omJzNDMH34Uhn7sNVWsv9lFcAIixM2f128GpN0v QDnPfZ/8wKj+W8uonDTOiTZbIysjevfo8IMBlg98dyLElkJPFsR0gNE1aT/fPRv08X2oiQ YURu9p6LUWOrNJHIUld2AbWdDGhNNqtCQcerlD+ct8cGUfYvXG6O6+JfkNcyTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.52 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B6C463F10F X-Spam-Score: -2.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: xo6SECCi5f3I --tC9JSoq157iwn7ta Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 07:13:10PM -0400, Morgan.J.Smith@outlook.com wrote: > From: Morgan Smith >=20 > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) > [inputs]: Add shellcheck. > [arguments]: Add substitute-shellcheck-path phase. > --- >=20 > Sorry for the late reply, I didn't see this in my email. >=20 > People would still have been able to set the variable from their configur= ation. The value I'm editing just determines the default value. However, = I think I came up with a nice solution that should make everyone happy. It= first checks if there is shellcheck in your path and only hard codes the p= ath if you don't have it. Apparently Emacs even re-evaluates defcustoms in= certain situations so this *might* even work if someone installs shellchec= k after this file has been loaded. Looks good to me. Patch pushed. You also might've missed the email because my self-hosted email server sometimes gets blocked. I've added you to X-Debbugs-CC so you should get this email directly. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --tC9JSoq157iwn7ta Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGD2o8ACgkQQarn3Mo9 g1HRcg/8DEepcYsz/5J1aFw4FkpPU9155/wxIQJExcPHy44LZGrUvnDhVFuK5a6m RLDwANkaYSfERfu97NQlHNVk7T1hULm9T74Sns3h3H998NUUR2/FBBaXf0wYd4Wj GC2emy96FIynFwxlNGlDgN2iaikBIt/dt/2IcA/jopDPBSpFOmu5R6uDJbao4zkm Cea4RdkptM3C7wTetH5oZPYnxmAQ55xTupr2hAq0G/Ngp5UJHjdC002ROebu/tYO HkpNoQxks/uXon3TN3by49OWp2dvZXUUFBKOomUNhp6E1MC3qSw7BseJQdSGW64b wGwruPix7bXseJyjSMawsMgrHPbtJg/a/YSHUEE9aSPyWMtARO12NLQogRw3HKuH ABMlXWHTYCB8XdIUxDuu+obYjfL3O6BOHnVoWFiYXXtp3i7/yPxWm1ijGsi3rstF aptD35puMYRcI9sb0K1TjmLO1ACoPma0TFfQEDTbgChQfni7lRT4Oq32kbMdGLEz ZLb1QXdsPJQW9+atE396N9WbMm90FN1jMWveFFBr6ex3IsjIf+rcdUfYb9ViGlQt sBc0bhD1YxtMCjN5qlK/496nVWqcCpATaxh9npvcbvcAX4EvKM3O+Pkg11+w4Vj7 MeDNWPWIiJP3m52y5GQfnRfLa5lwrANP4NR5e0VDLQw4w1+9+JA= =lCPX -----END PGP SIGNATURE----- --tC9JSoq157iwn7ta--