From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OG6wNS2zZGHjMAEAgWs5BA (envelope-from ) for ; Mon, 11 Oct 2021 23:57:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eBE2MS2zZGEkGgAAbx9fmQ (envelope-from ) for ; Mon, 11 Oct 2021 21:57:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C516E3ED for ; Mon, 11 Oct 2021 23:57:01 +0200 (CEST) Received: from localhost ([::1]:48048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ma3I0-0007lA-G3 for larch@yhetil.org; Mon, 11 Oct 2021 17:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ma3HA-0007l1-OQ for guix-patches@gnu.org; Mon, 11 Oct 2021 17:56:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ma3HA-0006fp-GC for guix-patches@gnu.org; Mon, 11 Oct 2021 17:56:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ma3H8-0001rP-Bw for guix-patches@gnu.org; Mon, 11 Oct 2021 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51085] [PATCH v2 6/7] gnu: Add mp3guessenc. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Oct 2021 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51085 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 51085@debbugs.gnu.org Received: via spool by 51085-submit@debbugs.gnu.org id=B51085.16339893127091 (code B ref 51085); Mon, 11 Oct 2021 21:56:02 +0000 Received: (at 51085) by debbugs.gnu.org; 11 Oct 2021 21:55:12 +0000 Received: from localhost ([127.0.0.1]:32943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3GJ-0001qJ-OY for submit@debbugs.gnu.org; Mon, 11 Oct 2021 17:55:11 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3GH-0001q2-VA for 51085@debbugs.gnu.org; Mon, 11 Oct 2021 17:55:10 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 653605C0182; Mon, 11 Oct 2021 17:55:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 11 Oct 2021 17:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Lu+BOqlCK/Z867d90i6f+RHl 8tzRwRjhxnrS1+KnwP0=; b=mtxOQgQ9BXztEjhK039vN5T+gzUHRSI+6mYdMt2j ChiZgIesNezL7/+yFR+Wa6eNveGbv6HgolZ/uD+oREUcSFTfEaaHmAhjDhSnwlBR ua1LRQXXbI+c6gTcxavauIcLLQS/EL6e1cwNfop0mDoOid7ZGejQ32SnGFwPXYiT MmU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Lu+BOq lCK/Z867d90i6f+RHl8tzRwRjhxnrS1+KnwP0=; b=QFPWp7fkF6TZtKD19FUBMG yTuztSNJEN5aoDHqiROrYgZZMbH7UBr2UBmoTForzA+X/ZQE69Fv7ZQIM2aiFW06 UfNxUW5V3iMiL7lZFDOTomhKBhDrJsLKDuLcJLJSrEBO++7SgcZ/PQD4i1rRV7QK 8pwb7NwH0QWXeEZHu1OKML2Q+rsfIcSAxqLvHDk6xmBjNS1INdX4+btW0nCJVz5e oQy4/8V9Arz7AdmfDQA2USRKaZxjQUffvGM9ocd9nmYrECqs0qh9xCgHOtGXpum1 Ot5zgZJofvpuCxDPzHqtl2oauDgJS6dhd3iFUfU7gffwgXzJssxKwdG7keq1d0kg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtjedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Oct 2021 17:55:04 -0400 (EDT) Date: Mon, 11 Oct 2021 17:55:02 -0400 From: Leo Famulari Message-ID: References: <20211009152820.294764-1-monego@posteo.net> <20211009152820.294764-6-monego@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211009152820.294764-6-monego@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633989421; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Lu+BOqlCK/Z867d90i6f+RHl8tzRwRjhxnrS1+KnwP0=; b=uzuPxFvT6yhA8tnjO0NUH7fhVf7wt4qE3Iaa5qATxfH7b3Q9RYhwnb7vyAl/i+I+tOvY26 8BOa1WFSMxxf1tm2aNRkikEMVdB21ol9bNGuB8HO1mwzuq6XR5Q8MY72uM33Pgk/LjVzxt Txi69XqGHR92Z3C06GSdvlAJyMZWhqPT5EfyXsvWq2bIFpHsEivaZu9e75Y6GSlXhKxhD+ B1TRVOFydT4mRRR4iZZdDuUk7rMehQl42S30nkZAIS53vCevgN3nvM2/zWl8YrXF/Be7SS hnQ5e3CgJN6JEhJzzhTKXDjdccVOSG7cvE6s8XVGlQkN0t9V2lTiMNbp2uvSyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633989421; a=rsa-sha256; cv=none; b=KbzYBTTiHu+s4GFelk5fXIHCGPPAt0RcaLWtKLFHZDvLU0JMVixGgR9u696PvqEowBGcLU W1ZT1+qWkO9kgqD8D6UK6D9uT6YrkuKvkyi3ouctxwsXKW2suviqpmoZbCfk+Z2zOiibqP fdLWUGC0sk6tW8iyU+iTP0ni15Qkqqw1RNSJHuMmfOciIfrTXgVCDRwaAX8ZIW6Fv+QaAc WiSpI0Ev/QXvfk785y5vRipOiGA6S/b3fAKAy4pSqM1mLoqDunP0ixZq0x+lVdwBKTOkOv UY09pdhWQwcfsI/65AvCyo5xFWbaFaKA26lYffELPXv/8Hr1yUQ51qIblC3nQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mtxOQgQ9; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=QFPWp7fk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mtxOQgQ9; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=QFPWp7fk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9C516E3ED X-Spam-Score: -1.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: YTG2XVkVvzyZ Thanks for these patches! I've hoped for a Mixxx Guix package for a long time. The patches look good to me overall, but I have a couple questions: On Sat, Oct 09, 2021 at 03:28:19PM +0000, Vinicius Monego wrote: > * gnu/packages/audio.scm (mp3guessenc): New variable. > + (list (string-append "PREFIX=" (assoc-ref %outputs "out")) > + (string-append "SUFFIX=")) What is SUFFIX? That string doesn't appear in the mp3guessenc source code.