unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Vinicius Monego <monego@posteo.net>
Cc: 51085@debbugs.gnu.org
Subject: [bug#51085] [PATCH v2 6/7] gnu: Add mp3guessenc.
Date: Mon, 11 Oct 2021 17:55:02 -0400	[thread overview]
Message-ID: <YWSytqNe3zZ5SKkR@jasmine.lan> (raw)
In-Reply-To: <20211009152820.294764-6-monego@posteo.net>

Thanks for these patches! I've hoped for a Mixxx Guix package for a long
time.

The patches look good to me overall, but I have a couple questions:

On Sat, Oct 09, 2021 at 03:28:19PM +0000, Vinicius Monego wrote:
> * gnu/packages/audio.scm (mp3guessenc): New variable.

> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +             (string-append "SUFFIX="))

What is SUFFIX? That string doesn't appear in the mp3guessenc source
code.




  reply	other threads:[~2021-10-11 21:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 14:27 [bug#51085] [PATCH 0/7] Add Mixxx Vinicius Monego
2021-10-07 14:29 ` [bug#51085] [PATCH 1/7] gnu: Add libkeyfinder Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 2/7] gnu: Add libdjinterop Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 3/7] gnu: opusfile: Add new phase after unpack Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 4/7] gnu: Add libshout-idjc Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 5/7] gnu: Add spscqueue Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 6/7] gnu: Add mp3guessenc Vinicius Monego
2021-10-07 14:29   ` [bug#51085] [PATCH 7/7] gnu: Add mixxx Vinicius Monego
2021-10-09 15:28 ` [bug#51085] [PATCH v2 1/7] gnu: Add libkeyfinder Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 2/7] gnu: Add libdjinterop Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 3/7] gnu: opusfile: Add new phase after unpack Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 4/7] gnu: Add libshout-idjc Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 5/7] gnu: Add spscqueue Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 6/7] gnu: Add mp3guessenc Vinicius Monego
2021-10-11 21:55     ` Leo Famulari [this message]
2021-10-12 22:49       ` Vinicius Monego
2021-10-09 15:28   ` [bug#51085] [PATCH v2 7/7] gnu: Add mixxx Vinicius Monego
2021-10-11 22:04     ` Leo Famulari
2021-10-12 22:54       ` Vinicius Monego
2021-10-16 21:40         ` bug#51085: " Leo Famulari
2021-10-11 17:02 ` [bug#51085] [PATCH 0/7] Add Mixxx Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWSytqNe3zZ5SKkR@jasmine.lan \
    --to=leo@famulari.name \
    --cc=51085@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).