From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wCqrGXYMSWFSJgAAgWs5BA (envelope-from ) for ; Tue, 21 Sep 2021 00:34:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6OJCFXYMSWGuZwAAB5/wlQ (envelope-from ) for ; Mon, 20 Sep 2021 22:34:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 218541132F for ; Tue, 21 Sep 2021 00:34:30 +0200 (CEST) Received: from localhost ([::1]:40690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSRrp-0008IV-9D for larch@yhetil.org; Mon, 20 Sep 2021 18:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSRbx-0008No-1i for guix-patches@gnu.org; Mon, 20 Sep 2021 18:18:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSRbv-0008Bg-00 for guix-patches@gnu.org; Mon, 20 Sep 2021 18:18:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSRbu-0000Sa-T0 for guix-patches@gnu.org; Mon, 20 Sep 2021 18:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49713] [PATCH 3/3] gnu: Add prusa-slicer. Resent-From: Ivan Gankevich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Sep 2021 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49713 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 49713@debbugs.gnu.org Received: via spool by 49713-submit@debbugs.gnu.org id=B49713.16321762751725 (code B ref 49713); Mon, 20 Sep 2021 22:18:02 +0000 Received: (at 49713) by debbugs.gnu.org; 20 Sep 2021 22:17:55 +0000 Received: from localhost ([127.0.0.1]:44228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSRbm-0000Ri-Pm for submit@debbugs.gnu.org; Mon, 20 Sep 2021 18:17:54 -0400 Received: from mail.spbu.ru ([195.70.197.23]:44208 helo=cgp2.pu.ru) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSRbl-0000RL-84 for 49713@debbugs.gnu.org; Mon, 20 Sep 2021 18:17:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=ppb1ksZ2G+QT23sSWujnuLOaUhF4gSvFSvkSH+Z0k2c=; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; b=OAp+E4YNUrM4HeM kjCPwPwdGL/O8fd+Aqk1GwUwNGMhGuO3k+ulKmid74bsfzp1IaF6lF9ww23DiyAmLcQ+iAHlwmkWl zX8B2ooWjTznFb2PrM7yw1+7X4HfSOQWcup/18cDJgxBsXZKM9Yn1LAA6pITgAdwZwkdXwK4KgA8a eZ4+PvrIzQjUq2yf4i7aOOFxdqOgF2wcXRwa6cbZ4wxHXdc7tUNIGy6C4Vdv6+d4LYVG9Rswqm/Q7 yoGm71eEiv3wCV+4sWeufrs+w5J2zAt6KRMHJuC5Kwo66G40xtUDoGKEgYvOH+vjTxSIzKeDPN81G nMPgof08E4XxyuZLbZw== Received: from [172.27.221.159] (account st018947@spbu.ru HELO localhost) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 187015639; Tue, 21 Sep 2021 01:17:47 +0300 Date: Tue, 21 Sep 2021 01:17:46 +0300 From: Ivan Gankevich Message-ID: References: <20210723210801.9458-1-i.gankevich@spbu.ru> <1e440c6a0f9e9e328eb83519e1df38f506a3d4b3.camel@gmail.com> <55e4a71f3756689728238b05fd063662f79ca3d7.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55e4a71f3756689728238b05fd063662f79ca3d7.camel@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632177270; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k546c4+mS2tO1dILkBrmg0XBD9ZIlHlhZCEO2SygFBk=; b=B65X7Cw+PHx0IWLJM1rRtToyDCD/NmTuqH1mX8Y9ce6//Lcw0XriuqiHcNviF1nSIx+XFt M5fxExnDMgLhMI2HEmXRg8LOBjCQurcgiSIsVw3iVFHZgbYfqitcC2zyMFXRKIZWHcO30p fQDFlnyAj6egblsYW6WUgXCYyC8fNO4FT8U1Mw1Gry4VTw/nB4p+QZGT2fmme+HTCHLv7P zP42kpESC3lThWEGnxwmNPSIVW0DOvpVlosfM04w8+K0ij2pz925Oh/yDvX2g2rzslf4kY bFWrvK6DBZHianSU2HUxE2Kj/c5uDEcBrI+f10HAdUtnSrk1kj4gpubMNa26VA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632177270; a=rsa-sha256; cv=none; b=WsibVr9+jDkoUMyAan6acaI711LLz3eXSoGenvKm1VOGIL/iXReb2bvwuyfXE4Vqywy+dL kEklPI4Ducc2tUmqszcdty26dwXisg+8LwfGixgvQbHNsdbr9GOzNvnnxhiy7EBC9dORi+ 023Q+xmdt7KCQ2jAq8DICqpwA2qYIsEhD7/Ewb3EuPFoC5uHfHFI9Uy4vv8DuE2NdDVqD1 dJAiRCWi3Gggq2EIKriDVY2RuEyLG1Cc+uwZg1MezcgiP3IO3K8WGs+e+Gu56sjQ3M6eES rKQrOrNoqwUe4TlowRvd87OPcRbabGO0C8w/tB2V66NmVNe3Mn8C1OtcdrXKLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=OAp+E4YN; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=OAp+E4YN; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 218541132F X-Spam-Score: -0.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: VW1WETY2cpyV >I'd argue that fixing the CMakeLists also falls into snippet territory, >as it's directly related to unbundling. Agreed. Moved the code to the snippet. >Could this be done with substitute* as for the other packages? If not, >we should group those options under a sufficiently explanatory comment. >Also, there's little need to explicitly enable things that would >already be enabled by default, let's keep the list of flags small and >understandable :) Enabled all “low-hanging fruits” and added the comment explaning that these are tests depedencies. >When you send v3, please do all patches in one go and also specify -- >reroll-count, as that's easier on mumi. I hope I did it right :-) Regards, Ivan