From: Ivan Gankevich <i.gankevich@spbu.ru>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 49713@debbugs.gnu.org
Subject: [bug#49713] [PATCH 3/3] gnu: Add prusa-slicer.
Date: Tue, 21 Sep 2021 01:17:46 +0300 [thread overview]
Message-ID: <YUkIitz6vZMa8G0N@surge> (raw)
In-Reply-To: <55e4a71f3756689728238b05fd063662f79ca3d7.camel@gmail.com>
>I'd argue that fixing the CMakeLists also falls into snippet territory,
>as it's directly related to unbundling.
Agreed. Moved the code to the snippet.
>Could this be done with substitute* as for the other packages? If not,
>we should group those options under a sufficiently explanatory comment.
>Also, there's little need to explicitly enable things that would
>already be enabled by default, let's keep the list of flags small and
>understandable :)
Enabled all “low-hanging fruits” and added the comment explaning that
these are tests depedencies.
>When you send v3, please do all patches in one go and also specify --
>reroll-count, as that's easier on mumi.
I hope I did it right :-)
Regards,
Ivan
next prev parent reply other threads:[~2021-09-20 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 21:00 [bug#49713] [PATCH 1/3] gnu: cereal: Use cmake to build and install the library Ivan Gankevich
2021-07-23 21:07 ` [bug#49713] [PATCH 2/3] gnu: Add libigl Ivan Gankevich
2021-09-18 17:17 ` Liliana Marie Prikler
2021-09-19 20:18 ` Ivan Gankevich
2021-07-23 21:08 ` [bug#49713] [PATCH 3/3] gnu: Add prusa-slicer Ivan Gankevich
2021-09-18 17:26 ` Liliana Marie Prikler
2021-09-19 21:39 ` Ivan Gankevich
2021-09-19 21:53 ` Liliana Marie Prikler
2021-09-20 22:17 ` Ivan Gankevich [this message]
2021-09-21 12:12 ` bug#49713: " Liliana Marie Prikler
2021-09-18 15:53 ` [bug#49713] Patches work, how to upstream them phodina via Guix-patches via
2021-09-18 17:13 ` [bug#49713] [PATCH 1/3] gnu: cereal: Use cmake to build and install the library Liliana Marie Prikler
2021-09-19 18:27 ` Ivan Gankevich
2021-09-19 18:26 ` [bug#49713] [PATCH 1/3 v2] " Ivan Gankevich
2021-09-19 20:18 ` [bug#49713] [PATCH 2/3 v2] gnu: Add libigl Ivan Gankevich
2021-09-19 21:38 ` [bug#49713] [PATCH 3/3 v2] gnu: Add prusa-slicer Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 1/3] gnu: cereal: Use cmake to build and install the library Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 2/3] gnu: Add libigl Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 3/3] gnu: Add prusa-slicer Ivan Gankevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUkIitz6vZMa8G0N@surge \
--to=i.gankevich@spbu.ru \
--cc=49713@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).