From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gPSGMY+bR2HHYQAAgWs5BA (envelope-from ) for ; Sun, 19 Sep 2021 22:20:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4EkmLY+bR2HjTQAA1q6Kng (envelope-from ) for ; Sun, 19 Sep 2021 20:20:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B61B1A126 for ; Sun, 19 Sep 2021 22:20:31 +0200 (CEST) Received: from localhost ([::1]:55932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS3Ic-0005VV-8w for larch@yhetil.org; Sun, 19 Sep 2021 16:20:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS3IA-0005Ua-CU for guix-patches@gnu.org; Sun, 19 Sep 2021 16:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS3IA-0000Sg-4f for guix-patches@gnu.org; Sun, 19 Sep 2021 16:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mS3I9-0004Wj-WD for guix-patches@gnu.org; Sun, 19 Sep 2021 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49713] [PATCH 2/3] gnu: Add libigl. Resent-From: Ivan Gankevich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49713 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 49713@debbugs.gnu.org Received: via spool by 49713-submit@debbugs.gnu.org id=B49713.163208274617324 (code B ref 49713); Sun, 19 Sep 2021 20:20:01 +0000 Received: (at 49713) by debbugs.gnu.org; 19 Sep 2021 20:19:06 +0000 Received: from localhost ([127.0.0.1]:40049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS3HF-0004VM-F6 for submit@debbugs.gnu.org; Sun, 19 Sep 2021 16:19:05 -0400 Received: from mail.spbu.ru ([195.70.197.23]:44861 helo=cgp2.pu.ru) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS3HB-0004UW-7x for 49713@debbugs.gnu.org; Sun, 19 Sep 2021 16:19:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=qJ+VddGlatL8TSAcrd++ci0r0Li+dbQY7oA61yS4hYE=; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; b=ZxlRY83TuqQpD7K p7awuYHQKXUI+I/ojXalvBu061wqK5xqSkcPvm2u0hIxFrsSZ9neAAyWOpWA+DM4xaj+WSyq25P4q 6Rs9iX3kHecFwOsYCQ1kZrzmvpGnU26uPrdi64kwulLLZ5//fBsluGuqwIu1p2bBMmNZef7ms7sis MhBS9NR6gAqOeQXZaGUtBDonMzI4w6PBpNrFmeGAtGmMn/45DjloJoTpav6dIHluoZmLpWOxYDCyW JkoVUKFk8v1gQRYphcuLMVFWjVBTcUyna+EzRSQZp7AEwvh3VfcD+zRQqzo9aWZlgCNdqDCmTKya7 GC77a7s9v4v2maYcKGg== Received: from [91.122.31.171] (account st018947@spbu.ru HELO localhost) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 186734934; Sun, 19 Sep 2021 23:18:54 +0300 Date: Sun, 19 Sep 2021 23:18:54 +0300 From: Ivan Gankevich Message-ID: References: <20210723210731.9246-1-i.gankevich@spbu.ru> <60123c258c4a361fec28fb13fed0cde7efa09fa0.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <60123c258c4a361fec28fb13fed0cde7efa09fa0.camel@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632082831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5CWJRoHCipvJs8p5WHtCQ/3y4+uVyqWcrYTeWTe3bU0=; b=EgyogqtByCTpF2XODmvmzz1/KOlrypQ3L4v/g0f6S2ooaIDSosnt3kTv+MbJZTnYEBZ9MS YGAvzX5xeOQdfFlCLMBiBNF8iO61wRUJI1ec9hwS+z/ROG5O3EiGPXD+8uaAufLTw0PyD+ sK9DmEVHy3iU2bVjSl86Z2ctmdl7mfm7bkBv6XmEC5Gf0ksRZxICwacoe25CDyy7kJo3g4 VfoadXQE1+1B7dTgKcIjkwtIL/rjYvpT4CoWOONjBd2U8K/S4WMtPSG+/HPUoJAVr6r0VF /QAwYhpyTOzhenwRNQaHyXG4OV0nTDddPd37PCHwu6M4gV3DZHgr986s1PVK1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632082831; a=rsa-sha256; cv=none; b=DH0sl+BqoYAWAvQ/zIar401AtdN+QMeKlhLlvnT11XMR9F0eG9bg3qFvB/qzL3ncKyNslE 8b+g6KNncDruJxibNk9LgnMbTuQM2xJIl242NF4AxZ/LdKCvJKdExg93rsY/fSMkaJ7c/A aUz7ce26uuOxjr4lmC38CDh9YykY6IDlUE6orB0DC3xX0JcO01zYmbUqaJdgIfP6joz6ZF BEDcVtyiDZv4wX2/UzFja7zcTrVf6nS1XM2BvkF7nQPnJrJW/cAwO2pUCbvHAcjuwc32+e ZlEAQ4bxIslBwkH5CxHJTBsXmZSSmDYfZ7MY2DTdENPljxj93RCNuZusrOYHLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=ZxlRY83T; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=ZxlRY83T; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5B61B1A126 X-Spam-Score: -0.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: Nv9kNOIf2ozS >Can we provide test data as input? I’ve added test data and enabled tests. >> + "-DLIBIGL_BUILD_TUTORIALS=OFF" >> + "-DLIBIGL_EXPORT_TARGETS=ON" >> + "-DLIBIGL_WITH_CGAL=ON" >> + "-DLIBIGL_WITH_COMISO=OFF" >> + "-DLIBIGL_WITH_CORK=OFF" >> + "-DLIBIGL_WITH_EMBREE=OFF" >> + "-DLIBIGL_WITH_MATLAB=OFF" >> + "-DLIBIGL_WITH_MOSEK=OFF" >> + "-DLIBIGL_WITH_OPENGL=OFF" >> + "-DLIBIGL_WITH_OPENGL_GLFW=OFF" >> + "-DLIBIGL_WITH_OPENGL_GLFW_IMGUI=OFF" >> + "-DLIBIGL_WITH_PNG=OFF" >> + "-DLIBIGL_WITH_TETGEN=OFF" >> + "-DLIBIGL_WITH_TRIANGLE=OFF" >> + "-DLIBIGL_WITH_PREDICATES=OFF" >> + "-DLIBIGL_WITH_XML=OFF") >In Guix we prefer to build packages as feature-complete as possible. >Obviously MATLAB won't work unless they also accept octave, but you >might want to at least enable some of the low-hanging fruits such as >XML or OpenGL. If it's about having a minimal package, simply provide >a -minimal variant as well. This library is header-only. All the dependencies from this list are used in the tests. Headers that use these dependencies are installed no matter which dependenies are “ON” in this list. I’ve added XML. Adding other dependencies would require rewriting most of “cmake/libigl.cmake” file, because the authors of the package like to download and build all the dependencies manually. >> + #:tests? #f >Don't leave #:tests? #f uncommented. Enabled tests. >> + (description "The library provides functionality for shape >> modelling, >> +visualization, matrix manipulation.") >s/The/This/ ? Fixed! Thanks for your corrections. I’ve sent the updated version of this patch via “git send-email”. Regards, Ivan