unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 50157@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#50157] [PATCH] gnu: Add xpadneo.
Date: Sun, 22 Aug 2021 14:32:17 +0300	[thread overview]
Message-ID: <YSI1wbaunREc3av6@3900XT> (raw)
In-Reply-To: <5a98ec927846aeebf5c567e94154003fca07b78f.camel@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 3328 bytes --]

On Sun, Aug 22, 2021 at 12:08:57PM +0200, Leo Prikler wrote:
> Am Sonntag, den 22.08.2021, 11:58 +0200 schrieb Maxime Devos:
> > Leo Prikler schreef op zo 22-08-2021 om 00:00 [+0200]:
> > > * gnu/packages/linux.scm (xpadneo): New variable.
> > > ---
> > >  gnu/packages/linux.scm | 52
> > > ++++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 52 insertions(+)
> > > 
> > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> > > index 7b92be4b9c..385cdd558b 100644
> > > --- a/gnu/packages/linux.scm
> > > +++ b/gnu/packages/linux.scm
> > > @@ -1505,6 +1505,58 @@ allows some more serious things like adding
> > > streaming capabilities to an
> > >  application by hooking GStreamer into the loopback device.")
> > >      (license license:gpl2+)))
> > >  
> > > +(define-public xpadneo
> > > +  (package
> > > +    (name "xpadneo")
> > > +    (version "0.9.1")
> > > +    (source (origin
> > > +              (method git-fetch)
> > > +              (uri (git-reference
> > > +                    (url "https://github.com/atar-axis/xpadneo")
> > > +                    (commit (string-append "v" version))))
> > > +              (file-name (git-file-name name version))
> > > +              (sha256
> > > +               (base32
> > > +                "0xr0zx134s56h4ij6c3fh8ki0h58h61minbfxcl3sgpgxkh14
> > > ism"))))
> > > +    (build-system linux-module-build-system)
> > > +    (arguments
> > > +     `(#:tests? #f ; no `check' target
> > > +       #:modules (((guix build copy-build-system) #:prefix copy:)
> > > +                  (guix build linux-module-build-system)
> > > +                  (guix build utils))
> > > +       #:imported-modules
> > > +       ((guix build copy-build-system)
> > > +        ,@%linux-module-build-system-modules)
> > > +       #:phases
> > > +       (modify-phases %standard-phases
> > > +         (replace 'configure
> > > +           (lambda args
> > > +             (with-directory-excursion "hid-xpadneo/src"
> > > +               (apply (assoc-ref %standard-phases 'configure)
> > > args))))
> > > +         (replace 'build
> > > +           (lambda args
> > > +             (with-directory-excursion "hid-xpadneo/src"
> > > +               (apply (assoc-ref %standard-phases 'build) args))))
> > > +         (replace 'install
> > > +           (lambda args
> > > +             (with-directory-excursion "hid-xpadneo/src"
> > > +               (apply (assoc-ref %standard-phases 'install)
> > > args))))
> > 
> > It might be a bit simpler to add a 'chdir' phase:
> > 
> >     (add-after 'unpack 'chdir
> >       (lambda _
> >         (chdir "hid-xpadneo/src")))
> > 
> > instead of these 'with-directory-excursion'.
> That may be true, but in that case there's no "clean" way of exiting. 
> I could do (chdir "..") in post-install, but that feels weird.
> 
> WDYT?
> 

Where is the license file located? You could add a phaes after 'install
to chdir back ".." and then just use install-file for the files for etc.
Then the 'install-license phase would also work correctly.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-08-22 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21 22:00 [bug#50157] [PATCH] gnu: Add xpadneo Leo Prikler
2021-08-22  9:58 ` Maxime Devos
2021-08-22 10:08   ` Leo Prikler
2021-08-22 11:32     ` Efraim Flashner [this message]
2021-08-22 12:03       ` Leo Prikler
2021-08-26 11:10 ` [bug#50157] [PATCH v2 1/2] build-system: linux-module: Support source-directory Leo Prikler
2021-08-26 11:10   ` [bug#50157] [PATCH v2 2/2] gnu: Add xpadneo Leo Prikler
2021-09-14 22:03     ` bug#50157: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSI1wbaunREc3av6@3900XT \
    --to=efraim@flashner.co.il \
    --cc=50157@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).