unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Gankevich <i.gankevich@spbu.ru>
To: Daniel Trujillo Viedma <dtviedma@gmail.com>
Cc: 50052@debbugs.gnu.org
Subject: [bug#50052] [PATCH] Add prusa-slicer
Date: Mon, 16 Aug 2021 10:49:17 +0300	[thread overview]
Message-ID: <YRoYfcpQdPO8FLix@surge> (raw)
In-Reply-To: <e2620c20-2558-6770-266f-a039eed4cf91@gmail.com>

>Hi! I'm Daniel Trujillo,

Hello, Daniel!


>I don't know if these kind of packages are of interest, but this is 
>PrusaSlicer [0], a software to prepare 3D printings (hence I put it in 
>engineering.scm).

I have submitted “prusa-slicer” together with “libigl” on July 23 but did’t get any
response: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49713

We should probably check prior submissions to not duplicate our effort.


>The packaged version, 2.3.3 is the latest stable available at this 
>moment. But this version has as important problem [1]: It cannot be 
>invoked just naming the executable (through $PATH), because then, it 
>can't locate the resources directory. I learned **the hard way** that 
>the fix was applied *after* the release of the 2.3.3 version, so I 
>decided to backport the fix adding a patch because it's a show-stopper 
>to have to type the path to the executable in /gnu/store/... That's 
>the reason why the patch attached to this email contains, not only the 
>additions to engineering.scm, but also a patch that implements the 
>solution in the version 2.3.3 codebase (It's quite simple, it uses a 
>boost function to determine the path to the executable rather than 
>relying on argv[0]).

This issue is fixed by adding “-DSLIC3R_FHS=1” to #:configure-flags.
No need to patch the source code.


>* In order for the above $PATH issue fix to work, it's crucial that 
>the cmake variable SLIC3R_FHS is set to off. This is the default value 
>according to the CMakeLists.txt, but because it's so important, 
>probably it should have been included in the configure-flags argument? 
>Just for clarity.

Set it to ON and you don’t have to patch the code.


>I hope everything is in order, I'm looking forward to see your 
>comments, and hope I can start contributing more packages to Guix!!

Prusa slicer bundles a lot of third-party libraries. Most of them contain
prusa-specific modifications, but some don’t. “libigl”, “eigen” and “hidapi” can be
unbundled, so that we can use versions of these libraries provided by Guix.

>+         ("cereal" ,cereal)

You need to patch “cereal” library definition in order for Prusa slicer to find
this library. I have included this in my patch as well.


Regards,
Ivan




  parent reply	other threads:[~2021-08-16  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com>
2021-08-13 22:58 ` [bug#50052] [PATCH] Add prusa-slicer Daniel Trujillo Viedma
2021-08-15 11:02   ` Xinglu Chen
2021-08-16  7:49   ` Ivan Gankevich [this message]
2021-08-16 20:09     ` Daniel Trujillo Viedma
2021-08-17  7:18       ` Ivan Gankevich
2021-08-17 21:59     ` bug#50052: " Daniel Trujillo Viedma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRoYfcpQdPO8FLix@surge \
    --to=i.gankevich@spbu.ru \
    --cc=50052@debbugs.gnu.org \
    --cc=dtviedma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).