[bug#49659] [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Tue, Jul 20, 2021 at 03:55:49PM +0200, Ludovic Courtès wrote:
> Hi!
> 
> Maxime Devos <maximedevos@telenet.be> skribis:
> 
> > i586-gnu might have the same issue.
> 
> Please add a “Fixes …” line.
> 
> > * gnu/packages/guile.scm
> >   (guile-3.0)[arguments]<#:configure-flags>: Add
> >   "-fexcess-precision=standard" to CFLAGS.
> 
> Nitpick: the first two lines can be joined.  :-)
> 
> >       (substitute-keyword-arguments (package-arguments guile-2.2)
> >         ((#:configure-flags flags ''())
> > -        (let ((flags `(cons "--enable-mini-gmp" ,flags)))
> > +        ;; -fexcess-precision=standard is required when compiling for
> > +        ;; i686-linux, otherwise "numbers.test" will fail.
> > +        (let ((flags `(cons* "CFLAGS=-g -O2 -fexcess-precision=standard"
> > +                              "--enable-mini-gmp" ,flags)))
> 
> Yay!  Questions:
> 
>   1. Should we make it conditional on
>        (or (string-prefix? "i686-" %host-type)
>            (string-prefix? "i586-" %host-type))
>      ?  (I wonder why armhf-linux doesn’t have the same problem.)
> 
> Thoughts?
> 
> Ludo’.
> 

I'd also like to mention that this bug doesn't show up on 32-bit powerpc.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]