[bug#49028] [PATCH] gnu: Add mda-lv2

[bug#49028] [PATCH] gnu: Add mda-lv2

[Thorsten Wilms]

* gnu/packages/audio.scm (mda-lv2): New variable.
---
 gnu/packages/audio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..e352f797da 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,38 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
     (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      ;; Tarball from gitlab lacks waflib directory content, so take it from
+      ;; drobilla.net.
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+    "A port of the MDA VST plugins to LV2. Includes effects and a few
+instruments.")
+   (license (list license:gpl3+ license:gpl3+))))
-- 
2.32.0

[bug#49028] [PATCH] gnu: Add mda-lv2

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

On Mon, Jun 14 2021, Thorsten Wilms wrote:

> +(define-public mda-lv2
> +  (package
> +   (name "mda-lv2")
> +   (version "1.2.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      ;; Tarball from gitlab lacks waflib directory content, so take it from
> +      ;; drobilla.net.
> +      (string-append "http://download.drobilla.net/mda-lv2-"
> +		     version ".tar.bz2"))

The waflib directory is a submodule in the Git repo, something like this
should work (untested):

  (git-reference
    (url "https://gitlab.com/drobilla/mda-lv2")
    (commit (string-append "v" version))
    (recursive? #t))
  
> +     (sha256
> +      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix="
> +			   (assoc-ref %outputs "out")))))
> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://drobilla.net/software/mda-lv2")
> +   (synopsis "Audio plug-in pack for LV2")
> +   (description
> +    "A port of the MDA VST plugins to LV2. Includes effects and a few
> +instruments.")

The description should consist of one or more full sentences, and use
double spaces between sentences.  Maybe something like this:

  MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
  a few instrument plugins.
  
> +   (license (list license:gpl3+ license:gpl3+))))

The two licenses are the same, simply ‘license:gpl3+’ would do.

Could you send an updated patch?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#49028] [PATCH] gnu: Add mda-lv2

[Thorsten Wilms]

I fixed the description and license. I think there’s no need to change
away from the tarball, as it’s actually an official release on the code
author’s domain.

Thanks, Xinglu Chen!


* gnu/packages/audio.scm (mda-lv2): New variable.
---
 gnu/packages/audio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..e352f797da 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,38 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit
samples.") (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      ;; Tarball from gitlab lacks waflib directory content, so take
it from
+      ;; drobilla.net.
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32
"1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+ MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
+a few instrument plugins.
+   (license license:gpl3+)))
-- 
2.32.0

[bug#49028] [PATCH] gnu: Add mda-lv2

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]

On Sun, Jun 20 2021, Thorsten Wilms wrote:

> I fixed the description and license. I think there’s no need to change
> away from the tarball, as it’s actually an official release on the code
> author’s domain.

Fair enough.

> Thanks, Xinglu Chen!

You are welcome!

Note that things that shouldn’t be part of the commit message should be
put below the ‘---’ line.  The subject should also contain “[PATCH v2]”
to reflect that this is the second version of the patch, you can pass
the ‘--reroll-count=2’ to ‘git send-email’.

Also, I am not able to apply the patch, ‘git am’ reports:

  Applying: gnu: Add mda-lv2
  error: corrupt patch at line 12
  error: could not build fake ancestor
  hint: Use 'git am --show-current-patch=diff' to see the failed patch
  Patch failed at 0001 gnu: Add mda-lv2
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am --abort".

Your previous patch did apply cleanly, did you do anything differently?

> +(define-public mda-lv2
> +  (package
> +   (name "mda-lv2")
> +   (version "1.2.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      ;; Tarball from gitlab lacks waflib directory content, so take
> it from
> +      ;; drobilla.net.

This comment isn’t accurate anymore, so there is probably no need for
it.

> +      (string-append "http://download.drobilla.net/mda-lv2-"
> +		     version ".tar.bz2"))
> +     (sha256
> +      (base32
> "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix="
> +			   (assoc-ref %outputs "out")))))
> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://drobilla.net/software/mda-lv2")
> +   (synopsis "Audio plug-in pack for LV2")
> +   (description
> + MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
> +a few instrument plugins.

The description should be put inside double quotes :)

Could you send a v3?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New variable.

[Thorsten Wilms]

---
 gnu/packages/audio.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..22dc71fe50 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,36 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
     (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+    "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and a few
+instrument plugins.")
+   (license license:gpl3+)))
-- 
2.32.0

[bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New variable.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Tue, Jun 22 2021, Thorsten Wilms wrote:

> ---
>  gnu/packages/audio.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

LGTM, apart from the commit summary being a little messed up. :)

I don’t have commit access though, so you will have to wait for someone
else to merge it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#49028: [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New variable.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Thanks. Patch pushed!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]