unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "Florent Pruvost" <florent.pruvost@inria.fr>,
	"Emmanuel Agullo" <emmanuel.agullo@inria.fr>,
	"Ludovic Courtès" <ludovic.courtes@inria.fr>,
	49096@debbugs.gnu.org
Subject: [bug#49096] [PATCH] gnu: petsc: Link against OpenBLAS rather than LAPACK.
Date: Mon, 21 Jun 2021 16:00:43 +0300	[thread overview]
Message-ID: <YNCNe+4pBG+8vMbe@3900XT> (raw)
In-Reply-To: <20210618161204.32542-1-ludo@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2116 bytes --]

On Fri, Jun 18, 2021 at 06:12:04PM +0200, Ludovic Courtès wrote:
> From: Ludovic Courtès <ludovic.courtes@inria.fr>
> 
> OpenBLAS performs better than LAPACK, the reference implementation.
> This is also consistent with the choice of BLAS/LAPACK implementations
> made in most other packages.
> 
> * gnu/packages/maths.scm (petsc)[inputs]: Replace LAPACK by OPENBLAS.
> [arguments]: Pass "--with-openmp=1".
> ---
>  gnu/packages/maths.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Hi!
> 
> Usually there’s no reason to depend on the reference (“Netlib”) BLAS/LAPACK
> implementations because they perform poorly.  This change is one way to
> bring consistency here.
> 
> Thoughts?
> 
> Ludo’.

It sounds reasonable to me.

As long as you're open to thoughts, perhaps we want to have a discussion
(in a new thread) about renaming the input labels for lapack/openblas so
it's easier to do 'guix build foo
--with-inputs=blas=openblas-tuned-for-my-machine'

> 
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index a79d546abd..8d47f91310 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -2417,7 +2417,7 @@ September 2004}")
>       `(("python" ,python-2)))
>      (inputs
>       `(("gfortran" ,gfortran)
> -       ("lapack" ,lapack)
> +       ("openblas" ,openblas)
>         ("superlu" ,superlu)
>         ;; leaving out hdf5 and fftw, as petsc expects them to be built with mpi
>         ;; leaving out opengl, as configuration seems to only be for mac
> @@ -2428,6 +2428,7 @@ September 2004}")
>         #:configure-flags
>         `("--with-mpi=0"
>           "--with-openmp=1"
> +         "--with-openblas=1"
>           "--with-superlu=1")
>         #:make-flags
>         ;; Honor (parallel-job-count) for build.  Do not use --with-make-np,
> -- 
> 2.32.0
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-06-21 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 16:12 [bug#49096] [PATCH] gnu: petsc: Link against OpenBLAS rather than LAPACK Ludovic Courtès
2021-06-21 13:00 ` Efraim Flashner [this message]
2021-06-22  7:29   ` Ludovic Courtès
2021-06-23 12:34     ` zimoun
2021-06-22 15:57   ` bug#49096: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNCNe+4pBG+8vMbe@3900XT \
    --to=efraim@flashner.co.il \
    --cc=49096@debbugs.gnu.org \
    --cc=emmanuel.agullo@inria.fr \
    --cc=florent.pruvost@inria.fr \
    --cc=ludo@gnu.org \
    --cc=ludovic.courtes@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).