unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests.
@ 2021-06-08 13:20 Vinicius Monego
  2021-06-08 13:21 ` [bug#48918] [PATCH 2/2] gnu: python-pyzmq: Update to 22.1.0 Vinicius Monego
  2021-06-08 17:46 ` bug#48918: [PATCH 1/2] gnu: python-pyzmq: Enable tests Leo Famulari
  0 siblings, 2 replies; 3+ messages in thread
From: Vinicius Monego @ 2021-06-08 13:20 UTC (permalink / raw)
  To: 48918; +Cc: Vinicius Monego

* gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
phase to build Cython extensions before tests.
[native-inputs]: Remove python-nose. Add python-cython, python-pytest.
---
 gnu/packages/python-xyz.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9f961756b1..367c75f0f7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9162,14 +9162,18 @@ applications.")
     (arguments
      `(#:configure-flags
        (list (string-append "--zmq=" (assoc-ref %build-inputs "zeromq")))
-       ;; FIXME: You must build pyzmq with 'python setup.py build_ext
-       ;; --inplace' for 'python setup.py test' to work.
-       #:tests? #f))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'build-ext
+           (lambda _
+             ;; Cython extensions have to be built before running the tests.
+             (invoke "python" "setup.py" "build_ext" "--inplace"))))))
     (inputs
      `(("zeromq" ,zeromq)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
-       ("python-nose" ,python-nose)))
+       ("python-cython" ,python-cython)
+       ("python-pytest" ,python-pytest)))
     (home-page "https://github.com/zeromq/pyzmq")
     (synopsis "Python bindings for 0MQ")
     (description
-- 
2.31.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#48918] [PATCH 2/2] gnu: python-pyzmq: Update to 22.1.0.
  2021-06-08 13:20 [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests Vinicius Monego
@ 2021-06-08 13:21 ` Vinicius Monego
  2021-06-08 17:46 ` bug#48918: [PATCH 1/2] gnu: python-pyzmq: Enable tests Leo Famulari
  1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Monego @ 2021-06-08 13:21 UTC (permalink / raw)
  To: 48918; +Cc: Vinicius Monego

* gnu/packages/python-xyz.scm (python-pyzmq): Update to 22.1.0.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 367c75f0f7..89a4d44386 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9151,13 +9151,13 @@ applications.")
 (define-public python-pyzmq
   (package
     (name "python-pyzmq")
-    (version "22.0.3")
+    (version "22.1.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "pyzmq" version))
        (sha256
-        (base32 "0bgrn65cxfz1c1sjrgyq5dy1mkhppxxbizd5wvrl03cq4zhkrxpp"))))
+        (base32 "0pa1y97z75xqyca9xfp9zrzksydbgzsxf8yh0hwp0rgahpfxch3h"))))
     (build-system python-build-system)
     (arguments
      `(#:configure-flags
-- 
2.31.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#48918: [PATCH 1/2] gnu: python-pyzmq: Enable tests.
  2021-06-08 13:20 [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests Vinicius Monego
  2021-06-08 13:21 ` [bug#48918] [PATCH 2/2] gnu: python-pyzmq: Update to 22.1.0 Vinicius Monego
@ 2021-06-08 17:46 ` Leo Famulari
  1 sibling, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2021-06-08 17:46 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 48918-done

On Tue, Jun 08, 2021 at 01:20:29PM +0000, Vinicius Monego wrote:
> * gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
> phase to build Cython extensions before tests.
> [native-inputs]: Remove python-nose. Add python-cython, python-pytest.

Thanks!

I renamed the new phase to 'build-extensions', because we typically try
to avoid abbreviations. They can be confusing to those who are not
fluent in English.

Pushed as 172a0794bb9fe3af77ea459145bf7364b82c5cf2




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-08 17:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 13:20 [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests Vinicius Monego
2021-06-08 13:21 ` [bug#48918] [PATCH 2/2] gnu: python-pyzmq: Update to 22.1.0 Vinicius Monego
2021-06-08 17:46 ` bug#48918: [PATCH 1/2] gnu: python-pyzmq: Enable tests Leo Famulari

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git