unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#47822] [PATCH] gnu: Add r-naturalsort.
@ 2021-04-16 10:57 Roel Janssen
  2021-05-04 15:52 ` Efraim Flashner
  2021-05-04 16:31 ` Leo Famulari
  0 siblings, 2 replies; 4+ messages in thread
From: Roel Janssen @ 2021-04-16 10:57 UTC (permalink / raw)
  To: 47822

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi Guix,

Here's a patch for r-naturalsort.

Also: is it OK to push patches like this ("another" fairly trivial R
package) directly?

Kind regards,
Roel Janssen


[-- Attachment #2: 0001-gnu-Add-r-naturalsort.patch --]
[-- Type: text/x-patch, Size: 1485 bytes --]

From 452a5561d9ab7623d52d0a6625f0199e8ff0e488 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Fri, 16 Apr 2021 12:53:06 +0200
Subject: [PATCH] gnu: Add r-naturalsort.

* gnu/packages/cran.scm (r-naturalsort): New variable.
---
 gnu/packages/cran.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 6f931f06c2..012a734c30 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -25194,6 +25194,25 @@ addition, objects which include the k-d tree search structure can be returned
 to speed up repeated queries of the same set of target points.")
     (license license:bsd-3)))
 
+(define-public r-naturalsort
+  (package
+   (name "r-naturalsort")
+   (version "0.1.3")
+   (source (origin
+            (method url-fetch)
+            (uri (cran-uri "naturalsort" version))
+            (sha256
+             (base32
+              "0mz801y9mzld9ypp3xmsjw2d8l9q97sdnv09wrci9xi3yg2sjf6d"))))
+   (build-system r-build-system)
+   (home-page "https://cran.r-project.org/web/packages/naturalsort/")
+   (synopsis "Natural ordering")
+   (description "This package provides functions related to human natural
+ordering.  It handles adjacent digits in a character sequence as a number
+so that natural sort function arranges a character vector by their numbers,
+not digit characters.")
+   (license license:bsd-3)))
+
 (define-public r-muhaz
   (package
     (name "r-muhaz")
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#47822] [PATCH] gnu: Add r-naturalsort.
  2021-04-16 10:57 [bug#47822] [PATCH] gnu: Add r-naturalsort Roel Janssen
@ 2021-05-04 15:52 ` Efraim Flashner
  2021-05-04 16:31 ` Leo Famulari
  1 sibling, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2021-05-04 15:52 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 47822

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> Hi Guix,
> 
> Here's a patch for r-naturalsort.
> 
> Also: is it OK to push patches like this ("another" fairly trivial R
> package) directly?
> 
> Kind regards,
> Roel Janssen
> 

Probably. Plus it's been 2 weeks.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#47822] [PATCH] gnu: Add r-naturalsort.
  2021-04-16 10:57 [bug#47822] [PATCH] gnu: Add r-naturalsort Roel Janssen
  2021-05-04 15:52 ` Efraim Flashner
@ 2021-05-04 16:31 ` Leo Famulari
  2021-05-04 19:36   ` bug#47822: " Roel Janssen
  1 sibling, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2021-05-04 16:31 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 47822

On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> Here's a patch for r-naturalsort.
> 
> Also: is it OK to push patches like this ("another" fairly trivial R
> package) directly?

Yes. Quoting the manual section Commit Access:

------
For patches that just add a new package, and a simple one, it’s OK to
commit, if you’re confident (which means you successfully built it in a
chroot setup, and have done a reasonable copyright and license
auditing). Likewise for package upgrades, except upgrades that trigger a
lot of rebuilds (for example, upgrading GnuTLS or GLib). 
------

If you aren't feeling confident, just let us know what you'd like
someone else to check for you. Otherwise, feel free to push.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#47822: [PATCH] gnu: Add r-naturalsort.
  2021-05-04 16:31 ` Leo Famulari
@ 2021-05-04 19:36   ` Roel Janssen
  0 siblings, 0 replies; 4+ messages in thread
From: Roel Janssen @ 2021-05-04 19:36 UTC (permalink / raw)
  To: Leo Famulari, Efraim Flashner; +Cc: 47822-done

On Tue, 2021-05-04 at 12:31 -0400, Leo Famulari wrote:
> On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> > Here's a patch for r-naturalsort.
> > 
> > Also: is it OK to push patches like this ("another" fairly trivial
> > R
> > package) directly?
> 
> Yes. Quoting the manual section Commit Access:
> 
> ------
> For patches that just add a new package, and a simple one, it’s OK to
> commit, if you’re confident (which means you successfully built it in
> a
> chroot setup, and have done a reasonable copyright and license
> auditing). Likewise for package upgrades, except upgrades that
> trigger a
> lot of rebuilds (for example, upgrading GnuTLS or GLib). 
> ------
> 
> If you aren't feeling confident, just let us know what you'd like
> someone else to check for you. Otherwise, feel free to push.
> 

Thanks Efraim and Leo.  I pushed this patch in
aa7eeabe9a782afc2535581298990050d16b1895.

I will push trivial patches like these directly from now on.  Please do
let me know if I pushed something that would've benefitted from review.

Kind regards,
Roel Janssen





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-04 19:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 10:57 [bug#47822] [PATCH] gnu: Add r-naturalsort Roel Janssen
2021-05-04 15:52 ` Efraim Flashner
2021-05-04 16:31 ` Leo Famulari
2021-05-04 19:36   ` bug#47822: " Roel Janssen

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git