From: Efraim Flashner <efraim@flashner.co.il>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Xinglu Chen <public@yoctocell.xyz>,
47930@debbugs.gnu.org, Roel Janssen <roel@gnu.org>
Subject: [bug#47930] [PATCH] gnu: Add pbgzip.
Date: Thu, 29 Apr 2021 10:29:44 +0300 [thread overview]
Message-ID: <YIpgaLrbEoiZX7iM@3900XT> (raw)
In-Reply-To: <e926a502496bd2def92b248cd328d2e180dedef4.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Thu, Apr 22, 2021 at 06:40:46PM +0200, Maxime Devos wrote:
> Xinglu Chen schreef op wo 21-04-2021 om 23:45 [+0200]:
> > On Wed, Apr 21 2021, Roel Janssen wrote:
> >
> > > [...]
> > > + (arguments
> > > + `(#:phases
> > > + (modify-phases %standard-phases
> > > + (add-after 'unpack 'autogen
> > > + (lambda _
> > > + (zero? (system* "sh" "autogen.sh")))))))
> >
> > IIRC, phases don’t have to return #t, so you could remove ‘zero?’.
>
> Try running (system* "does-not-exist"). It will fail by returning
> something non-zero. If I recall how to call "invoke" correctly,
> I would recommend (invoke "sh" "autogen.sh") here. "invoke" raises
> an exception when the command fails, instead of returning something.
While we're at it, can this phase replace 'bootstrap? It seems to me we
shouldn't need both phases.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-29 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:26 [bug#47930] [PATCH] gnu: Add pbgzip Roel Janssen
2021-04-21 21:44 ` Xinglu Chen
2021-04-21 21:45 ` Xinglu Chen
2021-04-22 16:40 ` Maxime Devos
2021-04-29 7:29 ` Efraim Flashner [this message]
2021-04-29 12:22 ` Roel Janssen
2021-04-30 8:30 ` Xinglu Chen
2021-04-30 11:48 ` Roel Janssen
2021-04-30 11:53 ` Efraim Flashner
2021-04-30 16:47 ` bug#47930: " Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIpgaLrbEoiZX7iM@3900XT \
--to=efraim@flashner.co.il \
--cc=47930@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=public@yoctocell.xyz \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).