From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0uB9FV4whGDPaAAAgWs5BA (envelope-from ) for ; Sat, 24 Apr 2021 16:51:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SIMaEF4whGBeBwAAB5/wlQ (envelope-from ) for ; Sat, 24 Apr 2021 14:51:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAC1E22F06 for ; Sat, 24 Apr 2021 16:51:09 +0200 (CEST) Received: from localhost ([::1]:56730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laJci-0003ac-Pk for larch@yhetil.org; Sat, 24 Apr 2021 10:51:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laJcc-0003aV-BF for guix-patches@gnu.org; Sat, 24 Apr 2021 10:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laJcc-0000XB-4L for guix-patches@gnu.org; Sat, 24 Apr 2021 10:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1laJcc-0007O9-3C for guix-patches@gnu.org; Sat, 24 Apr 2021 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Apr 2021 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161927583228364 (code B ref 47979); Sat, 24 Apr 2021 14:51:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Apr 2021 14:50:32 +0000 Received: from localhost ([127.0.0.1]:41284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laJc8-0007NP-C1 for submit@debbugs.gnu.org; Sat, 24 Apr 2021 10:50:32 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laJc5-0007NA-Rn for 47979@debbugs.gnu.org; Sat, 24 Apr 2021 10:50:31 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 17BDF1B23; Sat, 24 Apr 2021 10:50:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 24 Apr 2021 10:50:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=TBdTQy4eXOmdNVe48HQ/6/pT puwn+/CJuZWnq9UZM80=; b=Nz82fCNzVAsWLPvNwhtGHXEH66KCmavNKS5h3/NZ b+ZlE63HJIAVxfaGi7fcpsBfs6kfbkKCddGxfIiHh+cUofwp790D1oS/yL2d5Tfu tDcfzBucywcHLpiuEa4g0N961G45m4hRbJqYJqFWV3TnKP/AgGwtQ8S2T7yz/JkH auQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TBdTQy 4eXOmdNVe48HQ/6/pTpuwn+/CJuZWnq9UZM80=; b=ugwfYW+MOOyy04ivqM6mve mf/byAJf+vEdQLhW63rH+inCa0MyxDCoyqzKcLQMP63oca05h7Sra3olXRNpTzc/ 0OcKYqDii0RgX2AqIE0DRriI5a9xT16GTFsK/GcJGIcnfJVj8QX19Me+wMG5VKgI VDIrPy4V6nZhBTJ49dTNYuva7OmHvrh8mplGjTodQRiHm82C3By/L/a6PKrS1CXN ANFeo8vUcyixx95vMEESAuJDPAoLPWoHS5TraWYHJmMsOvvOFYiP0BJLmE/8gJE0 xdf6w1uMzpe9WaDu/XKCZGn+h/F6hQacondEcWcZtwirCuqPU52XuusMP4OPHShw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddugedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvdevgeekudeivdeileduveekuefgue euleehtdffgefftdefkeevleffueefudeknecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 774B9240066 for <47979@debbugs.gnu.org>; Sat, 24 Apr 2021 10:50:22 -0400 (EDT) Date: Fri, 23 Apr 2021 20:56:43 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dHkJjldvz7gEzIKb" Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619275870; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TBdTQy4eXOmdNVe48HQ/6/pTpuwn+/CJuZWnq9UZM80=; b=iM6/W9n/LwIRDKfhdu09bpq5kxjxx3dMnQK37ypcnVy134lcCJkWOUoJmpBHhNjAmfQ+YS vNj1426GUgUw5iEoyzgyOOh0hI7m8Bzdb716DCnE34LEpTlLRB3xnuR0ZnOXVojuc6qo8z fapcfliRlonhUvCSPQdyizTnAy7x/U3QSWxM1gOEudWG4KAZMzbaDLB4kSJ0a/26J5vUQG AHW30OpWl0R7XKsjoyTX9ycg5aN4zGOLsZp5Q+cmu7usfNryGV2ddpZuxU8TzR5KhhUd1L F2ZHaw4A0Ip+jGvUY5hBUVUqotv6CAkQKtXK6YH4cvPySr5F2dYPqAmpgOXXwQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619275870; a=rsa-sha256; cv=none; b=BiAhNXzgAz3kAC7tdNpwH+XsxRs2KQCh/gxALiGcw7XAZLdb1dNQ1uhEbOVHmev+0vc/qZ IbUT6TejAC74xSJcQVvh/Bbz/6EBy3XnJogH+tfagjXpyjhqtd71QkLvTnZN/wH/dAPLhd d62TLz4z0CVL3VrUE5ikC/YYBVHt1alsSe/L0+qj/F8Sr7V0nr1E0XjKo713p43ss/yloE UrHzDv27Nj0aMsjPJxptGaNaorR9NPSSKERct+EBcoe4vCAnK5dGbveKSJcvV6wi49VeKK n2RUHsLNwmKReKOpFTGEo8gKZqQeBrxuawcScv82G21JXef2DnDeOuCWovCOxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=Nz82fCNz; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=ugwfYW+M; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=Nz82fCNz; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=ugwfYW+M; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DAC1E22F06 X-Spam-Score: -3.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: VxITkCeg+CnE --dHkJjldvz7gEzIKb Content-Type: multipart/mixed; boundary="eqwIqxzZxv0Qks4S" Content-Disposition: inline --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote: > ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): (#< name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-service-type)) packages: ()>) With Leo Prikler's help on #guix [0], I got it to work :) I've attached the working patch, as well as a patch to offer the GPM "console mouse" service on non-graphical systems. [0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921 --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-installer-Recommend-ntp-service-type-for-non-graphic.patch" Content-Transfer-Encoding: quoted-printable =46rom 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 14:50:15 -0400 Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphi= cal systems. We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. --- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.= scm index 74f28e41ba..ee003b24b1 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright =A9 2021 Tobias Geerinckx-Rice +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) =20 +(define (run-system-administration-cbt-page) + "Run a page to select various system adminstration services." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Miscellaneous services") + #:info-text (G_ "Select miscellaneous services to run on your system= =2E") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-system-administration-cbt-page)) '())))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..b50bd3e412 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright =A9 2018 Mathieu Othacehe ;;; Copyright =A9 2019 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) =20 + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service, to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) --=20 2.31.1 --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0002-installer-Offer-gpm-service-type-for-non-graphical-s.patch" Content-Transfer-Encoding: quoted-printable =46rom a00274e70d700b9325ad9ab7cd1804d444a5dc37 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 20:42:28 -0400 Subject: [PATCH 2/2] installer: Offer 'gpm-service-type' for non-graphical systems. * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index b50bd3e412..27beb5da66 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) =20 ;; Network connectivity management. (system-service --=20 2.31.1 --eqwIqxzZxv0Qks4S-- --dHkJjldvz7gEzIKb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDbMgACgkQJkb6MLrK fwhyVQ/+I4Z9bPvlS/m9+XhUARgOepoymiLl3ykv4fdS6os5LSqdxDQp5LcaGyrL 1FM1AOUrQZ0rd2ZO0XGpYh/eyvE+edaBP1Bpnd0/LTjzZqCn4z8fQo6xn1O6rDyO MuurlXYMlGivSZtngH0UeEcOi85JQaF6eBVIk9+yH4OCzS/e2HiFQhzmpE032vx8 MLaJ5HycJFrmKmPCB53Zp+rkvjqwRL9S8b51afYp5hABxoGfSX2JkGARRSSfZxRD ARtqvwqCgU3DzB6X7BmWBEa9MU5WWRGSc7wOX2CCPag6A6RbXcTO3rQV8P+xi8SD SkQB7WAlvHTx7ueLsn3SK/OBqKTVgtf98kFTtzBQiNfN4p+NFDPSQ/MpowNAO6NI WhZAQNNE/jMoZBVmOxKBbdDxCJk41K86Vvv4QV/IvXJC03s1eyraM/91cXgTG8+o IVr/q6Vbs3QErrsoZg2E/NVeS6rQaa/8vmiSkzM1+gel66NLBGVZBcOVKQayfc+A ITKcr2fo6tPM3LxnHA/tKn44kFmGNeutGrcjeijHThYGHR1An/d51y1M5vVLaLEI /O/wNigTWVgAhHcmH64Y9zk1SSxJsFS4OzTpBs4CV3xZq8rTL8GXx+g8wux3sgLw /wMBlIJPgHd2KJdeFAUgIpAsHTflmXSa/H0kAbstw5QiV5bCCfI= =U8RK -----END PGP SIGNATURE----- --dHkJjldvz7gEzIKb--