From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6VZsEW0Id2DjWwAAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 17:21:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OIiKCm0Id2D3JwAA1q6Kng (envelope-from ) for ; Wed, 14 Apr 2021 15:21:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 467E7A950 for ; Wed, 14 Apr 2021 17:21:16 +0200 (CEST) Received: from localhost ([::1]:33470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWhKJ-00031X-Ul for larch@yhetil.org; Wed, 14 Apr 2021 11:21:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWhKA-0002yG-Dg for guix-patches@gnu.org; Wed, 14 Apr 2021 11:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWhKA-0006Ku-8d for guix-patches@gnu.org; Wed, 14 Apr 2021 11:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWhKA-0007Cb-4r for guix-patches@gnu.org; Wed, 14 Apr 2021 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47593] [PATCH 6/6] gnu: python-xyz: Add python-abjad. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Apr 2021 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Bonface Munyoki K." Cc: 47593@debbugs.gnu.org, jgart@dismail.de Received: via spool by 47593-submit@debbugs.gnu.org id=B47593.161841362127617 (code B ref 47593); Wed, 14 Apr 2021 15:21:02 +0000 Received: (at 47593) by debbugs.gnu.org; 14 Apr 2021 15:20:21 +0000 Received: from localhost ([127.0.0.1]:35542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWhJJ-0007B6-87 for submit@debbugs.gnu.org; Wed, 14 Apr 2021 11:20:20 -0400 Received: from flashner.co.il ([178.62.234.194]:60828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWhJG-0007AS-Vh for 47593@debbugs.gnu.org; Wed, 14 Apr 2021 11:20:08 -0400 Received: from localhost (unknown [31.210.177.71]) by flashner.co.il (Postfix) with ESMTPSA id 10DE3406C4; Wed, 14 Apr 2021 15:20:00 +0000 (UTC) Date: Wed, 14 Apr 2021 18:19:16 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , "Bonface Munyoki K." , 47593@debbugs.gnu.org, jgart@dismail.de References: <20210404122005.33127-1-me@bonfacemunyoki.com> <20210404122005.33127-7-me@bonfacemunyoki.com> <867dl5oq68.fsf@bonfacemunyoki.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4tQk1EnMec7MDx+N" Content-Disposition: inline In-Reply-To: <867dl5oq68.fsf@bonfacemunyoki.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618413676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=eP8e3QVce/+MTiDwC6foJI/HkvoDJvxKzMXqZ0hA6sw=; b=mLYaPyn2TYttMFe3xLVpN900zJwvgrf2qH+NVk3qNMS3w3fClLPpX1Jwt5kzey5Y1K2zr/ 9VlhQUWwA5HD5/q2TAR0G8Zy2tHijeRHc3DLG9fTO32lB359ba5RGYXc2GKOGOrTNrlt6e SJVWVmr4LyAjY6YJOJO/QDG9UpLFHK2g1a0hczk/OhQaW6m5qpvK4vFZzBaIrx3ilOxvqX FZOBKB9/CuAyWmtbxGlvoEFThKAIe+BX7+njjZHr9f9m+21IF4vuc49yMn6JqN+1tKb8NP SLjS0WIhbYxyWJ6yq5WPxSEI0TyuKVna7+5zudgmAWA/g2TxqoRjQ/RMVtSIJw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618413676; a=rsa-sha256; cv=none; b=Bwd4mCGcsYHdaaz2zvoNQQoKfPAk0WgLP0WFGR2lw9pR0uHX4MG2EYjBFeTL9PB/QJiMHu nkTwhqCyDW+gDy7+9+HvfJSwdz5BoRtkFc926Dv2tyH0RfS5Ybwhe5k097dNrE/QW+JQU2 RXrgANUeTeFc3ByiCeFwKutiUcjJcmamrJcgnk4PZaZRWEkHIg4aUbvcYGWMKcGJTUIhrh +rKhUKwes2j8bnlVJyURttOyk+v9PhbIGyqBicBZwag7UrpX3xriih5SPsoW5VVOI1AKE7 vfFwd4cwZtei8x8BOYCoVIPWcpp6pfpBs4idjDAmUARD7Rrp7RUbuEG4VVqgLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 467E7A950 X-Spam-Score: -4.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3kdqnFpwZSTy --4tQk1EnMec7MDx+N Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 14, 2021 at 12:00:47AM +0300, Bonface Munyoki K. wrote: > Efraim Flashner writes: >=20 > > I would put this in music.scm near lilypond. > > >=20 > Makes sense. >=20 > [...] > > > > If this is a package that would be installed then you can change the > > name to abjad, no need to keep the python prefix. > > >=20 > I don't quite get this. Do you mean a package that > would be installed and run as some executable as > opposed to a library? The first package I can think of is offlineimap. 'guix import pypi offlineimap' tries to name it python-offlineimap, but it's more likely to be used as an actual executable rather than as a library for another package, so we rename it back to offlineimap and put the python packages which would have normally been in propagated-inputs in inputs instead. > >> +(define-public python-abjad > >> + (package > >> + (name "python-abjad") > >> + (version "3.3") > >> + (source > >> + (origin > >> + (method url-fetch) > >> + (uri > >> + (string-append > >> + "https://github.com/Abjad/abjad/archive/refs/tags/v" > >> + version ".tar.gz")) > > > > This should be a pypi URI or be downloaded using git-fetch > > > Noted. >=20 > >> + (sha256 > >> + (base32 > >> + "0dvj40g8kq1jdp09gb2chxxb7959vxv5h4m8ywg4qigsw3f11xnx")))) > >> + (build-system python-build-system) > >> + (arguments > >> + `(#:phases > >> + (modify-phases %standard-phases > >> + (add-after 'unpack 'patch-source > >> + (lambda _ > >> + (substitute* "setup.py" > >> + (("uqbar>=3D0.4.4, <0.5.0") "uqbar>=3D0.4.4, <=3D0.5.1= ") > > > > I would just take off the <0.5.0 and not try to make it just high enough > > to include the version packaged. > > > Makes sense! > >> + (("pytest>=3D5.4.3") "pytest>=3D5.3")) > > > > We also have pytest-6. Of course this is also fine. > > > Sure! > >> + #t)) > >> + (replace 'check > >> + (lambda _ > > > > (lambda* (#:key tests? #:allow-other-keys) > > (when tests? > > > Noted. > >> + ;; See: https://stackoverflow.com/a/34140498 > >> + (invoke "python" "-m" "pytest" "tests") > >> + #t))))) > > > > I'm sure that not all of these need to be propagated. The source should > > be patched to refer to lilypond and I'm guessing most of the rest can > > either be inputs (they'll get wrapped with the python wrapper) or > > native-inputs if they're only needed for tests. > > >=20 > Makes a lot of sense! >=20 > >> + (propagated-inputs > >> + `(("lilypond" ,lilypond) ;; Required for tests to pass! > >> + ("python-black" ,python-black) > >> + ("python-flake8" ,python-flake8) > >> + ("python-isort" ,python-isort) > >> + ("python-mypy" ,python-mypy) > >> + ("python-ply" ,python-ply) > >> + ("python-pytest" ,python-pytest) > >> + ("python-pytest-cov" ,python-pytest-cov) > >> + ("python-quicktions" ,python-quicktions) > >> + ("python-roman" ,python-roman) > >> + ("python-six" ,python-six) > >> + ("python-sphinx-autodoc-typehints" > >> + ,python-sphinx-autodoc-typehints) > >> + ("python-uqbar" ,python-uqbar))) > >> + (home-page "https://abjad.github.io") > >> + (synopsis > >> + "Abjad is a Python API for building LilyPond files.") > > > > I'd shorten this to "Python API for building LilyPind files" > > >=20 > Thanks for the suggestions! >=20 > >> + (description > >> + "Abjad is a Python API for building LilyPond files.") > >> + (license license:expat))) > >> --=20 > >> 2.31.0 > >>=20 > >>=20 > >>=20 > >>=20 >=20 > --=20 > Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F > Humble GNU Emacs User / Bearer of scheme-y parens > Curator: / Twitter: @BonfaceKilz --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --4tQk1EnMec7MDx+N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmB3B/MACgkQQarn3Mo9 g1Ffng/8CdEC6nYnOnA/pMO2nnPHkgzEWeE3guXQMXNzWfGpX9Glb/ZFuXl2B72D fkugxhOpPyyfPKwDUeuFe12M3F7q+tRQDrfE7p/9myyOQpbfJ5g/Wr2CfhiMnQXZ c8CXDtfuHrH0dSRBi6e1/NbyCqo+ITDlwNPD7pzTOm1Jb/eQMzDduJDOT+qJNgpe DmWvPcc+6iCX3fyen2kZYvl22bT2tJIjVyoDokr3rS6/cU2W55/BHbrL/w8OeXK3 8hP0XRJ9UpfAg8Hw/ZIAnpR17kHve1IfVBW0drTeGv1eAzqSTkEPrmESy3tLbYps VFKtaZjhc2Oe52iVnxYhJq/SUHEn6CJgxhlGalwrAR84rEwwJlxa8FaQfCh7DDQS 6Yi6ShdqECW+2h4ZagB3XJsrGU/DEywO+MlIaFmaayKr5O+V50bEsMxtbhUMnGLG BIBe2Vfrg+VsSyYhEc4rMLT/+XgvEHTNA14MnSQxVUCcZwUYXBdZdtzdUWML4IPT WSNCpsXuiCrp44qd+YS31y5L0xag2io7Pt7+9qoc5CiUDuJ0GgGJMSc5lREG/ayk Lc+xWVtIzfweovXbqOJbw9U5i1901AZ7ITuDCEHckPFnKiFrks+yXMrc0V2ee32d JTQXVEPRc/RLQW7Q9/W+JEoIGHmAyDArNwKpu8le8WC659MOgJg= =LtUW -----END PGP SIGNATURE----- --4tQk1EnMec7MDx+N--