From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CBUXK4QHd2DqVAAAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 17:17:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cFInJYQHd2DEWwAAbx9fmQ (envelope-from ) for ; Wed, 14 Apr 2021 15:17:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D32F12E33 for ; Wed, 14 Apr 2021 17:17:24 +0200 (CEST) Received: from localhost ([::1]:54964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWhGc-0007lE-Gl for larch@yhetil.org; Wed, 14 Apr 2021 11:17:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWhFP-0007kB-7y for guix-patches@gnu.org; Wed, 14 Apr 2021 11:16:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWhFK-0004rI-LI for guix-patches@gnu.org; Wed, 14 Apr 2021 11:16:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWhFK-0005sT-Gi for guix-patches@gnu.org; Wed, 14 Apr 2021 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47593] [PATCH 3/6] gnu: python-xyz: Add python-uqbar. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Apr 2021 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Bonface Munyoki K." Cc: 47593@debbugs.gnu.org, jgart@dismail.de Received: via spool by 47593-submit@debbugs.gnu.org id=B47593.161841335522142 (code B ref 47593); Wed, 14 Apr 2021 15:16:02 +0000 Received: (at 47593) by debbugs.gnu.org; 14 Apr 2021 15:15:55 +0000 Received: from localhost ([127.0.0.1]:35530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWhFC-0005kc-QI for submit@debbugs.gnu.org; Wed, 14 Apr 2021 11:15:55 -0400 Received: from flashner.co.il ([178.62.234.194]:60800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWhF8-0005c7-R6 for 47593@debbugs.gnu.org; Wed, 14 Apr 2021 11:15:53 -0400 Received: from localhost (unknown [31.210.177.71]) by flashner.co.il (Postfix) with ESMTPSA id 542C7406C4; Wed, 14 Apr 2021 15:15:42 +0000 (UTC) Date: Wed, 14 Apr 2021 18:14:56 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , "Bonface Munyoki K." , 47593@debbugs.gnu.org, jgart@dismail.de References: <20210404122005.33127-1-me@bonfacemunyoki.com> <20210404122005.33127-4-me@bonfacemunyoki.com> <86fsztoqkg.fsf@bonfacemunyoki.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="znoDBA4DkUZqQdX9" Content-Disposition: inline In-Reply-To: <86fsztoqkg.fsf@bonfacemunyoki.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618413444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=a+Abzl7ST2YcdynJZvIW7slgFGtJ1v4l15fB4TsJONk=; b=TZoutj5BeHjTWYx9irQazDGEmStSzEtzoO9PfL7xb6C1GU1DMNdDyiP66GZPGdx76nSXaR k+2TmvO97UEXc/c83y0hPfOqiXrFhqgnNwDBujQykmySvdZRO9TTN8gRpZa4U9iaWfh+Pg cqkSmFbXA3gQX75o8S058KnmTAXL3ttFsJGfSa3V1oXRf7VEANoa7oaFEIU1guxHTV7D7x ug6z5M+SicvuYTaCXYDjAaCNdq1pmwwbITxR/XSNFcgT3GO/ib5fCtMN2MYq7pB5ouzEaZ liH1IcLPcIv4YD8JV7GG8Tfyn+WV8nDMH//BJpBPboK8Fk5yNwbyOBPXwTJhfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618413444; a=rsa-sha256; cv=none; b=LsIqC1Rurp1QlZRvtJpztbngc2Rn0PwmicAVfmjLhiFMddsDhaq01U9qMvM5fbjDMQqxHq 8489brI03DHfsDrZYxFU+adGBVqcz8ZUjPs0M/wChV6yCKyzDe1V0vDQ4hNMVOmEPMOTey iWnPHj2t21gN0sVnifLFHK/2LNIlKdczi4CdOiiBGw7+bJELhZ3yTa0bgYin7K6bNTgCRg DUj7aLJRDqoHNhtZjD9c7LpvJpZiTiLsFfOi5IxJ8j+RFc+81mUNCVKH/od4QegXujli9q jvaQgVHewvFwkvDwoV9dheXNIIKjXf6NshaBd7ATN3b9OVgIuiQM5P6weBGBrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0D32F12E33 X-Spam-Score: -4.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2HjP/CFdLjP0 --znoDBA4DkUZqQdX9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 13, 2021 at 11:52:15PM +0300, Bonface Munyoki K. wrote: > Efraim Flashner writes: >=20 > > I haven't tried building this package yet. The sphinx packages are in > > sphinx.scm and the graphviz packages are in graphviz.scm. I think I > > would put it in graphviz. > > >=20 > Now that you've pointed it out, I see it! That > makes sense. >=20 > [...] >=20 > > guix lint should've caught this. >=20 > I seem to have skipped doing this. I need to find > a way to integrating "guix lint" to my Emacs > workflow since I seem to always somehow forget to > do this. >=20 > > If the pypi version from 'guix import > > ppyi uqbar' doesn't work for building then you should use git-fetch to > > download the source. The github archive URLs tend to get regenerated > > from time to time. >=20 > I went with the GitHub version since the pypi version > doesn't have tests. So in such cases, is it still > preferable to use the pypi version? In that case the git version is normally preferable so we can actually run the tests, but it should use git-fetch to download the sources. > >> + (sha256 > >> + (base32 > >> + "02kfvwh94ca0y3hsfrc071ga3g3vqflhyv4w4hif34dyj2skvpa8")))) > >> + (build-system python-build-system) > >> + (arguments > >> + `(#:phases > >> + (modify-phases %standard-phases > >> + (add-after 'unpack 'patch > >> + (lambda _ > >> + (substitute* "setup.py" > >> + ;; Latest versions of sphink-rtd-theme require npm to = build. > >> + (("sphinx-rtd-theme >=3D 0.4.0") "sphinx-rtd-theme >= =3D 0.2.4") > >> + (("black =3D=3D 19.10b0") "black >=3D 19.10b0")) > >> + #t)) > >> + (replace 'check > >> + (lambda _ > >> + (invoke "python" "-m" "pytest" "tests") > > > > We want the ability to skip the tests, so this should be > > (lambda* (#:key tests? #:allow-other-keys) > > (when tests? > > (invoke ... > > >=20 > Never knew this! Learnt something new. Thanks! >=20 > >> + #t))))) > >> + (propagated-inputs > >> + `(("graphviz" ,graphviz) > > > > Is it possible to substitute the actual calls to the graphviz binaries > > in the package? >=20 > Not really. However... >=20 > > We don't want to have to propagate non-python packages. > > >=20 > ... We could add the graphviz to native > inputs since it's only required at build-time when > running one of the tests. >=20 > >> + ("python-black" ,python-black) > >> + ("python-sphinx" ,python-sphinx) > >> + ("python-sphinx-rtd-theme" > >> + ,python-sphinx-rtd-theme) > >> + ("python-unidecode" ,python-unidecode))) > >> + (native-inputs > >> + `(("python-flake8" ,python-flake8) > >> + ("python-isort" ,python-isort) > >> + ("python-mypy" ,python-mypy) > >> + ("python-pytest" ,python-pytest) > >> + ("python-pytest-cov" ,python-pytest-cov))) > >> + (home-page > >> + "https://github.com/josiah-wolf-oberholtzer/uqbar") > >> + (synopsis > >> + "Tools for building documentation with Sphinx, Graphviz and LaTe= X") > >> + (description > >> + "Tools for building documentation with Sphinx, Graphviz and LaTe= X") > > > > This should be a full sentence. > > >=20 > Noted :) > >> + (license license:expat))) > >> --=20 > >> 2.31.0 > >>=20 > >>=20 > >>=20 > >>=20 >=20 > --=20 > Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F > Humble GNU Emacs User / Bearer of scheme-y parens > Curator: / Twitter: @BonfaceKilz --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --znoDBA4DkUZqQdX9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmB3BvAACgkQQarn3Mo9 g1EO2RAApdyVmIoEV8x0rIZHnxHGiFhQPYBDXYTivL6gcjyza4y3jl6fgAyqMSx8 jIA/EMip+pfYswtX115pcUd2oJ7b6/r7LwvZWlDSr24ozrmfsS28gU9tzizs6tBl ik4kKyOB5wBwmD5VIT69l6zJEM1ORkF7ymMsP4mWNe2VU5pG+zNPhKkUJCYtGrId yF2ErzMnrRHtdloJ9/Xi61KTZZ6pnU8E0ljaExcF936E+sHFcJaTm+89Ei4kMB0W QqJRjFgN3UeFiWcspxEcOL6uqOqj61qrstrMhXBDT3YJ3i+EfpXhNZwK750vjpAC LU//TeFdmlbf8jaz98FEQAmRto52tbN6rv5JYX4+qmeI0DjIPspx6Iekxuysvsmd ydWhPYHcY9xM7pwkiavjuSp/CDGX+n/YdkU9tX0zRn2rYSwHzrkIYX7fBY8n+F91 LzVCTAl9IwIPIaRp9C8qyy6CuVtFbPhdGi8AiS3UIOi3gwTUZ2PAZbJ2sl4kP2d3 T+7pPvqhXDBZVx6QetDFTIBnE0Zr52Yvy5bg8I3flEpgcg8z9dh7pMAdrdQizxC1 mZVF86RVcZ+uWD8fusN8Cl1/oLbYtYfae1DxD8H2SyLqOvfIWC9TXwicDsW8JHyx BaV/+Ls31XigdjpNXIGBmhV2TpSlwg9StYpGBtMijjPSQYNI0EU= =/4Wx -----END PGP SIGNATURE----- --znoDBA4DkUZqQdX9--