unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: BonfaceKilz <me@bonfacemunyoki.com>
Cc: 47593@debbugs.gnu.org, jgart@dismail.de
Subject: [bug#47593] [PATCH 5/6] gnu: python-xyz: Add python-quicktions.
Date: Tue, 13 Apr 2021 16:14:41 +0300	[thread overview]
Message-ID: <YHWZQf+xdb0BXp4e@3900XT> (raw)
In-Reply-To: <20210404122005.33127-6-me@bonfacemunyoki.com>

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

On Sun, Apr 04, 2021 at 03:20:04PM +0300, BonfaceKilz wrote:
> * gnu/packages/python-xyz.scm (python-quicktions): New variable.
> 
> Co-authored-by: jgart <jgart@dismail.de>
> ---
>  gnu/packages/python-xyz.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 8ecf5dadc2..e87ba6b6b6 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -24336,3 +24336,23 @@ iGoogle subscription lists.")
>      (description
>       "File support for setuptools declarative setup.cfg")
>      (license license:asl2.0)))
> +
> +(define-public python-quicktions
> +  (package
> +    (name "python-quicktions")
> +    (version "1.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "quicktions" version))
> +       (sha256
> +        (base32
> +         "1px21a6x527i1bsr2p6bbf3jziqpvd1vjkvvzh13gsy4iip0yvzn"))))
> +    (build-system python-build-system)
> +    (home-page
> +     "https://github.com/scoder/quicktions")
> +    (synopsis
> +     "Fast fractions data type for rational numbers. Cythonized version of 'fractions.Fraction'.")

I'd trim this to 'Fast fractions data type for rational numbers'

> +    (description
> +     "Fast fractions data type for rational numbers. Cythonized version of 'fractions.Fraction'.")

And this I'd change to 'This package provides fast fractions data type
for rational numbers.  It is the cythonized version of
@quote{fractions.Fraction}.'

> +    (license license:psfl)))
> -- 
> 2.31.0
> 

Speaking of cython, you should add a snippet to the source to remove any
cythionized source and make sure those files get rebuilt during the
build phase. Looking at setup.py it looks like you should remove
src/quictions.c and I think it tries to cythonize automatically.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-04-13 13:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 12:16 [bug#47593] [PATCH 0/6] *** Add Python Abjad v3.3 *** BonfaceKilz
2021-04-04 12:19 ` BonfaceKilz
2021-04-04 12:20   ` [bug#47593] [PATCH 1/6] gnu: python-xyz: Add python-roman BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:12       ` Bonface Munyoki K.
2021-04-04 12:20   ` [bug#47593] [PATCH 2/6] gnu: python-check: Add python-pytest-helpers-namespace BonfaceKilz
2021-04-04 12:20   ` [bug#47593] [PATCH 3/6] gnu: python-xyz: Add python-uqbar BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:52       ` Bonface Munyoki K.
2021-04-14 15:14         ` Efraim Flashner
2021-04-04 12:20   ` [bug#47593] [PATCH 4/6] gnu: python-xyz: Add python-setuptools-declarative-requirements BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:53       ` Bonface Munyoki K.
2021-04-04 12:20   ` [bug#47593] [PATCH 5/6] gnu: python-xyz: Add python-quicktions BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner [this message]
2021-04-13 21:10       ` Bonface Munyoki K.
2021-04-14 15:17         ` Efraim Flashner
2021-04-04 12:20   ` [bug#47593] [PATCH 6/6] gnu: python-xyz: Add python-abjad BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 21:00       ` Bonface Munyoki K.
2021-04-14 15:19         ` Efraim Flashner
2021-04-14 20:54 ` [bug#47593] [PATCH v2 0/6] " BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 1/6] gnu: Add python-roman BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 2/6] gnu: Add python-setuptools-declarative-requirements BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 3/6] gnu: Add python-pytest-helpers-namespace BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 4/6] gnu: Add python-uqbar BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 5/6] gnu: Add python-quicktions BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 6/6] gnu: Add abjad BonfaceKilz
2021-04-15 11:35   ` bug#47593: [PATCH v2 0/6] gnu: python-xyz: Add python-abjad Efraim Flashner
2021-04-15 13:32     ` [bug#47593] " Bonface Munyoki K.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHWZQf+xdb0BXp4e@3900XT \
    --to=efraim@flashner.co.il \
    --cc=47593@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=me@bonfacemunyoki.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).