From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eHGFNur6aWBaNAAAgWs5BA (envelope-from ) for ; Sun, 04 Apr 2021 19:44:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WCxpMOr6aWDZMgAAbx9fmQ (envelope-from ) for ; Sun, 04 Apr 2021 17:44:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AB9823473 for ; Sun, 4 Apr 2021 19:44:10 +0200 (CEST) Received: from localhost ([::1]:33454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT6nB-0005xy-OM for larch@yhetil.org; Sun, 04 Apr 2021 13:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT6n4-0005xf-Sa for guix-patches@gnu.org; Sun, 04 Apr 2021 13:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT6n4-0004iW-Ke for guix-patches@gnu.org; Sun, 04 Apr 2021 13:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT6n4-0002AU-I7 for guix-patches@gnu.org; Sun, 04 Apr 2021 13:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47591] [PATCH] import: go: Replace underscores with hyphens in package names. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Apr 2021 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 47591@debbugs.gnu.org Received: via spool by 47591-submit@debbugs.gnu.org id=B47591.16175582358314 (code B ref 47591); Sun, 04 Apr 2021 17:44:02 +0000 Received: (at 47591) by debbugs.gnu.org; 4 Apr 2021 17:43:55 +0000 Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT6mx-0002A2-CJ for submit@debbugs.gnu.org; Sun, 04 Apr 2021 13:43:55 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT6mv-00029o-3Z for 47591@debbugs.gnu.org; Sun, 04 Apr 2021 13:43:54 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DF4815C00BA; Sun, 4 Apr 2021 13:43:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 04 Apr 2021 13:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=WtmbRDhgRV46AO4nJAQgrb9R PQ2zqYmnkwdJmbKiPtk=; b=crd79ka+eEr0A18TH8cKoM6BJRTZyaLr4ZHQdhJi Qc+BpKw5sr+Nz6phm6EQueKE5YriRlMC43VQcQ2JEHakYPeb6KapihnaciQzQxz6 Ls/UbjvhqaDt2D76Zkd53hvGRKlXUtByF1GHbBhgdAKd31iMD6fRy6k/evdjL70N m6Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=WtmbRD hgRV46AO4nJAQgrb9RPQ2zqYmnkwdJmbKiPtk=; b=vjgPZhgJWLEkaSntR3cZYR 8Z+zO0RcYzWwJ42CkrAHSFS3rRNauqEJAXKs0hq+ICCCIMyCEvhEsKqE5HtPlaWP ticy3z0i+u+QVXz+nre5HPwdaftlSXXMqdyAVasYUEgFbwtSJPId7fl/uZCm+rW1 CWvcZCAQ6XBjW9FaV2sWiokFr665w0cAdo8x+6ETsaYwJXxG3yYJ2BV8/iv8NNdz xeP1omLodDb3rOKFNkmnpfz6ac3Zd2QTUFMb2eOuvludadGsxleuOLi5GRIkOvdI GOWs64duoEHpqmW9viLgQTKBAMl5wAvrUfDWPoSbuVFps8IVP37CrhuNB8fpEEMQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejtddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucfkphepuddttddruddurdduieelrddu udeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F25D108005C; Sun, 4 Apr 2021 13:43:47 -0400 (EDT) Date: Sun, 4 Apr 2021 13:43:45 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617558250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WtmbRDhgRV46AO4nJAQgrb9RPQ2zqYmnkwdJmbKiPtk=; b=qOeiZWb8RB7AnYVNsLGtQ3BvxzFPYhDCR2xkDfHgH3QP9Soy4uJSYWiOVxwq51qt3P+zBO 1uWZ1dNiHMR9B/QVe4j9ATGvFc3DTLuljAZKCHiFZP1iY0WmHPXOgI95pOQk6NHeIDpXRN RxkGzzTlS7tX+5a6gFWZ7Pqx/0j89HbM8y4EesHhW15Awt9pRGLZ3NXqiJne057CBpC6x4 Zcz7l2Po7CjO7pu4SYdgKcNVlVOv+GA6dAjaebvbGhgbCxCTRD/c8wR2sEmlspJholf5n0 AXIi69hZzZQVzzugZ0MlOK7PfcYLv6ZAUhx+GmrUY2lY4ieTmQ/7cC7paI2Pkg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617558250; a=rsa-sha256; cv=none; b=FAL7ac6lskemmbF8Nrpu81HDRaTiQFW4e4MHdzmqIPdKIxuu7jhQ5roUXkJTpvc516P77T Xxd+u5xCmTq1sxUwqJjfFWxFvFeHkuDengrDciM/cwdnDgoKIIWRz+j5EkrTMdhmxXfcfa 2t10OIBHZHnWwPDwg9l2hwfFN2TCfyxXY6xXlf0EGNsaM30G25GYK5wIpYEI96oRJyVZyA gi+1GC7bXHnmFMQRNRNK0+iZUBVBoUYkZoK0rOt1i0Umv96InYmBptIlTSuRJ7DyNIZp7s PBD2EXNLNlV4K+Ef9/kX935gsuH1j0zbcDSiu20RWbNHlNwqoSeP3UbBy6AQCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=crd79ka+; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=vjgPZhgJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=crd79ka+; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=vjgPZhgJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8AB9823473 X-Spam-Score: -1.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: SGvaXaumkjcu On Sun, Apr 04, 2021 at 11:52:03AM +0200, Xinglu Chen wrote: > As per section '16.4.2 Package Naming' in the manual, use hypens instead > of underscores in package names. > > * guix/import/go.scm (go-module->guix-package-name): Replace underscores > with hyphens. Thanks! Pushed as 426ade6c8bdab243da719e369a887284368179bb > Maybe we should also make the linter check for underscores in package > names, and give a warning if it finds any underscores? Definitely! I would leave existing packages alone, however, unless they are causing some problem.