unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: Leo Le Bouter <lle-bout@zaclys.net>, 47182@debbugs.gnu.org
Subject: [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master)
Date: Thu, 18 Mar 2021 10:34:09 +0200	[thread overview]
Message-ID: <YFMQgRR9Ub1Prdlo@3900XT> (raw)
In-Reply-To: <87h7l9m1g8.fsf_-_@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

On Wed, Mar 17, 2021 at 11:16:07PM -0700, Chris Marusich wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> >>        #:tests? ,(let ((s (or (%current-target-system)
> >>                               (%current-system))))
> >>                    (not (or (string-prefix? "aarch64" s)
> >> -                           (string-prefix? "mips64" s))))
> >> +                           (string-prefix? "mips64" s)
> >> +                           (string-prefix? "powerpc64le" s))))
> >> +
> >
> > we can probably change this to use cute in core-updates. I don't know if
> > changing it here will cause rebuilds on aarch64.
> 
> The result of unquoting the expression will be either #t or #f,
> depending on the system.  For an aarch64 system, the string s hasn't
> changed (it'll still start with "aarch64", right?).  Therefore, my
> understanding is that this change here will not alter the package
> definition; it will still say "#:tests? #f", just like it did before, on
> an aarch64 system.  Is there something else I'm missing?
> 

I like the way it looks better if we use something like

#:tests? ,(if (any (cute string-prefix? <> (or (%current-target-system)
                                               (%current-system)))
                   '("aarch64" "powerpc64le" "mips64"))
            '#f '#t)

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-18  8:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  6:28 [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) Chris Marusich
2021-03-16  6:44 ` [bug#47182] [PATCH 01/18] gnu: bootstrap: Add support for powerpc64le-linux Chris Marusich
2021-03-16  6:44   ` [bug#47182] [PATCH 02/18] utils: Add target-powerpc? procedure Chris Marusich
2021-03-16  6:44   ` [bug#47182] [PATCH 03/18] gnu: gcc-4.7: On powerpc64le, fix /lib64 references Chris Marusich
2021-03-16  6:44   ` [bug#47182] [PATCH 04/18] gnu: glibc: Fix ldd path on powerpc* Chris Marusich
2021-03-16  7:45     ` Efraim Flashner
2021-03-16  6:44   ` [bug#47182] [PATCH 05/18] gnu: gcc-boot0: Enable 128-bit long double for POWER9 Chris Marusich
2021-03-16  6:44   ` [bug#47182] [PATCH 06/18] gnu: binutils-final: Provide bash for binary on powerpc-linux Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 07/18] gnu: binutils-final: Support more Power architectures Chris Marusich
2021-03-16  7:49     ` Efraim Flashner
2021-03-18  6:10       ` [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) Chris Marusich
2021-03-18  8:29         ` Efraim Flashner
2021-03-16  6:45   ` [bug#47182] [PATCH 08/18] gnu: bdb-4.8: Fix configure on powerpc64le-linux Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 09/18] gnu: guile-avahi: Fix compilation " Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 10/18] gnu: texlive-bin: Fix compilation on powerpc64le* Chris Marusich
2021-03-16  7:53     ` Efraim Flashner
2021-03-18  6:16       ` [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) Chris Marusich
2021-03-18  8:34         ` Efraim Flashner [this message]
2021-03-19  6:22           ` Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 11/18] gnu: texlive-latex-base: Fix compilation on powerpc64le* Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 12/18] gnu: libelf: Fix compilation for powerpc64le-linux Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 13/18] Add powerpc64le-linux as a supported Guix architecture Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 14/18] syscalls: Fix clone on powerpc64le-linux Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 15/18] syscalls: Fix RNDADDTOENTCNT " Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 16/18] ci: %cross-targets: Add powerpc64le-linux-gnu Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 17/18] utils: Fix target-64bit? on powerpc64le-linux Chris Marusich
2021-03-16  6:45   ` [bug#47182] [PATCH 18/18] gnu: sed: Make it build on SELinux-enabled kernels Chris Marusich
2021-03-16  8:30   ` [bug#47182] [PATCH 01/18] gnu: bootstrap: Add support for powerpc64le-linux Chris Marusich
2021-03-16  9:33 ` [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) Léo Le Bouter via Guix-patches via
2021-03-17  6:58   ` Chris Marusich
2021-03-17 20:33     ` Christopher Baines
2021-03-18  6:08       ` Chris Marusich
2021-03-24  6:36 ` bug#47182: Merged to master Chris Marusich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFMQgRR9Ub1Prdlo@3900XT \
    --to=efraim@flashner.co.il \
    --cc=47182@debbugs.gnu.org \
    --cc=cmmarusich@gmail.com \
    --cc=lle-bout@zaclys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).