* [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
@ 2021-02-24 3:03 Carl Dong
2021-02-24 8:17 ` Efraim Flashner
0 siblings, 1 reply; 5+ messages in thread
From: Carl Dong @ 2021-02-24 3:03 UTC (permalink / raw)
To: 46741; +Cc: Carl Dong
* gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
---
gnu/packages/linux.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c87c5ffb09..30cbebf849 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -181,6 +181,7 @@
defconfig. Return the appropriate make target if applicable, otherwise return
\"defconfig\"."
(cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
+ ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
(else "defconfig")))
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
2021-02-24 3:03 [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE) Carl Dong
@ 2021-02-24 8:17 ` Efraim Flashner
2021-02-24 20:30 ` Carl Dong
0 siblings, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2021-02-24 8:17 UTC (permalink / raw)
To: Carl Dong; +Cc: 46741
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> ---
> gnu/packages/linux.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index c87c5ffb09..30cbebf849 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -181,6 +181,7 @@
> defconfig. Return the appropriate make target if applicable, otherwise return
> \"defconfig\"."
> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> (else "defconfig")))
>
> --
> 2.30.1
>
>
>
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
2021-02-24 8:17 ` Efraim Flashner
@ 2021-02-24 20:30 ` Carl Dong
2021-02-25 6:09 ` Efraim Flashner
2021-02-25 10:22 ` Efraim Flashner
0 siblings, 2 replies; 5+ messages in thread
From: Carl Dong @ 2021-02-24 20:30 UTC (permalink / raw)
To: Efraim Flashner; +Cc: 46741
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
Carl Dong
contact@carldong.me
"I fight for the users"
> On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
> On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
>> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
>> ---
>> gnu/packages/linux.scm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index c87c5ffb09..30cbebf849 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -181,6 +181,7 @@
>> defconfig. Return the appropriate make target if applicable, otherwise return
>> \"defconfig\"."
>> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
>> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
>> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
>
> would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
>
>> (else "defconfig")))
>>
>> --
>> 2.30.1
>>
>>
>>
>>
>
> --
> Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
2021-02-24 20:30 ` Carl Dong
@ 2021-02-25 6:09 ` Efraim Flashner
2021-02-25 10:22 ` Efraim Flashner
1 sibling, 0 replies; 5+ messages in thread
From: Efraim Flashner @ 2021-02-25 6:09 UTC (permalink / raw)
To: Carl Dong; +Cc: 46741
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]
On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
Definitely what I meant to write
>
> Carl Dong
> contact@carldong.me
> "I fight for the users"
>
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig. Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> >
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> >
> >> (else "defconfig")))
> >>
> >> --
> >> 2.30.1
> >>
> >>
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
2021-02-24 20:30 ` Carl Dong
2021-02-25 6:09 ` Efraim Flashner
@ 2021-02-25 10:22 ` Efraim Flashner
1 sibling, 0 replies; 5+ messages in thread
From: Efraim Flashner @ 2021-02-25 10:22 UTC (permalink / raw)
To: Carl Dong; +Cc: 46741
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
I did some quick testing from the guile repl and it looks like it
doesn't take a regex. I have no preference between two entries for
'powerpc64-' and 'powerpc64le-' vs 'powerpc64'.
On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
>
> Carl Dong
> contact@carldong.me
> "I fight for the users"
>
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig. Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> >
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> >
> >> (else "defconfig")))
> >>
> >> --
> >> 2.30.1
> >>
> >>
> >>
> >>
> >
> > --
> > Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
> > GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> > Confidentiality cannot be guaranteed on emails sent or received unencrypted
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-25 10:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-24 3:03 [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE) Carl Dong
2021-02-24 8:17 ` Efraim Flashner
2021-02-24 20:30 ` Carl Dong
2021-02-25 6:09 ` Efraim Flashner
2021-02-25 10:22 ` Efraim Flashner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).