From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8Ao/AuegMWA4UgAA0tVLHw (envelope-from ) for ; Sat, 20 Feb 2021 23:53:11 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WFGVOeagMWBuEAAAB5/wlQ (envelope-from ) for ; Sat, 20 Feb 2021 23:53:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 6A0791988A for ; Sun, 21 Feb 2021 00:53:10 +0100 (CET) Received: from localhost ([::1]:32946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDc3h-0005pR-IV for larch@yhetil.org; Sat, 20 Feb 2021 18:53:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDc3a-0005pJ-Ii for guix-patches@gnu.org; Sat, 20 Feb 2021 18:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDc3a-0001U8-9v for guix-patches@gnu.org; Sat, 20 Feb 2021 18:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDc3a-0001h7-7u for guix-patches@gnu.org; Sat, 20 Feb 2021 18:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46500] [PATCH] gnu: Add monado Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Feb 2021 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46500 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 46500@debbugs.gnu.org Received: via spool by 46500-submit@debbugs.gnu.org id=B46500.16138651486469 (code B ref 46500); Sat, 20 Feb 2021 23:53:02 +0000 Received: (at 46500) by debbugs.gnu.org; 20 Feb 2021 23:52:28 +0000 Received: from localhost ([127.0.0.1]:53106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDc2y-0001gD-K1 for submit@debbugs.gnu.org; Sat, 20 Feb 2021 18:52:28 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:50875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDc2w-0001g0-02 for 46500@debbugs.gnu.org; Sat, 20 Feb 2021 18:52:23 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 11D744E7; Sat, 20 Feb 2021 18:52:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 20 Feb 2021 18:52:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=Ben+ScIKEaGvdfXzcCwCjqjYZd/F+ME3KGjSUoTvuQQ=; b=t7UpUQP00u7/ gUfajjNlEzjFIF4+n1fKmOKzhCa2CCB3oDyV0P6SqzW7T0jzgeb6X0kXPgZsnNbp +DP6Mrkfw6gftd9CsdKDtbK2DTLjgVICvEuQev6mSpohX6zt21kaH2ebanXqL5ur t/ydJvsR/cx2gpxgRcein0CnCQB2EHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Ben+ScIKEaGvdfXzcCwCjqjYZd/F+ME3KGjSUoTvu QQ=; b=QLOYDiez04NN/gayD+giTslG6EqaXm2taTaTDyu/7O5cgaTQBzrnkE4a+ d0K5XInSlHnLyXZ3kLAs9h07XFoRBvvG67RkDhluu8dtDVhRuzER9Vmz+IlgR7Zm ys/jYzSZq2TcmB2nUyatqVWNOFneINnButpzZteJV62pC7uyV78Zno+TPIZ7pR/G P1+jh3i+soaj5y8klqTQoXC1+OSEHhTSZlxC1hPg/LhmHfLwsNc+3699R8arfS7S 4NiBmvEK09bBO1UZQZ1OudC9M06EsEgZGiTe/0buQQsbcCQhe09NsW4lGXXARrVf 4QU0fK7w2hWUV2Dd+5TFC5kB/2QYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeelgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeiieegtdeggfevfeethffhvdeifefhhfekueelvedvueejgeelgeeivedvheeu ueenucffohhmrghinhepghhnuhdrohhrghdpfhhrvggvuggvshhkthhophdrohhrghenuc fkphepieelrdduvddtrdelvddrvddtkeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (ool-45785cd0.dyn.optonline.net [69.120.92.208]) by mail.messagingengine.com (Postfix) with ESMTPA id 19A81108005B; Sat, 20 Feb 2021 18:52:15 -0500 (EST) Date: Sat, 20 Feb 2021 18:52:13 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=t7UpUQP0; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=QLOYDiez; dmarc=none; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6A0791988A X-Spam-Score: -1.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: t6y9TEIds/sa On Sat, Feb 13, 2021 at 06:12:01PM -0800, Andy Tai wrote: > * gnu/packages/graphics.scm (monado): New variable Thanks for the patch! You had asked in #46666 about how to make the review process go more quickly. We definitely aim for it to be fast and efficient for contributors, but there are a lot of patches (good!) and reviewers can get tired. When that happens to me, I start to focus my reviewing energy on patches that I think will be easy, which means ready-to-push, or on patches for things I find interesting. I think that's human nature. It would be better if patches were reviewed more systematically. My goal when reviewing is to push contributions to guix.git and close patch tickets. The linter found a couple issues: ------ $ guix environment guix -- ./pre-inst-env guix lint monado gnu/packages/graphics.scm:1953:5: monado@21.0.0: sentences in description should be followed by two spaces; possible infractions at 191, 285 gnu/packages/graphics.scm:1943:0: monado@21.0.0: parentheses feel lonely, move to the previous or next line gnu/packages/graphics.scm:1948:0: monado@21.0.0: parentheses feel lonely, move to the previous or next line gnu/packages/graphics.scm:1924:16: monado@21.0.0: source not archived on Software Heritage ------ I noticed the parentheses thing before linting, and some extra blank lines before and after the new package, too. These problems are effectively cosmetic but, when I see them, I guess that there might be some other problems that can't be caught with a simple linter, and I get discouraged from putting more effort into it. So, definitely run the linter. Don't hesitate to ask for help if you don't understand how to use it or what it says. I applied the patch on the current master branch and built it. It fails in the install phase like this: ------ starting phase `install' [1/14] Generating u_git_tag.c with a custom command. [2/6] Generating driver_resources_copy with a custom command. DIRECTORY ../monado-v21.0.0/src/xrt/targets/steamvr_drv/resources /tmp/guix-build-monado-21.0.0.drv-0/build/steamvr-monado/resources Copying asset ../monado-v21.0.0/src/xrt/targets/steamvr_drv/resources to /tmp/guix-build-monado-21.0.0.drv-0/build/steamvr-monado/resources [3/6] Generating driver_manifest_copy with a custom command. FILE ../monado-v21.0.0/src/xrt/targets/steamvr_drv/driver.vrdrivermanifest /tmp/guix-build-monado-21.0.0.drv-0/build/steamvr-monado/driver.vrdrivermanifest Copying asset ../monado-v21.0.0/src/xrt/targets/steamvr_drv/driver.vrdrivermanifest to /tmp/guix-build-monado-21.0.0.drv-0/build/steamvr-monado/driver.vrdrivermanifest [4/6] Generating driver_input_profiles_generate with a custom command. [5/6] Generating plugin_copy with a custom command. Copying plugin src/xrt/targets/steamvr_drv/driver_monado.so to /tmp/guix-build-monado-21.0.0.drv-0/build/steamvr-monado/bin/linux64/driver_monado.so [5/6] Installing files. + sysconfdir=/etc + manifest=/gnu/store/9598lvcgad60xfid8qxpm0w4p8g9ldr6-monado-21.0.0/share/openxr/1/openxr_monado.json + xrversion=1 + runtime_path=/etc/xdg/openxr/1/active_runtime.json + mkdir -p /etc/xdg/openxr/1 mkdir: cannot create directory ‘/etc/xdg’: Permission denied [...] ------ Can you look into that? > + (synopsis "The open source OpenXR runtime") > + (description > + "Monado is an open source XR runtime delivering immersive > experiences such as VR > +and AR on mobile, PC/desktop, and any other device(because gosh darn peoplecome > +up with a lot of weird hardware). Monado aims to be a complete and conforming > +implementation of the OpenXR API made by Khronos. The project > currently is being > +developed for GNU/Linux and aims to support other operating systems in the near > +future.") Guix only includes free software so we usually don't describe packages as "open source" or "free software". I appreciate the colloquial language in the parentheses but I would remove it. We actually have a style guide in the manual: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > + (license (license:x11-style > "https://gitlab.freedesktop.org/monado/monado/-/blob/master/LICENSE")))) This looks like the "Boost Software License".